Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes

["Ard Biesheuvel" <ardb@kernel.org>]

On Mon, 18 Sept 2023 at 13:35, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote:
> > There are some changes in progress which make BL1 bigger than 0x8000
> > which EDK2 uses.
> >
> > TF-A defines BL1 size to be 0x12000 one. So let follow it.
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>
> This fixes a TF-A bug that you uncovered this morning, and I think
> that's worth pointing out in the commit message.
>
> However,
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>
> *But* this is a breaking change SoI want to hold off on merging
> this until the TF-A bugfix has been merged, so we can update the
> edk2-non-osi binaries at the same time, and minimise the amount of
> pain.
>
> Note for the interested:
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417
> TL;DR: the fip base and bl1 size don't line up. The bl1 size was
> already set to sufficient size, but after RME support in TF-A, bl1
> size grows beyond start of fip.
>

Are you saying that Platform/Qemu/Sbsa/bl1.bin was more than 0x8000
bytes in size, and the EDK2 build tools happily truncated it?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108773): https://edk2.groups.io/g/devel/message/108773
Mute This Topic: https://groups.io/mt/101430708/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-