From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D178ED8106A for ; Mon, 18 Sep 2023 12:34:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=18VPzIllt+b5x74s9k6vJeRKBK7MLpXklMZwVVyMYO8=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695040456; v=1; b=v6D99wBYBBsm/dSlifgmB0fwdHSNSrM/ppK7GjkW821QinFZjJ1qgKn2+lr4S8RAML/0w0x5 fDWKVlufzvfFF9fG8XZ8Ky1m9mXIJv7qQ5O+s3NpEXpGmFTTC8kJxR2swz+D/GADdqTqzSz0H9t OmNwCnw6B1pL29jiMQM8WuvI= X-Received: by 127.0.0.2 with SMTP id 77kfYY7687511xVn1jj4NFt3; Mon, 18 Sep 2023 05:34:16 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.50002.1695040455514156344 for ; Mon, 18 Sep 2023 05:34:15 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB0F9B80E25 for ; Mon, 18 Sep 2023 12:34:13 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AE74C433CB for ; Mon, 18 Sep 2023 12:34:12 +0000 (UTC) X-Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2b95d5ee18dso74511861fa.1 for ; Mon, 18 Sep 2023 05:34:12 -0700 (PDT) X-Gm-Message-State: IiNC47VtqhIO6q0IQnd6AyaMx7686176AA= X-Google-Smtp-Source: AGHT+IFa1qa5ZB+nmQpT/GbM9ZDPW0+PZ6Xqs9KhMJxtCLj+/z71KSs21Kju4J9q4jXEL+pRke59mV8sB8yY2SgoqBg= X-Received: by 2002:a2e:b98b:0:b0:2c0:168c:e6bd with SMTP id p11-20020a2eb98b000000b002c0168ce6bdmr1087948ljp.28.1695040450820; Mon, 18 Sep 2023 05:34:10 -0700 (PDT) MIME-Version: 1.0 References: <20230918110312.315671-1-marcin.juszkiewicz@linaro.org> In-Reply-To: From: "Ard Biesheuvel" Date: Mon, 18 Sep 2023 14:33:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes To: Leif Lindholm Cc: Marcin Juszkiewicz , devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=v6D99wBY; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) On Mon, 18 Sept 2023 at 13:35, Leif Lindholm wrote: > > On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote: > > There are some changes in progress which make BL1 bigger than 0x8000 > > which EDK2 uses. > > > > TF-A defines BL1 size to be 0x12000 one. So let follow it. > > > > Signed-off-by: Marcin Juszkiewicz > > This fixes a TF-A bug that you uncovered this morning, and I think > that's worth pointing out in the commit message. > > However, > Reviewed-by: Leif Lindholm > > *But* this is a breaking change SoI want to hold off on merging > this until the TF-A bugfix has been merged, so we can update the > edk2-non-osi binaries at the same time, and minimise the amount of > pain. > > Note for the interested: > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417 > TL;DR: the fip base and bl1 size don't line up. The bl1 size was > already set to sufficient size, but after RME support in TF-A, bl1 > size grows beyond start of fip. > Are you saying that Platform/Qemu/Sbsa/bl1.bin was more than 0x8000 bytes in size, and the EDK2 build tools happily truncated it? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108773): https://edk2.groups.io/g/devel/message/108773 Mute This Topic: https://groups.io/mt/101430708/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-