Re: [PATCH] EmbeddedPkg/RealTimeClockRuntimeDxe: Improve GetWakeupTime

["Ard Biesheuvel" <ardb@kernel.org>]

On Mon, 24 May 2021 at 05:55, Marcin Wojtas <mw@semihalf.com> wrote:
>
> GetWakeupTime should return full time information, including
> the daylight/timezone. Make use of the existing non-volatile
> variables for that purpose. Moreover add an error checking
> of possibly invalid parameters.
> This partially fixes FWTS and SCT Set/GetWakeupTime tests on
> Marvell platforms.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Merged as #1682

Thanks,

> ---
>  EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> index e59036badc..85650a6ede 100644
> --- a/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> +++ b/EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClock.c
> @@ -143,6 +143,17 @@ GetWakeupTime (
>    OUT EFI_TIME    *Time
>    )
>  {
> +  if (Time == NULL || Enabled == NULL || Pending == NULL) {
> +    return EFI_INVALID_PARAMETER;
> +  }
> +
> +  //
> +  // Set these first so the RealTimeClockLib implementation
> +  // can override them based on its own settings.
> +  //
> +  Time->TimeZone = mTimeSettings.TimeZone;
> +  Time->Daylight = mTimeSettings.Daylight;
> +
>    return LibGetWakeupTime (Enabled, Pending, Time);
>  }
>
> --
> 2.29.0
>