From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.40432.1629212987877540450 for ; Tue, 17 Aug 2021 08:09:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=I/gatF4E; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 925BD61075 for ; Tue, 17 Aug 2021 15:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629212985; bh=f28NisOum00ff1DGs7Do89P9FUKE1QE3pS2caOE6xos=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=I/gatF4EM/rNJ/T/4G/w3rYCPlZ/w/4wn4oJz9n+fS2Jv7KtAzygIzvzlAZiSq5lG bPzU6mgBqmW1d2Eo/LQbFxvtUyT8sUgQSfOpPGrMwDarW+CI8Ee28Q3PHHJR80t+V7 AzXJtPtZVs9xl3RregotGWuJWFXt0sIIvM8R5Bke2EPYX3D4UyME7zFtjF4objhkWF gbRn9WPVwBCMRJU99PbWPozT6a4V9UWFMv8vyE5QqBRppL7jGnSy2XJFsS2EgUHl90 LonDQGiU9vj2XlvpOjrr/vSyyeOBDIJf9yJ9lT16IZDgrwSaLoHv+hkMJpyW6jI+Eo iovxPq3Vwo7fQ== Received: by mail-oi1-f177.google.com with SMTP id w6so32260757oiv.11 for ; Tue, 17 Aug 2021 08:09:45 -0700 (PDT) X-Gm-Message-State: AOAM531BSHfKFv3sILD+x87Dbc3qyYvluK62I7jrVe86NoUkA7KWiKmQ TyX2HFTN6ZCCQxzXkts3VkWQiRV5kxSClR5egKo= X-Google-Smtp-Source: ABdhPJzuPfBKuUFnAtE8l0qlNtpZMRZQwc62aAqilSQoAJwiXwSQEIrZ27osO5dsT6k5OLj4iEAMKqZUxRdYt4mLz30= X-Received: by 2002:aca:dd89:: with SMTP id u131mr2950264oig.47.1629212984987; Tue, 17 Aug 2021 08:09:44 -0700 (PDT) MIME-Version: 1.0 References: <20210810033618.5139-1-jeremy.linton@arm.com> In-Reply-To: <20210810033618.5139-1-jeremy.linton@arm.com> From: "Ard Biesheuvel" Date: Tue, 17 Aug 2021 17:09:32 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/6] RPi4: Enable ACPI PCIe conduit To: Jeremy Linton Cc: edk2-devel-groups-io , Peter Batard , Ard Biesheuvel , Andrei Warkentin , Sunny Wang , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" On Tue, 10 Aug 2021 at 05:36, Jeremy Linton wrote: > > A new Arm standard DEN0115A specifies how > platforms that don't have standard ECAM can > use the firmware to handle config read/write > operations. This is mostly implemented in TFA > but UEFI needs to assure that there is a > description of the root complex in the ACPI > namespace. > > This set adds that description based on > a new menu item which toggles between XHCI > platform description and PCIe via a BDS > menu selection on the RPi4. The CM4 is really > the platform that needs this as it has a PCIe > slot. On that platform PCIe is enabled by default. > > v1->v2: > Use global shared interrupts in PCI PRT > which is a pretty significant > simplification. > Modify bus max to use the secondary side > of the root port for enforcing device > limits > Various other AML cleanups per Ard (drop > redundant _DMA, bump UID to make it > unique, etc) I still see a _DMA method on the PCIE node, and the UID you chose is already used elsewhere. > Break link status move into its own patch > MADT->MCFG typos in various comments > Commit message tweaking > > Jeremy Linton (6): > Platform/RaspberryPi: Add XHCI/PCI selection menu > Platform/RaspberryPi: Break XHCI into its own SSDT > Platform/RaspberryPi: Add PCIe SSDT > Silicon/Broadcom/Bcm27xx: Relax PCIe device restriction > Silicon/Broadcom/Bcm27xx: Move linkup check into the cfg accessor > Platform/RaspberryPi: Enable NVMe boot on CM4 > > Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 4 + > Platform/RaspberryPi/AcpiTables/Dsdt.asl | 3 - > Platform/RaspberryPi/AcpiTables/Pci.asl | 209 +++++++++++++++++++++ > Platform/RaspberryPi/AcpiTables/Xhci.asl | 35 ++-- > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 56 ++++++ > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf | 1 + > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 5 + > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 17 ++ > Platform/RaspberryPi/Include/ConfigVars.h | 4 + > Platform/RaspberryPi/RPi3/RPi3.dsc | 6 + > Platform/RaspberryPi/RPi4/RPi4.dsc | 13 ++ > Platform/RaspberryPi/RPi4/RPi4.fdf | 5 + > Platform/RaspberryPi/RaspberryPi.dec | 1 + > .../Bcm2711PciHostBridgeLibConstructor.c | 5 - > .../Library/Bcm2711PciSegmentLib/PciSegmentLib.c | 28 ++- > 15 files changed, 364 insertions(+), 28 deletions(-) > create mode 100644 Platform/RaspberryPi/AcpiTables/Pci.asl > > -- > 2.13.7 >