From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.3450.1660576584435024856 for ; Mon, 15 Aug 2022 08:16:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jf1PU07P; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3B6F61074 for ; Mon, 15 Aug 2022 15:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47515C433B5 for ; Mon, 15 Aug 2022 15:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660576583; bh=1tJb9V5BlHp62AgCKAUujYihJNYaKfsLMFtzwqRpoG0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Jf1PU07P1dd7uOXGjEIDnJvuFqq2QpMEl3xcZUSkCA/xMuDc2QEATw++TmfwgtX7n dtNr/H6P47nzyqTz2vVUvHKqg7vEMesiVP4/4TjE0e+9vExlWMfatJYhUOAtzJuuME WhvNpNQr3hw2svy/kebXnJAYFX1IrV3Oxa8u1TRaYGqD+OtxSW1gCkq5QlWqTQxuKP QPm0Alz685ygmCvV7yfzY9OG4A8UkSn8IqaqbQC2FrFY2N+g+MuNaetRwdfgWfWMEP HDAIILedjjK0KbCudbZDR2CIR3PXKnKXeaZSlp/gp4T3hyDmSJmpfP7/83BBtRBuKa iyRjppy0RW4mA== Received: by mail-wr1-f41.google.com with SMTP id bv3so9431582wrb.5 for ; Mon, 15 Aug 2022 08:16:23 -0700 (PDT) X-Gm-Message-State: ACgBeo0p+cI6f2erAdNfTNe53Iaz386Xl/hHiCEi0cDjKGHFRN/ZdqB9 /BgnpIXKwftoSUOZBSTI2W8ou+mzGoU9rUk94K4= X-Google-Smtp-Source: AA6agR4nxMUCBsgiUVH0CFaTp5GeTZYpbQQNy7Fl6ayHSYaVfYq1OdyO2lECULQhxh/qMXzKdwNtUFqlL+97GnRdGgw= X-Received: by 2002:adf:d238:0:b0:21e:c972:7505 with SMTP id k24-20020adfd238000000b0021ec9727505mr9268634wrh.536.1660576581458; Mon, 15 Aug 2022 08:16:21 -0700 (PDT) MIME-Version: 1.0 References: <20220815145943.2874065-1-dimitrije.pavlov@arm.com> In-Reply-To: <20220815145943.2874065-1-dimitrije.pavlov@arm.com> From: "Ard Biesheuvel" Date: Mon, 15 Aug 2022 17:16:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments To: devel@edk2.groups.io, Dimitrije.Pavlov@arm.com Cc: Ard Biesheuvel , Jiewen Yao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" On Mon, 15 Aug 2022 at 16:59, Dimitrije Pavlov wrote: > > The current implementation does not check if Language or DriverName > are NULL. This causes the SCT test suite to crash. > > Add a check to return EFI_INVALID_PARAMETER if any of these pointers > are NULL. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Sunny Wang > Cc: Jeff Booher-Kaeding > Cc: Samer El-Haj-Mahmoud > > Signed-off-by: Dimitrije Pavlov Hello Dimitrije, These patches look corrupted again. Can you please double check your setup, and maybe compare notes with colleagues how to send patches to the list in a way that doesn't corrupt them? And when you resubmit, please cc liming gao as well - he is in charge of the stable tag release process, and these are all bug fixes that should be included in the tag. Also, please turn these individual patches into a single series. > --- > OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/DriverBinding.c > index 86eb9cf0ba51..3d80ff0f91f5 100644 > --- a/OvmfPkg/VirtioFsDxe/DriverBinding.c > +++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c > @@ -218,6 +218,10 @@ VirtioFsGetDriverName ( > OUT CHAR16 **DriverName > ) > { > + if (Language NULL || DriverName NULL) { > + return EFI_INVALID_PARAMETER; > + } > + > if (AsciiStrCmp (Language, "en") ! 0) { > return EFI_UNSUPPORTED; > } > -- > 2.37.1 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#92434): https://edk2.groups.io/g/devel/message/92434 > Mute This Topic: https://groups.io/mt/93038111/5717338 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org] > ------------ > >