* [PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments
@ 2022-08-15 14:59 Dimitrije Pavlov
2022-08-15 15:16 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Dimitrije Pavlov @ 2022-08-15 14:59 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Jiewen Yao, Sunny Wang, Jeff Booher-Kaeding,
Samer El-Haj-Mahmoud
The current implementation does not check if Language or DriverName
are NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Sunny Wang <Sunny.Wang@arm.com>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
---
OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/DriverBinding.c
index 86eb9cf0ba51..3d80ff0f91f5 100644
--- a/OvmfPkg/VirtioFsDxe/DriverBinding.c
+++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c
@@ -218,6 +218,10 @@ VirtioFsGetDriverName (
OUT CHAR16 **DriverName
)
{
+ if (Language == NULL || DriverName == NULL) {
+ return EFI_INVALID_PARAMETER;
+ }
+
if (AsciiStrCmp (Language, "en") != 0) {
return EFI_UNSUPPORTED;
}
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments
2022-08-15 14:59 [PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Dimitrije Pavlov
@ 2022-08-15 15:16 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2022-08-15 15:16 UTC (permalink / raw)
To: devel, Dimitrije.Pavlov
Cc: Ard Biesheuvel, Jiewen Yao, Sunny Wang, Jeff Booher-Kaeding,
Samer El-Haj-Mahmoud
On Mon, 15 Aug 2022 at 16:59, Dimitrije Pavlov <Dimitrije.Pavlov@arm.com> wrote:
>
> The current implementation does not check if Language or DriverName
> are NULL. This causes the SCT test suite to crash.
>
> Add a check to return EFI_INVALID_PARAMETER if any of these pointers
> are NULL.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Sunny Wang <Sunny.Wang@arm.com>
> Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@arm.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
>
> Signed-off-by: Dimitrije Pavlov <Dimitrije.Pavlov@arm.com>
Hello Dimitrije,
These patches look corrupted again. Can you please double check your
setup, and maybe compare notes with colleagues how to send patches to
the list in a way that doesn't corrupt them?
And when you resubmit, please cc liming gao as well - he is in charge
of the stable tag release process, and these are all bug fixes that
should be included in the tag. Also, please turn these individual
patches into a single series.
> ---
> OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/DriverBinding.c
> index 86eb9cf0ba51..3d80ff0f91f5 100644
> --- a/OvmfPkg/VirtioFsDxe/DriverBinding.c
> +++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c
> @@ -218,6 +218,10 @@ VirtioFsGetDriverName (
> OUT CHAR16 **DriverName
> )
> {
> + if (Language NULL || DriverName NULL) {
> + return EFI_INVALID_PARAMETER;
> + }
> +
> if (AsciiStrCmp (Language, "en") ! 0) {
> return EFI_UNSUPPORTED;
> }
> --
> 2.37.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#92434): https://edk2.groups.io/g/devel/message/92434
> Mute This Topic: https://groups.io/mt/93038111/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-15 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-15 14:59 [PATCH v1 1/1] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Dimitrije Pavlov
2022-08-15 15:16 ` [edk2-devel] " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox