From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A52CF740032 for ; Fri, 18 Aug 2023 21:05:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=K2V1UzGqKyh4HxoEhqc6R7A1ix+en3KfMp7+zKpdxmI=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692392736; v=1; b=I+CKOY8zlfqTXrMVDs0VScDIPKRjigiJfXwEBEi/gNbM3/CG/Z7gbZCLCpxqMHS7HRnRkL/E Eu4Lz0LAxmRbjWNPyUouEE7QTBuH5Je+ws1FzIse+aE7qLhEIfQhkV8ewuDuT3MOR3o1jGOvu+L veljrYjZTWtxq5hpRshv/BXI= X-Received: by 127.0.0.2 with SMTP id iA9EYY7687511xZTYsjq9twx; Fri, 18 Aug 2023 14:05:36 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.1528.1692392735713293361 for ; Fri, 18 Aug 2023 14:05:35 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37CFC632CD for ; Fri, 18 Aug 2023 21:05:35 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B7FAC433C9 for ; Fri, 18 Aug 2023 21:05:34 +0000 (UTC) X-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4ff933f9ca8so1984339e87.1 for ; Fri, 18 Aug 2023 14:05:34 -0700 (PDT) X-Gm-Message-State: bGyV0MeAzTuOxeGWXq7aCNxWx7686176AA= X-Google-Smtp-Source: AGHT+IHqO6azHxrt218BljjNQrblVEwhTxOiFW25tvbjBFs6UCyykR4LRFiMR37MtlWTUZmMrWR6TlaGX9NxbGfaSA8= X-Received: by 2002:a05:6512:3d8b:b0:4ff:80d4:e12f with SMTP id k11-20020a0565123d8b00b004ff80d4e12fmr220749lfv.60.1692392732631; Fri, 18 Aug 2023 14:05:32 -0700 (PDT) MIME-Version: 1.0 References: <20230818181751.12308-1-osde@linux.microsoft.com> In-Reply-To: <20230818181751.12308-1-osde@linux.microsoft.com> From: "Ard Biesheuvel" Date: Fri, 18 Aug 2023 23:05:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel][PATCH v1 1/1] ArmVirtPkg: ArmVirtQemu: Add Graphics and Input To: Oliver Smith-Denny Cc: devel@edk2.groups.io, Leif Lindholm , Sami Mujawar , Gerd Hoffmann Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I+CKOY8z; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, 18 Aug 2023 at 20:17, Oliver Smith-Denny wrote: > > Currently, unlike OVMF, ArmVirtQemu does not display any graphics, > only the QEMU monitor. Graphics are helpful to confirm booting into > an OS is successful, interacting with the EFI shell while getting > separate logging messages, etc. > > This patch adds the QEMU parameters to launch a graphical window > and add a USB keyboard and mouse, which is modeled as a tablet as > it tracks better in QEMU than a generic mouse. virtio-gpu-pci is > chosen as the graphics device as it is recommended by QEMU for the > ARM virtual platform. > > The graphics and USB input devices will only be added to QEMU when > QEMU_HEADLESS == FALSE, so CI builds will not attempt to use the > graphics and if a user does not want graphics, they can add > QEMU_HEADLESS=TRUE to the build cmdline. > > GitHub PR: https://github.com/tianocore/edk2/pull/4750 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Gerd Hoffmann > > Signed-off-by: Oliver Smith-Denny Reviewed-by: Ard Biesheuvel Feel free to remind me to queue this up after the stable tag release. > --- > ArmVirtPkg/PlatformCI/PlatformBuildLib.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py b/ArmVirtPkg/PlatformCI/PlatformBuildLib.py > index 405817cae785..0ddaccf9c21f 100644 > --- a/ArmVirtPkg/PlatformCI/PlatformBuildLib.py > +++ b/ArmVirtPkg/PlatformCI/PlatformBuildLib.py > @@ -244,6 +244,11 @@ class PlatformBuilder(UefiBuilder, BuildSettingsManager): > # Conditional Args > if (self.env.GetValue("QEMU_HEADLESS").upper() == "TRUE"): > args += " -display none" # no graphics > + else: > + args += " -device virtio-gpu-pci" # add recommended QEMU graphics device > + args += " -device qemu-xhci,id=usb" # add USB support for below devices > + args += " -device usb-tablet,id=input0,bus=usb.0,port=1" # add a usb mouse > + args += " -device usb-kbd,id=input1,bus=usb.0,port=2" # add a usb keyboard > > if (self.env.GetValue("MAKE_STARTUP_NSH").upper() == "TRUE"): > f = open(os.path.join(VirtualDrive, "startup.nsh"), "w") > -- > 2.40.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107854): https://edk2.groups.io/g/devel/message/107854 Mute This Topic: https://groups.io/mt/100826022/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-