From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 738F69413C2 for ; Thu, 7 Sep 2023 14:17:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0/jVJMC9ioLI57YFqdnIVhcPHfvBgOlR/DALD06MMVY=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1694096256; v=1; b=rI3x8/RUEs2J9HPrpX5dauYUUJz8EZb+dzVa2YRtf3nXfU0lEHyQqA6GLImsGIU+szH4y+EB +JC/KoYgkVAhK+f8GJxtAVkD2Ls0hqzovcab+lSRT/BQ4QzuqgRMuIo2fpIiK0FsIFMASqyd9dL 37UZ1tTcYSWPvhGh50wdPlPY= X-Received: by 127.0.0.2 with SMTP id Ha96YY7687511x2mgn7uLBTG; Thu, 07 Sep 2023 07:17:36 -0700 X-Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.14102.1694096255303063583 for ; Thu, 07 Sep 2023 07:17:35 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 686BEB81E82 for ; Thu, 7 Sep 2023 14:17:33 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A893C32792 for ; Thu, 7 Sep 2023 14:17:32 +0000 (UTC) X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5008d16cc36so1671664e87.2 for ; Thu, 07 Sep 2023 07:17:31 -0700 (PDT) X-Gm-Message-State: NRfSAQcvovHuNT1yyJTW0SpMx7686176AA= X-Google-Smtp-Source: AGHT+IEWalvQR2wnSIQsI6/wYzilyCyrJb3tfEmBDNjrG9kFPLAde46vXMbzXvHxeNaxotC+n4KeYAiCe9dHH6LOL8A= X-Received: by 2002:a2e:9606:0:b0:2bc:b694:6d63 with SMTP id v6-20020a2e9606000000b002bcb6946d63mr4431820ljh.25.1694096250027; Thu, 07 Sep 2023 07:17:30 -0700 (PDT) MIME-Version: 1.0 References: <0048beef351cf6fb6646a171c0a6eb01f2d3829f.1688071551.git.jbrasen@nvidia.com> In-Reply-To: <0048beef351cf6fb6646a171c0a6eb01f2d3829f.1688071551.git.jbrasen@nvidia.com> From: "Ard Biesheuvel" Date: Thu, 7 Sep 2023 16:17:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH] ArmPkg/ArmPsciMpServices Add EFI_NOT_READY return To: devel@edk2.groups.io, jbrasen@nvidia.com Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, rebecca@bsdio.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="rI3x8/RU"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 29 Jun 2023 at 22:47, Jeff Brasen via groups.io wrote: > > Add EFI_NOT_READY return if the CPU can not be enabled if the > processor is already on. > > This can occur in normal use if the CPU is still being turned off from > a previous call when this is called again. > > Signed-off-by: Jeff Brasen Acked-by: Ard Biesheuvel I'll queue this up - thanks. > --- > ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > index f822a9877c..e7f4223513 100644 > --- a/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > +++ b/ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c > @@ -103,7 +103,9 @@ DispatchCpu ( > > ArmCallSmc (&Args); > > - if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) { > + if (Args.Arg0 == ARM_SMC_PSCI_RET_ALREADY_ON) { > + Status = EFI_NOT_READY; > + } else if (Args.Arg0 != ARM_SMC_PSCI_RET_SUCCESS) { > DEBUG ((DEBUG_ERROR, "PSCI_CPU_ON call failed: %d\n", Args.Arg0)); > Status = EFI_DEVICE_ERROR; > } > -- > 2.25.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108394): https://edk2.groups.io/g/devel/message/108394 Mute This Topic: https://groups.io/mt/99859167/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-