From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47])
 by mx.groups.io with SMTP id smtpd.web12.32891.1641828574029480714
 for <devel@edk2.groups.io>;
 Mon, 10 Jan 2022 07:29:34 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@google.com header.s=20210112 header.b=I3irWAB+;
 spf=pass (domain: google.com, ip: 209.85.167.47, mailfrom: pgonda@google.com)
Received: by mail-lf1-f47.google.com with SMTP id d3so19301290lfv.13
        for <devel@edk2.groups.io>; Mon, 10 Jan 2022 07:29:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=google.com; s=20210112;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=pYSQ9gfJWZTZGEJx+qC0pyZV1qEmlv4r+fR8DYPNJd0=;
        b=I3irWAB+MbUY71NgxWF6Lil+0aXkGUtE3Jlucq8egzt3bdOhVbq1T9khshTm7tD6x7
         db3VZi1lQblubhP1BV7v4gaUb1AsdjbjkUYZ+Q9LhQGs52i7hhz52miEMuEaNCDs1qWa
         8VWtiPo84Z95PY4u0kVEjjLvn++SUajSDpL3sc8nxEUnwUM+iPhTXFSBv/8pUFWrCiJn
         Z/Iprvh2QvE85iPDS+ysZxVQO0Hx6Emuy+sWAVHjvcz+iWfog7Z2lUr3Dj7HZ5gM1CCg
         Fn1e+a0Tw12VhMwGkbE/a5MoprC4n3X6eFOiRAuYAN/rwy1846vqVNLqEEZyDgmGAIC5
         1o+Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=pYSQ9gfJWZTZGEJx+qC0pyZV1qEmlv4r+fR8DYPNJd0=;
        b=I0CPbNDMx3oyoniuyZwY7sAV67EmfZui4YlXDb+jMb3AZWIYi3Pb1FNg4czOqLfMv2
         Ax8zl3H/1cPhxk7Rq9biq6GzTxGwo8OSFZwWflVq/Vlms3AUdZ2+eEMgZlOYR120DRg1
         DQkZqbH3gh3MQd5v7B5g43Vsnknq+tsCESKm629DZ4RA3bBW52m19ln0wVpf1cDvKe0v
         K+24xutPuvPw94u+dQ8b7cQ6fYZEWYAFOf1iyIgFEm2y304kiXQV4T8vFSp4bD4vSLuK
         SJpRq9CGEm6oZo0nLwAMjP1TuQZic6n/nOnvUBw+IqYTIiE6qnLtmXqREPmK29sqN9rH
         rl2A==
X-Gm-Message-State: AOAM531IQGhP6Qzv2S8gC0f+Y9JV9iXJUiv/PlDQ9KZx3ruaDEQD03bn
	y5l2uCiFkpjdBGhK5g0KZEZEAy6wB0liQfg2J5iNAw==
X-Google-Smtp-Source: ABdhPJyfQJVgpLX25f4hyYYJEd7wQ1QJ4WraHnQrE7mH53OQq57c5t2VJL7vgj+IAsNMaHgcsXKlyW0aGzDqq+P8OnA=
X-Received: by 2002:a05:6512:3d17:: with SMTP id d23mr173727lfv.685.1641828571799;
 Mon, 10 Jan 2022 07:29:31 -0800 (PST)
MIME-Version: 1.0
References: <f4e24379677e4468e65b57e398106b24d39b7d7d.1641574657.git.pgonda@google.com>
 <8ff105d6-0bbe-35cd-22fb-151b6fb076c8@amd.com>
In-Reply-To: <8ff105d6-0bbe-35cd-22fb-151b6fb076c8@amd.com>
From: "Peter Gonda" <pgonda@google.com>
Date: Mon, 10 Jan 2022 08:29:20 -0700
Message-ID: <CAMkAt6pFWs-FOJft9t9VX3g6G1S=H6KDpzjArk2CjshBU-dXpw@mail.gmail.com>
Subject: Re: [PATCH] OvmfPkg/ResetVector: Removing SEV-ES CPUID bit check
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>, Min Xu <min.m.xu@intel.com>, 
	Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen <jordan.l.justen@intel.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Laszlo Ersek <lersek@redhat.com>, 
	Erdem Aktas <erdemaktas@google.com>, Marc Orr <marcorr@google.com>, 
	Brijesh Singh <brijesh.singh@amd.com>, Jim Mattson <jmattson@google.com>
Content-Type: text/plain; charset="UTF-8"

On Fri, Jan 7, 2022 at 3:54 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> On 1/7/22 11:04 AM, Peter Gonda wrote:
> > The SEV-ES bit of Fn800-001F[EAX] - Bit 3 is used for a host to
> > determine support for running SEV-ES guests. It should not be checked by
> > a guest to determine if it is running under SEV-ES. The guest should use
> > the SEV_STATUS MSR Bit 1 to determine if SEV-ES is enabled.
>
> Worth mentioning in the commit message that this check wasn't part of the
> original SEV-ES support (Fixes: a91b700e385e7484ab7286b3ba7ea2efbd59480e
> tag?), so this is really a compatibility thing, and that this makes the
> check consistent with the Linux kernel.

Sure I update the commit message in the V2 with this info and add the
Fixes tag. Do I need a (Fixes:
b461d67639f2deced77e9bb967d014b7cfcd75f8) tag too? Since the Check was
moved between files in that commit?