public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Peter Gonda" <pgonda@google.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>,  Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	 Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Laszlo Ersek <lersek@redhat.com>,
	 Erdem Aktas <erdemaktas@google.com>,
	Marc Orr <marcorr@google.com>,
	 Brijesh Singh <brijesh.singh@amd.com>,
	Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH] OvmfPkg/ResetVector: Removing SEV-ES CPUID bit check
Date: Thu, 13 Jan 2022 09:31:19 -0700	[thread overview]
Message-ID: <CAMkAt6pgr8gSBj2tPi2pERHRgesx5vf68G3Zga6XMWbqFXXoUw@mail.gmail.com> (raw)
In-Reply-To: <3b0c0bff-56f4-d243-5ad0-16dd2505a1b8@amd.com>

On Mon, Jan 10, 2022 at 11:18 AM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> On 1/10/22 9:29 AM, Peter Gonda wrote:
> > On Fri, Jan 7, 2022 at 3:54 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
> >>
> >> On 1/7/22 11:04 AM, Peter Gonda wrote:
> >>> The SEV-ES bit of Fn800-001F[EAX] - Bit 3 is used for a host to
> >>> determine support for running SEV-ES guests. It should not be checked by
> >>> a guest to determine if it is running under SEV-ES. The guest should use
> >>> the SEV_STATUS MSR Bit 1 to determine if SEV-ES is enabled.
> >>
> >> Worth mentioning in the commit message that this check wasn't part of the
> >> original SEV-ES support (Fixes: a91b700e385e7484ab7286b3ba7ea2efbd59480e
> >> tag?), so this is really a compatibility thing, and that this makes the
> >> check consistent with the Linux kernel.
> >
> > Sure I update the commit message in the V2 with this info and add the
> > Fixes tag. Do I need a (Fixes:
> > b461d67639f2deced77e9bb967d014b7cfcd75f8) tag too? Since the Check was
> > moved between files in that commit?
>
> I don't think so, but that's just my opinion.

Thanks. Sent V2 with updates to commit and fixes tag.

>
> Thanks,
> Tom
>
> >

      reply	other threads:[~2022-01-13 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-07 17:04 [PATCH] OvmfPkg/ResetVector: Removing SEV-ES CPUID bit check pgonda
2022-01-07 22:54 ` Lendacky, Thomas
2022-01-10 15:29   ` Peter Gonda
2022-01-10 18:18     ` Lendacky, Thomas
2022-01-13 16:31       ` Peter Gonda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMkAt6pgr8gSBj2tPi2pERHRgesx5vf68G3Zga6XMWbqFXXoUw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox