From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mx.groups.io with SMTP id smtpd.web08.11234.1642091492747023025 for ; Thu, 13 Jan 2022 08:31:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20210112 header.b=Lbf/SREl; spf=pass (domain: google.com, ip: 209.85.167.44, mailfrom: pgonda@google.com) Received: by mail-lf1-f44.google.com with SMTP id p27so9771328lfa.1 for ; Thu, 13 Jan 2022 08:31:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vh0EtjOuZspli11ZmQQBu3Qiqbqdq+ZCI/k44yW44xY=; b=Lbf/SRElE19t2X8xcJ/jTNtmOBDWbYaUaTl7bBuIqH/xn3mm5ZCYQdThbyrOij8itH 8zBPVfSR92fdE0IPbbRPJLTWkrHTcU9huuZ/m5fku1e2pbh3xbD1gqQtPJwCvcD1gOod XQDKgnfpJLk8vKiO/m1kE7Nx2xkIF95H7/qum52fV7poqiLLLYQUNbJao9e2S9xzjIRd ydzjrniesmY9omP4NV2sHEOxlV+V4K84yezoXtKCaY8RIGLccMEUJ3oLTuFGudWagTWs Z4WVp6FqJsT3cbUSfdJyXhi6hiGBVkPqmwavcxGYvulFMHouRQIg46INvMk6wGH6aAjY 1Plw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vh0EtjOuZspli11ZmQQBu3Qiqbqdq+ZCI/k44yW44xY=; b=zxJXOncv6ZIoMNk6doEwZN9wUHKRUe4Nj5r6hgIwg6EfRN3+XpPKLDvDjuhxZhdwle VjaYqzsgSHQkDPrb1r2Fn7iLwwgapnpYhBXqASWbuh9OP3L0ulz58UHEoyGmBNUsg9X8 HjzBBeFyV6IBhVO1nUnphrjHcmC8FEmNWWcrluIOPze61XgZJpkH4WNJ9wFr9q/T0Vyf xjLA9J1xCWWXCHJt6Vj+j6KVk2p/4AfkLRUcBBepiY64jygAQe6oyuyjHrWP3vnMrfZx WmupL1EkhlT6jHI2UNh6nM/oyE9BHYlu83TprIXUF56OGyHk2EgC10JOgfgH77w3TMIt +gIg== X-Gm-Message-State: AOAM533l9Xhz5nDAva3H50Sz6DqgowURP/HBAhoCo2tGIMOb379cIvM0 PtOcAIhiHsNlWGiWyqP3HdrGWGWN9A/AaIMvgXcw0g== X-Google-Smtp-Source: ABdhPJxgEHQDi1rHid1mD/vhYGPzLqnUJioNPYQnoi7b4OmRVIKqNg8+nrL/eAZBg/g+/72LS9kW5buEt/zVqD8Uw0Y= X-Received: by 2002:a05:6512:3a90:: with SMTP id q16mr34092lfu.79.1642091490593; Thu, 13 Jan 2022 08:31:30 -0800 (PST) MIME-Version: 1.0 References: <8ff105d6-0bbe-35cd-22fb-151b6fb076c8@amd.com> <3b0c0bff-56f4-d243-5ad0-16dd2505a1b8@amd.com> In-Reply-To: <3b0c0bff-56f4-d243-5ad0-16dd2505a1b8@amd.com> From: "Peter Gonda" Date: Thu, 13 Jan 2022 09:31:19 -0700 Message-ID: Subject: Re: [PATCH] OvmfPkg/ResetVector: Removing SEV-ES CPUID bit check To: Tom Lendacky Cc: devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Marc Orr , Brijesh Singh , Jim Mattson Content-Type: text/plain; charset="UTF-8" On Mon, Jan 10, 2022 at 11:18 AM Tom Lendacky wrote: > > On 1/10/22 9:29 AM, Peter Gonda wrote: > > On Fri, Jan 7, 2022 at 3:54 PM Tom Lendacky wrote: > >> > >> On 1/7/22 11:04 AM, Peter Gonda wrote: > >>> The SEV-ES bit of Fn800-001F[EAX] - Bit 3 is used for a host to > >>> determine support for running SEV-ES guests. It should not be checked by > >>> a guest to determine if it is running under SEV-ES. The guest should use > >>> the SEV_STATUS MSR Bit 1 to determine if SEV-ES is enabled. > >> > >> Worth mentioning in the commit message that this check wasn't part of the > >> original SEV-ES support (Fixes: a91b700e385e7484ab7286b3ba7ea2efbd59480e > >> tag?), so this is really a compatibility thing, and that this makes the > >> check consistent with the Linux kernel. > > > > Sure I update the commit message in the V2 with this info and add the > > Fixes tag. Do I need a (Fixes: > > b461d67639f2deced77e9bb967d014b7cfcd75f8) tag too? Since the Check was > > moved between files in that commit? > > I don't think so, but that's just my opinion. Thanks. Sent V2 with updates to commit and fixes tag. > > Thanks, > Tom > > >