From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87410941A0B for ; Fri, 12 Jan 2024 18:02:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8/iHHFx9+Amf+kICXkx/aElCazuOqaHAEPSUkqpZ6Nc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705082543; v=1; b=vvBPztWpHBP8goxRmSNm+aI0TJlPF2zVrgs1F8r+yQAi5/a22lTyvoALrD/RDkjStblsUzfR 9Dr61YEfEoq1gwCxJvD38sQgw8SY7ezeaxk8SklUsaE+CfTUrzDCqA6ig4mls5opTWzk5JcaSHC a9x3GLRtwvSbBcU8JOuWF0zY= X-Received: by 127.0.0.2 with SMTP id AJXKYY7687511x5X7ynOpHCI; Fri, 12 Jan 2024 10:02:23 -0800 X-Received: from us-smtp-delivery-137.mimecast.com (us-smtp-delivery-137.mimecast.com [170.10.129.137]) by mx.groups.io with SMTP id smtpd.web10.14710.1705082542473532968 for ; Fri, 12 Jan 2024 10:02:22 -0800 X-Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-Yf4p2qU1Muima2uDHa8J4A-1; Fri, 12 Jan 2024 13:02:14 -0500 X-MC-Unique: Yf4p2qU1Muima2uDHa8J4A-1 X-Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3369382a524so4460566f8f.1 for ; Fri, 12 Jan 2024 10:02:14 -0800 (PST) X-Gm-Message-State: 5f51GcmbZtO2IG396MXrBRGPx7686176AA= X-Received: by 2002:adf:f20d:0:b0:336:6e63:486d with SMTP id p13-20020adff20d000000b003366e63486dmr1111270wro.86.1705082532754; Fri, 12 Jan 2024 10:02:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/rrcT7yYK5A/4aODUfTcKXlg9Z1EHwaSBTGFHu5hVsBE99OhorMryF9qpvQ1+2ncvlJc5WU8YCjzpDJBrYiQ= X-Received: by 2002:a2e:869a:0:b0:2cc:bdbd:f31b with SMTP id l26-20020a2e869a000000b002ccbdbdf31bmr1119445lji.30.1705082190329; Fri, 12 Jan 2024 09:56:30 -0800 (PST) MIME-Version: 1.0 References: <02d4a4fa4b0fcc9d0b356ea740d1abd82caba9a4.1704998169.git.tbarrett@crusoeenergy.com> In-Reply-To: From: "Thomas Barrett" Date: Fri, 12 Jan 2024 09:56:19 -0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: Update PlatformAddressWidthInitialization for CloudHv To: Gerd Hoffmann Cc: devel@edk2.groups.io, Anatol Belski , Ard Biesheuvel , Jianyong Wu , Jiewen Yao , Laszlo Ersek , Rob Bradford X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: crusoeenergy.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tbarrett@crusoeenergy.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: multipart/alternative; boundary="0000000000004495d9060ec362bd" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=vvBPztWp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=crusoeenergy.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --0000000000004495d9060ec362bd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks Gerd, I'll pull that change into a separate commit and resubmit. Best, Thomas On Fri, Jan 12, 2024 at 3:47=E2=80=AFAM Gerd Hoffmann w= rote: > Hi, > > > diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc > b/OvmfPkg/CloudHv/CloudHvX64.dsc > > index af594959a9..b522fa1059 100644 > > --- a/OvmfPkg/CloudHv/CloudHvX64.dsc > > +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc > > @@ -566,6 +566,8 @@ > > # Point to the MdeModulePkg/Application/UiApp/UiApp.inf > > gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, > 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, > 0x23, 0x31 } > > > > + gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE > > + > > This is not mentioned in the commit message. > > Also it should go into a separate patch (in case this is an intentional > change, which I suspect is the case). > > Otherwise the series looks good to me. > > take care, > Gerd > > Disclaimer The information contained in this communication from the sender is confiden= tial. It is intended solely for use by the recipient and others authorized = to receive it. If you are not the recipient, you are hereby notified that a= ny disclosure, copying, distribution or taking action in relation of the co= ntents of this information is strictly prohibited and may be unlawful. This email has been scanned for viruses and malware, and may have been auto= matically archived by Mimecast, a leader in email security and cyber resili= ence. Mimecast integrates email defenses with brand protection, security aw= areness training, web security, compliance and other essential capabilities= . Mimecast helps protect large and small organizations from malicious activ= ity, human error and technology failure; and to lead the movement toward bu= ilding a more resilient world. To find out more, visit our website. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113752): https://edk2.groups.io/g/devel/message/113752 Mute This Topic: https://groups.io/mt/103668740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --0000000000004495d9060ec362bd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Gerd,

I'll pull = that change into a separate commit and resubmit.

Best,
Thomas
=

= On Fri, Jan 12, 2024 at 3:47=E2=80=AFAM Gerd Hoffmann <kraxel@redhat.com> wrote:
=C2=A0 Hi,

> diff --git a/OvmfPkg/CloudHv/CloudHvX64.dsc b/OvmfPkg/CloudHv/CloudHvX= 64.dsc
> index af594959a9..b522fa1059 100644
> --- a/OvmfPkg/CloudHv/CloudHvX64.dsc
> +++ b/OvmfPkg/CloudHv/CloudHvX64.dsc
> @@ -566,6 +566,8 @@
>=C2=A0 =C2=A0 # Point to the MdeModulePkg/Application/UiApp/UiApp.inf >=C2=A0 =C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0= x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4= , 0x66, 0x23, 0x31 }
>=C2=A0
> +=C2=A0 gEfiMdeModulePkgTokenSpaceGuid.PcdUse1GPageTable|TRUE
> +

This is not mentioned in the commit message.

Also it should go into a separate patch (in case this is an intentional
change, which I suspect is the case).

Otherwise the series looks good to me.

take care,
=C2=A0 Gerd



<= b>Disclaimer

The information contained in this communication from the sender i= s confidential. It is intended solely for use by the recipient and others a= uthorized to receive it. If you are not the recipient, you are hereby notif= ied that any disclosure, copying, distribution or taking action in relation= of the contents of this information is strictly prohibited and may be unla= wful.

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113752) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--0000000000004495d9060ec362bd--