From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.160.195; helo=mail-qt1-f195.google.com; envelope-from=mlureau@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BF5852194D3AE for ; Mon, 11 Feb 2019 03:25:14 -0800 (PST) Received: by mail-qt1-f195.google.com with SMTP id b8so11621807qtr.9 for ; Mon, 11 Feb 2019 03:25:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Sr4STAFt8Xhw2ktpEQ1jdmcXWTR1xQK7NhXXdwGOvH4=; b=qRrbn35o4M/5fx7eJ/WREZluhXd7j800pmqbjFdrKG1QnCNvMj/GO0QtEPFKYEe/sJ K97ylsUYqc3W0hvfUzKQHoh4IYNSg+Czwbfrtmp30v+MZJorQGuFn9s/2zIhAWa8Ogyl yyHnniAZTNU/ASAhF6pgALdFJWgs9XRuhQLF0i3LFa3jl7O9c8TTxzV8nC00zihrcrEU RRGZs+ondv76LbvM7bWq6viLo/LRPlIqMSV4KS6JJ7VhrUDu4q6VNI5217PxdWG01cGt pQIbMwK77ct0s9gk8NEifPjOc2bHwZXigv8HTgp5YVOEQEJ1rNQ4va85NLK5ktW+7dAd TZNQ== X-Gm-Message-State: AHQUAuZqdS6OcnqxWMtUYKm+aTrIghsr45hAMeu8IzLCDdtTbXEAPlWh 6dTYOAlg3lHs/Myq3jDvKjNjSioYYq2Fi1r3LwSOXQ== X-Google-Smtp-Source: AHgI3IZEHb/2Rg0hBEAD9YszPfSWYbzUDrQq5HpLeqtZKKHtkQgaVNWSlRfVKzgq6oYOPpUVtfrDQw6K4A7x7/V1tg4= X-Received: by 2002:ac8:4882:: with SMTP id i2mr26620147qtq.225.1549884313619; Mon, 11 Feb 2019 03:25:13 -0800 (PST) MIME-Version: 1.0 References: <20190125213029.1096138-1-stefanb@linux.ibm.com> In-Reply-To: <20190125213029.1096138-1-stefanb@linux.ibm.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Mon, 11 Feb 2019 12:25:02 +0100 Message-ID: To: Stefan Berger Cc: Laszlo Ersek , edk2-devel@lists.01.org, chao.b.zhang@intel.com, jiewen.yao@intel.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org, Anthony PERARD , julien.grall@linaro.org Subject: Re: [Patch v2] OvmfPkg: Add TCG2 Configuration menu to the Device Manager menu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 11:25:15 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, Jan 25, 2019 at 10:30 PM Stefan Berger wrot= e: > > This patch adds the TCG2 Configuration menu to the Device Manager > menu. We can apparently reuse the sample Tcg2ConfigDxe from > SecurityPkg/Tcg/Tcg2Config without obvious adverse effects. The > added TCG2 Configuration menu now shows details about the attached > TPM 2.0 and lets one for example configure the active PCR banks > or issue commands, among other things. > > The code is added to Ovmf by building with -DTPM2_ENABLE and > -DTPM2_CONFIG_ENABLE. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Stefan Berger patch looks good (I have done minimal testing, though). Reviewed-by: Marc-Andr=C3=A9 Lureau > --- > OvmfPkg/OvmfPkgIa32.dsc | 4 ++++ > OvmfPkg/OvmfPkgIa32.fdf | 3 +++ > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ > OvmfPkg/OvmfPkgX64.dsc | 4 ++++ > OvmfPkg/OvmfPkgX64.fdf | 3 +++ > 6 files changed, 21 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index aee19b75d7..2b642ab5dc 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -40,6 +40,7 @@ > DEFINE SMM_REQUIRE =3D FALSE > DEFINE TLS_ENABLE =3D FALSE > DEFINE TPM2_ENABLE =3D FALSE > + DEFINE TPM2_CONFIG_ENABLE =3D FALSE > > # > # Flash size selection. Setting FD_SIZE_IN_KB on the command line dire= ctly to > @@ -632,6 +633,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha3= 84.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha5= 12.inf > } > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > # > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index e013099136..4999403ad7 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -381,6 +381,9 @@ INF MdeModulePkg/Universal/Variable/RuntimeDxe/Varia= bleRuntimeDxe.inf > > !if $(TPM2_ENABLE) =3D=3D TRUE > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > ########################################################################= ######## > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 90cbd8e341..14a5c1bb29 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -40,6 +40,7 @@ > DEFINE SMM_REQUIRE =3D FALSE > DEFINE TLS_ENABLE =3D FALSE > DEFINE TPM2_ENABLE =3D FALSE > + DEFINE TPM2_CONFIG_ENABLE =3D FALSE > > # > # Flash size selection. Setting FD_SIZE_IN_KB on the command line dire= ctly to > @@ -640,6 +641,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha3= 84.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha5= 12.inf > } > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > [Components.X64] > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index afaa334384..d0cc107928 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -388,6 +388,9 @@ INF MdeModulePkg/Universal/Variable/RuntimeDxe/Varia= bleRuntimeDxe.inf > > !if $(TPM2_ENABLE) =3D=3D TRUE > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > ########################################################################= ######## > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 83d16eb00b..aa7197f533 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -40,6 +40,7 @@ > DEFINE SMM_REQUIRE =3D FALSE > DEFINE TLS_ENABLE =3D FALSE > DEFINE TPM2_ENABLE =3D FALSE > + DEFINE TPM2_CONFIG_ENABLE =3D FALSE > > # > # Flash size selection. Setting FD_SIZE_IN_KB on the command line dire= ctly to > @@ -639,6 +640,9 @@ > NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha3= 84.inf > NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha5= 12.inf > } > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > + SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > # > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index afaa334384..d0cc107928 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -388,6 +388,9 @@ INF MdeModulePkg/Universal/Variable/RuntimeDxe/Varia= bleRuntimeDxe.inf > > !if $(TPM2_ENABLE) =3D=3D TRUE > INF SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +!if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE > +INF SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf > +!endif > !endif > > ########################################################################= ######## > -- > 2.20.1 >