From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.166.65; helo=mail-io1-f65.google.com; envelope-from=mlureau@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7B7D211616A2 for ; Tue, 2 Oct 2018 05:30:23 -0700 (PDT) Received: by mail-io1-f65.google.com with SMTP id n18-v6so1886265ioa.9 for ; Tue, 02 Oct 2018 05:30:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fnmLzyLJVqOD5CUFDyxqYFdF6w2q9+VgGFrsSL2QFWY=; b=W0iyKY6B+Cl7L9QOvaSnWLIWtKd+EHuXBvgjlZRHAkDh21WN7eBKiSTFKWvCSlNapl aoFdcO7RWv2fuXfuxwstFhJLkW7TsaafrmX6/NYtWhDVtAlac1LJJAoZG9BLTudBfYe3 AH157Iq1dFMOgqetCbhp2oj2MpZ7yLKowsmPeqGrE5xC7jiPNzwCpIU7/tOTHdjBjfhb NhqoDOEtrVssvOe77NVPJHbnDwFKLviy3ALxgcR0/qvXnv7esextruXBMLOl+zbDznRJ 87oNmPMlW+OzFcEQGyskPH9Tk0ib2mcsfINrwf29Dus8MnUl6CDGwH03Fscf90zEnTkI mmCg== X-Gm-Message-State: ABuFfohRkSg2oUkK5iQ5LkwFu1xlZ28BsZ8jVt4lC0etWytdStRiV7O+ avjMSlbaSVu0D9MOYR6E53KWFRmLddDLD9YfjKYvBA== X-Google-Smtp-Source: ACcGV62B5naw6r8qXag3q51UJ0zxWjNjaHCt0w/IVRCC9rlEJxdSpbhMrIwx+rJ/FOh/3lAXFF6Chw7AJgJEJric6VM= X-Received: by 2002:a5e:c643:: with SMTP id s3-v6mr6684603ioo.108.1538483423033; Tue, 02 Oct 2018 05:30:23 -0700 (PDT) MIME-Version: 1.0 References: <20181002083602.581-1-marcandre.lureau@redhat.com> <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com> <100c7116-34ba-f5f9-8b79-9aa201b31506@redhat.com> In-Reply-To: <100c7116-34ba-f5f9-8b79-9aa201b31506@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 2 Oct 2018 16:30:11 +0400 Message-ID: To: Laszlo Ersek Cc: marcandre , michael.d.kinney@intel.com, jordan.l.justen@intel.com, edk2-devel@lists.01.org, anthony.perard@citrix.com Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 12:30:24 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Oct 2, 2018 at 4:19 PM Laszlo Ersek wrote: > > On 10/02/18 14:10, Marc-Andr=C3=A9 Lureau wrote: > > Hi > > > > On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > >> > >> On 10/02/18 13:37, Marc-Andr=C3=A9 Lureau wrote: > >>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote= : > >> > >>>> Please fix your git settings for your local edk2 clone. Your patch > >>>> contains context lines with LF (not CRLF) line endings, and that's n= ot > >>>> correct for edk2. > >>> > >>> Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1= ? > >> > >> Yes, it should be caught by "PatchCheck.py". The "force_crlf" member i= s > >> set iff the pathname doesn't end in ".sh", and then the > >> check_added_line() method verifies CRLF. > >> > >> I don't know why it doesn't work in practice. Can you submit a TianoCo= re > >> BZ about it? > >> > >> (Your patch uses LF on both context lines and new (added) lines, so th= e > >> current script logic should complain, yes.) > >> > >>> Hmm, this is weird, the original patch has crlf (see attach file). > >>> send-email or the mail server somehow stripped it? > >>> > >>> I use your recommend git settings, I don't know what I am missing her= e. > >> > >> You are right, the attachment looks fine. > >> > >> ... Can you resend the v2 patch (just to me directly, off-list) with > >> > >> --transfer-encoding=3Dquoted-printable > >> > >> ? My guess is that the base64 encoding in git-send-email includes an > >> automatic CR stripping phase. > > > > Hmm, actually it's my emacs settings that stripped the crlf from the pa= tch. > > > > I edited the patch manually to add some notes... > > Haha, serves you right then ;) > > I suggest never editing patches after formatting them. In the first > place, there's no reason to: you can add, edit and remove notes on > commits with "git notes" (without changing the commit hashes / git > history). And "git-format-patch" takes a "--notes" option. (Same for > "git show".) > > I do mention git-notes in the "unkempt guide": > > git config notes.rewriteRef refs/notes/commits > > git format-patch \ > --notes \ > > git notes edit COMMIT_HASH_OF_THAT_PATCH > Yes, somehow git-notes doesn't fit with my idea of how patch mail notes for v2/v3... should look: Notes: v3: - foo v2: - blablah If there is a way to avoid the "Notes:" quoting, that would be nice.