From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: marcandre <marcandre.lureau@gmail.com>,
michael.d.kinney@intel.com, jordan.l.justen@intel.com,
edk2-devel@lists.01.org, anthony.perard@citrix.com
Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches
Date: Tue, 2 Oct 2018 16:10:51 +0400 [thread overview]
Message-ID: <CAMxuvazXPX7K9t=DjDwFkTXwQsH1TLnkrn4rq8q852+tfp2TYw@mail.gmail.com> (raw)
In-Reply-To: <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com>
Hi
On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 10/02/18 13:37, Marc-André Lureau wrote:
> > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek <lersek@redhat.com> wrote:
>
> >> Please fix your git settings for your local edk2 clone. Your patch
> >> contains context lines with LF (not CRLF) line endings, and that's not
> >> correct for edk2.
> >
> > Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1 ?
>
> Yes, it should be caught by "PatchCheck.py". The "force_crlf" member is
> set iff the pathname doesn't end in ".sh", and then the
> check_added_line() method verifies CRLF.
>
> I don't know why it doesn't work in practice. Can you submit a TianoCore
> BZ about it?
>
> (Your patch uses LF on both context lines and new (added) lines, so the
> current script logic should complain, yes.)
>
> > Hmm, this is weird, the original patch has crlf (see attach file).
> > send-email or the mail server somehow stripped it?
> >
> > I use your recommend git settings, I don't know what I am missing here.
>
> You are right, the attachment looks fine.
>
> ... Can you resend the v2 patch (just to me directly, off-list) with
>
> --transfer-encoding=quoted-printable
>
> ? My guess is that the base64 encoding in git-send-email includes an
> automatic CR stripping phase.
Hmm, actually it's my emacs settings that stripped the crlf from the patch.
I edited the patch manually to add some notes...
>
> If indeed bas64 is the culprit, I'll update the wiki article to specify
> quoted-printable.
>
> Thanks
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-02 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 8:36 [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches marcandre.lureau
2018-10-02 10:55 ` Laszlo Ersek
2018-10-02 11:37 ` Marc-André Lureau
2018-10-02 11:55 ` Laszlo Ersek
2018-10-02 11:57 ` Laszlo Ersek
2018-10-02 12:10 ` Marc-André Lureau [this message]
2018-10-02 12:19 ` Laszlo Ersek
2018-10-02 12:30 ` Marc-André Lureau
2018-10-02 11:16 ` Laszlo Ersek
2018-10-02 11:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMxuvazXPX7K9t=DjDwFkTXwQsH1TLnkrn4rq8q852+tfp2TYw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox