From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.166.47; helo=mail-io1-f47.google.com; envelope-from=mlureau@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F0FD12116123E for ; Tue, 2 Oct 2018 05:11:03 -0700 (PDT) Received: by mail-io1-f47.google.com with SMTP id v14-v6so1859728iob.4 for ; Tue, 02 Oct 2018 05:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k3KngFUpHn/f0fe9ipHQ+orvhe8sxx2qK5spuS514bQ=; b=UQcQ22J8wKEtgO21prfkoD9mkItK0i6hLriwm425M8WblVYR4EeemLdySbD9bURe2g VCrCpcLMkFRvB9/ADZRUuf93f7rdizaho4e71p5K2jHTKfjk7s9Tji4px0dXN/iGnM2x vj76ZDII0o+o4BPeFkXDNsBHLaKaipAhUtIPhVxz+rI8HSnJcepd8oQvbUaLKVlnKi3N ku0DH7yj7NMCEreLezTNSthskWS6ZMIHcZdBQdc6wy7xMYo48QIW2f2kminN5lwiC+J/ cMQMUw9RkuEoJQlA1lvxuw+HqVuzqTtXtGP0l2XhhdDDi/4vpNu2efLA1NJAVvc3tZic PLNg== X-Gm-Message-State: ABuFfojLToDor9yT0Ga6FDrkde3e/ZaTUjb+8N6jKOhRmiNo4XXInJwp h6zEG18Ac2zFgOJu0lO1P0p9cpZtjYRG7dMC2ErfQj4d X-Google-Smtp-Source: ACcGV62WtqCprjqtFTyzZfIMD5XSHauFNNDM/kGLqznBVTwOHRtTO9yIyepZItIbW88Xt6/ac+l0qOBTs+SaQY4pVEs= X-Received: by 2002:a5e:c643:: with SMTP id s3-v6mr6628626ioo.108.1538482262933; Tue, 02 Oct 2018 05:11:02 -0700 (PDT) MIME-Version: 1.0 References: <20181002083602.581-1-marcandre.lureau@redhat.com> <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com> In-Reply-To: <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com> From: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Date: Tue, 2 Oct 2018 16:10:51 +0400 Message-ID: To: Laszlo Ersek Cc: marcandre , michael.d.kinney@intel.com, jordan.l.justen@intel.com, edk2-devel@lists.01.org, anthony.perard@citrix.com Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 12:11:05 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Tue, Oct 2, 2018 at 3:55 PM Laszlo Ersek wrote: > > On 10/02/18 13:37, Marc-Andr=C3=A9 Lureau wrote: > > On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek wrote: > > >> Please fix your git settings for your local edk2 clone. Your patch > >> contains context lines with LF (not CRLF) line endings, and that's not > >> correct for edk2. > > > > Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1 ? > > Yes, it should be caught by "PatchCheck.py". The "force_crlf" member is > set iff the pathname doesn't end in ".sh", and then the > check_added_line() method verifies CRLF. > > I don't know why it doesn't work in practice. Can you submit a TianoCore > BZ about it? > > (Your patch uses LF on both context lines and new (added) lines, so the > current script logic should complain, yes.) > > > Hmm, this is weird, the original patch has crlf (see attach file). > > send-email or the mail server somehow stripped it? > > > > I use your recommend git settings, I don't know what I am missing here. > > You are right, the attachment looks fine. > > ... Can you resend the v2 patch (just to me directly, off-list) with > > --transfer-encoding=3Dquoted-printable > > ? My guess is that the base64 encoding in git-send-email includes an > automatic CR stripping phase. Hmm, actually it's my emacs settings that stripped the crlf from the patch. I edited the patch manually to add some notes... > > If indeed bas64 is the culprit, I'll update the wiki article to specify > quoted-printable. > > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel