From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22a; helo=mail-it0-x22a.google.com; envelope-from=pmdyounaskhan786@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B757C2118B780 for ; Wed, 6 Jun 2018 01:21:54 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id 76-v6so6960018itx.4 for ; Wed, 06 Jun 2018 01:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3Y1EN2fnq45ZHrrWQ2qeJjwYv/NeedYVsSQ2tvNWnsc=; b=aUqTKMFliTxvdAJyGkDiZN3rfQbxgqfYkP8UQnTmpnAJdEUHxutsPP/uFSHKznThla NjoGzVhB4UGlw8wDjnXu6MsiLN3AaLrDbkpgdnJKCJsm77Pe9N+Zg9J4DFRRcnKFG3y/ 1ulsQfB5gd6n1gSO8VK9T+JVPBMm4j6VpEVYmaCspFCSuiSFFaDHsiQt70pQ0klVidT1 062bVR6Yx480j0ypooAVojFj1Cbm2p2KM/ZpSg2/BibIGmcTmG8oZ+PGeQPCJqr3FiaC M0tKX9dJuI9WTiepzYJMIF2FfHMFDL9M9pV6FjAG8rIsxx20pvNHGkL5286TUtq2p3DB R8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3Y1EN2fnq45ZHrrWQ2qeJjwYv/NeedYVsSQ2tvNWnsc=; b=qr1EgIcTogECw0ucG5SvwVPjgr6X1VpjC/Dswj5V445qyQagDn/V3UlztmPklL/UJZ wmrdJdfLbbaSYU62HV0x7js5GHSUtidNI2RbSLSkQ83GiU0ttDlsoUXZcOHXQrLjEORl D4oqvOqtYOQy68c1VYMXehEJfH71VWbedOuPGCoSO2JxOch/erXfrB0xAeGdYA3omGzx 6BKD0BoSBDGMyZNJrcSrcDf4/9YoEUW5KkxLeEJTLhPGM6qucFJIxlXp400tE8Z8ZSOq GfzIoFzsY6/7coOly8KQ0Nrt4b6sJFztkUFGosHkLkD3oQEjnEjcoZUnkjUGewIWZGyS dwTw== X-Gm-Message-State: APt69E3kEkEaYfRj9PSnts8Nx5AwcOjLsF94B7PM0+KVZstJJHoVrqLF TzoMjOYPDELTp6HaIPpTfB8DGsicvDmGepXSgQM6rA== X-Google-Smtp-Source: ADUXVKJmQu6Ym9A0MA9PQ+DfCsBPW8nrNPBFp6dH4qL5Va7HPvQZL9qgVxZOvVdpdmHq/4cLucj8qTwh2v3FcHC+HJ4= X-Received: by 2002:a24:5882:: with SMTP id f124-v6mr1476409itb.94.1528273313489; Wed, 06 Jun 2018 01:21:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:1b51:0:0:0:0:0 with HTTP; Wed, 6 Jun 2018 01:21:52 -0700 (PDT) From: Mohammad Younas Khan Pathan Date: Wed, 6 Jun 2018 13:51:52 +0530 Message-ID: To: edk2-devel@lists.01.org X-Mailman-Approved-At: Wed, 06 Jun 2018 06:33:36 -0700 X-Content-Filtered-By: Mailman/MimeDel 2.1.26 Subject: Bug 868 - Need to add several functions related to date and time in BaseLib. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2018 08:21:55 -0000 Content-Type: text/plain; charset="UTF-8" Hi All, If there is any generic library function, then we do not need to have 2 or more definitions for same function like IsLeapYear(). Searching for 'isleapyear' By Mask: *.c ArmPlatformPkg\Library\PL031RealTimeClockLib\PL031RealTimeClockLib.c(199) :IsLeapYear ( ArmPlatformPkg\Library\PL031RealTimeClockLib\PL031RealTimeClockLib.c(227) : (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28)) EmbeddedPkg\Library\HalRuntimeServicesExampleLib\Rtc.c(134) :IsLeapYear ( EmbeddedPkg\Library\HalRuntimeServicesExampleLib\Rtc.c(163) : (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28)) EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(33) :IsLeapYear ( EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(279) : (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28)) EmulatorPkg\RealTimeClockRuntimeDxe\RealTimeClock.c(288) :IsLeapYear ( Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(37) :IsLeapYear ( Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(356) : (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28)) Nt32Pkg\RealTimeClockRuntimeDxe\RealTimeClock.c(365) :IsLeapYear ( PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1021) : (Time->Month == 2 && (!IsLeapYear (Time) && Time->Day > 28)) PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1038) :IsLeapYear ( PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcRtc.c(1178) : if ((From->Month == 2) && !IsLeapYear(From)) { Similarly for other functions, can we have the common functions used for time in BaseLib or some common library? Can we move them to BaseLib or any other common library? Bug link: https://bugzilla.tianocore.org/show_bug.cgi?id=868 Please provide your suggestions on the same. Thank you, Younas khan.