From: Michael Zimmermann <sigmaepsilon92@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Subject: Re: correct way to reserve memory from PrePi?
Date: Wed, 14 Dec 2016 16:13:45 +0100 [thread overview]
Message-ID: <CAN9vWD+LRiTbGtkpyzuSkQJtHLZMNmOtqs5b5OLnu_GUTtwNdw@mail.gmail.com> (raw)
In-Reply-To: <CAKv+Gu_gGRiKgk7L__zG5KYbyhRRE0kqjOE3R85HGL2q85EL3A@mail.gmail.com>
As far as I know the proper way is to create resource descriptors
using BuildResourceDescriptorHob and then allocate reserved areas
using BuildMemoryAllocationHob. This way I don't have any overlapping
descriptors - I just allocated some memory very early.
I ran many tests and it looks like all calls to
BuildMemoryAllocationHob get ignored if my dram hobs look like this:
0x00000000 - 0x40000000
If I split this range into two Hob's like this everything seems to
work just fine:
0x00000000 - 0x20000000
0x20000000 - 0x20000000
I took a look at other platforms like Juno and they add big dram Hob's
(2GB and 6GB) too so why is this a problem?
Thanks
Michael
On Wed, Dec 14, 2016 at 11:21 AM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> On 14 December 2016 at 10:02, Michael Zimmermann
> <sigmaepsilon92@gmail.com> wrote:
>> I tried both BuildResourceDescriptorHob and BuildMemoryAllocationHob
>> but apparently they don't have any effect.
>> When I look at the output of the shell's memmap command there aren't
>> any reserved/unavailable pages.
>>
>> Furthermore, when using AllocatePages with one of the physical
>> addresses which I've reserved it succeeds which means that it's not
>> just a problem of how the memmap command works.
>>
>> Am I doing something wrong or is this a bug?
>>
>
> I think you need to ensure that they don't overlap existing resource
> descriptors: if you declare a region as reserved, you should not
> declare it as memory first
next prev parent reply other threads:[~2016-12-14 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 10:02 correct way to reserve memory from PrePi? Michael Zimmermann
2016-12-14 10:21 ` Ard Biesheuvel
2016-12-14 15:13 ` Michael Zimmermann [this message]
2016-12-14 17:57 ` Michael Zimmermann
2016-12-15 4:55 ` Gao, Liming
2016-12-15 5:02 ` Michael Zimmermann
2016-12-15 5:12 ` Gao, Liming
2016-12-15 5:27 ` Michael Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAN9vWD+LRiTbGtkpyzuSkQJtHLZMNmOtqs5b5OLnu_GUTtwNdw@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox