From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 54AEB1A1E28 for ; Sun, 4 Sep 2016 09:10:07 -0700 (PDT) Received: by mail-wm0-x243.google.com with SMTP id w207so9816730wmw.0 for ; Sun, 04 Sep 2016 09:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UX5OIdk/Vemx/MeiEKCUIaMVWYUKDgFAY2uB9DlNBSk=; b=v7Esj4+Ih87QXvRq5MfgPdRN/30WIh+os/uN0r6lCnDYs6cB33PqgvVsRE1mkc2PP+ i+g669jFwJzGVczu1fJkrj+eUvKut2mxrColpUcgt7/y7ejiK/1Egjyn3uS0/ZqLIQsX mCYfkcOrZDpYA1yyhpHHDPOStXw5JNo7wLF0aIkCmnHPwxZrZP/S/UWwehytWvIHP3TM onpMPh37c46OltAdkMN/2Vsjg92LJADLNjtoY3XKv02QOBewac62PpPY/seteeRWiQrz t+7x9Lw7uZbRQ/JHNblPDmiJG6e0kyG5IoYBIflbDhtghXNLqYUgpfNU0vKoFVJEdULV I7sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UX5OIdk/Vemx/MeiEKCUIaMVWYUKDgFAY2uB9DlNBSk=; b=R8ol5RDljqBJ9M1w0rhORD1evIf3IKWpbmVasT//6LH6dCKXv+wuhQXJGhU71mv54J RN/xWFoC7mgppjP0Xj7icEuwdf3R3lrMOu8F816WhsKAbrn1LAK67p7Mul+yeSMb/m3c b7HuoDCQVd7YEtWjmL7sYc/x5csmT+0BnvehITkrBfeXZXPUjiTgjcNG6qcTpf2GI5ga 8bYAY3rs/FTwGE+hI3i3Mz656Xjf6V5zun1YoBJhaSN0Oe9AgbXTSNkBXUcEqa6xUUTL t64O1I4sUiNXgdpco9+Akg7SjkqJZHq3qkGst/0MrpwNeN6nVoIt8czge7ZLbyMpqSW8 2wSw== X-Gm-Message-State: AE9vXwMZxgfjAPAzX9L6HwQ2XAnXngqJ6OiwzRTyJPiJVWy2La7fygxQ9Y+M31qjEu08wVeQ7sYTRvZvtsADWQ== X-Received: by 10.194.39.232 with SMTP id s8mr337002wjk.142.1473005405882; Sun, 04 Sep 2016 09:10:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.0.204 with HTTP; Sun, 4 Sep 2016 09:10:05 -0700 (PDT) In-Reply-To: References: <20160904154135.4324-1-leif.lindholm@linaro.org> From: Michael Zimmermann Date: Sun, 4 Sep 2016 18:10:05 +0200 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , edk2-devel-01 , Liming Gao X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [RFC] edksetup.sh: detect updated BaseTools templates X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Sep 2016 16:10:07 -0000 Content-Type: text/plain; charset=UTF-8 > Could we instead make the files under Conf/ symlinks to the templates? Sounds like a good idea in general but what about windows? afaik only NTFS has support for them. On Sun, Sep 4, 2016 at 5:55 PM, Ard Biesheuvel wrote: > On 4 September 2016 at 16:41, Leif Lindholm > wrote: > > Make edksetup.sh automatically update the cached configuration under > > Conf/ when the templates under BaseTools/Conf/ change. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Leif Lindholm > > --- > > > > We keep getting questions from people starting out with EDK2 development, > > whenever certain options in the BaseTools template configs change and > > their builds break. I don't know if this naive sledgehammer approach is > > acceptable, but I'd like to make life easier for people. > > > > Could we instead make the files under Conf/ symlinks to the templates? > That way, people can still keep local changes in these files, which is > presumably the reason for this arrangement, while the 'naive' user > [with no interest in keeping local changes] does not have to deal with > this. > > > > edksetup.sh | 33 +++++++++++++++++++++++++++++++-- > > 1 file changed, 31 insertions(+), 2 deletions(-) > > > > diff --git a/edksetup.sh b/edksetup.sh > > index 57368b5..77f0d43 100755 > > --- a/edksetup.sh > > +++ b/edksetup.sh > > @@ -33,12 +33,41 @@ function HelpMsg() > > return 1 > > } > > > > +function ClearCache() > > +{ > > + CONF_FILES="build_rule target tools_def" > > + if [ -z "$EDK_TOOLS_PATH" ] > > + then > > + TEMPLATE_PATH=./BaseTools/Conf/ > > + else > > + TEMPLATE_PATH="$EDK_TOOLS_PATH/Conf/" > > + fi > > + > > + DELETED_FILES=0 > > + for File in $CONF_FILES > > + do > > + TEMPLATE_FILE="$TEMPLATE_PATH/$File.template" > > + CACHE_FILE="Conf/$File.txt" > > + if [ "$TEMPLATE_FILE" -nt "$CACHE_FILE" ] > > + then > > + echo "Removing outdated '$CACHE_FILE'." > > + rm "$CACHE_FILE" > > + DELETED_FILES=$(($DELETED_FILES + 1)) > > + fi > > + done > > + > > + unset TEMPLATE_PATH TEMPLATE_FILE CACHE_FILE > > + return $DELETED_FILES > > +} > > + > > function SetWorkspace() > > { > > # > > - # If WORKSPACE is already set, then we can return right now > > + # Check for updated BaseTools templates. If none, and > > + # WORKSPACE is already set, then we can return right now > > # > > - if [ -n "$WORKSPACE" ] > > + ClearCache > > + if [ $? -ne 0 -a -n "$WORKSPACE" ] > > then > > return 0 > > fi > > -- > > 2.9.3 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >