public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Zimmermann <sigmaepsilon92@gmail.com>
To: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] ArmPlatformPkg: MemoryInitPei: fix wrong check for system memory
Date: Fri, 13 Jan 2017 05:47:32 +0100	[thread overview]
Message-ID: <CAN9vWD+n+vn+KNhEdmY_G6NTieKPEPLuqkZAFpV6VUcC45MLxA@mail.gmail.com> (raw)
In-Reply-To: <CAN9vWDKOy1eSSAwmppGXt2QhCMx4258i12nHSwMSsjoU9sfOLw@mail.gmail.com>

sry, but I forgot to CC the maintainers again so doing this with this
self-reply.

On Thu, Jan 12, 2017 at 4:46 PM, Michael Zimmermann <
sigmaepsilon92@gmail.com> wrote:

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
> ---
>  ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
> b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
> index 2feb11f21d..8f6781212e 100644
> --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
> +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c
> @@ -103,7 +103,7 @@ MemoryPeim (
>    while ((NextHob.Raw = GetNextHob (EFI_HOB_TYPE_RESOURCE_DESCRIPTOR,
> NextHob.Raw)) != NULL) {
>      if ((NextHob.ResourceDescriptor->ResourceType ==
> EFI_RESOURCE_SYSTEM_MEMORY) &&
>          (PcdGet64 (PcdSystemMemoryBase) >= NextHob.ResourceDescriptor->PhysicalStart)
> &&
> -        (NextHob.ResourceDescriptor->PhysicalStart +
> NextHob.ResourceDescriptor->ResourceLength <= PcdGet64
> (PcdSystemMemoryBase) + PcdGet64 (PcdSystemMemorySize)))
> +        (NextHob.ResourceDescriptor->PhysicalStart +
> NextHob.ResourceDescriptor->ResourceLength >= PcdGet64
> (PcdSystemMemoryBase) + PcdGet64 (PcdSystemMemorySize)))
>      {
>        Found = TRUE;
>        break;
> --
> 2.11.0
>
>


  reply	other threads:[~2017-01-13  4:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-12 15:46 [PATCH] ArmPlatformPkg: MemoryInitPei: fix wrong check for system memory Michael Zimmermann
2017-01-13  4:47 ` Michael Zimmermann [this message]
2017-01-16 18:09 ` Leif Lindholm
2017-01-16 18:43   ` Michael Zimmermann
2017-01-16 18:44     ` Michael Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN9vWD+n+vn+KNhEdmY_G6NTieKPEPLuqkZAFpV6VUcC45MLxA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox