From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c0f::22f; helo=mail-ot0-x22f.google.com; envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-ot0-x22f.google.com (mail-ot0-x22f.google.com [IPv6:2607:f8b0:4003:c0f::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C1B32035A7AC for ; Mon, 13 Nov 2017 11:53:59 -0800 (PST) Received: by mail-ot0-x22f.google.com with SMTP id w8so14675962otw.11 for ; Mon, 13 Nov 2017 11:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6ViTo7j8zu0WrJ2d4xXb2+a/lkBVZAuy4G5BW3jIpi4=; b=FnAJW7LR58614M/v4I+V8mNFU1i17Yljit3pKFazAuKWtIu1brhZ9WC0VIMlavKINB IacV9YusRXQlzU3LxnGWQcQQeoEF0zGh8bxliHwN2bGmtm3FS/ZOIceY9StQqBymrRVg gPhrzU6TU8SefOtzeESC3j72kUZec0nZoy5m3oA2f29lXpnXPxyKqjlCgETABYpwjy/Z 6CBn+7YnZHNh68Hrzz6t2XFaaWgPBnSIQiP15E178fouje7ffGQY/ecCRDPw6gHqz+ft jhBcuS7I7DEKbWgauUJSh4UIUnojfBW5oDw1TSFNPZV/APQAwgbwsVxywwDs/wO62KOR pUxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ViTo7j8zu0WrJ2d4xXb2+a/lkBVZAuy4G5BW3jIpi4=; b=jgUVF5ppiI6pNxfc0K+kmMxgbo/MGt2ixej/LEHwkgdlSy7bx1lCni5VYneNAhT71v d1wHo0rJCMG9fnAmJMNjZtYN0Biq3pupVNfzC207I7Z8bGPIBJSIrQVhsnrF5RO6KOvy wm1g3PDMNDA3s/A/VQ1hSB8TWcLkJIKVKabzx+CNTwQqezuAu83E4NF2XzwtPZ9zjbGh LoWZ6Z/39QuDIuqHCqoqVE29MxDF4qMxN4sxCxZBWrNbKZCMQTGLULJ3yU99anr8yt5d mfykSi83UGEup1JZPe9hSucX4py3xfFxGCj02WR4jxJcPht5CxlsPlY4jbX+zuvsvSSW Hd/Q== X-Gm-Message-State: AJaThX4Pv+HU9HmnFag0XNPcZABtvPXYaUQJYN1JssICRWcXm9QghmA4 kOYRYXdm9IZlxrXpc0QreyNLYHLT1CO6R7XMJSU= X-Google-Smtp-Source: AGs4zMa/ML5/j1a3tITq0w4xleEkOgkKUKEbWBK2otmXXd69+fG2IMaetaWRIDLk9aRLqDk1b3BMGc9zZvR8Ckk8eps= X-Received: by 10.157.8.240 with SMTP id 103mr7136275otf.427.1510603084808; Mon, 13 Nov 2017 11:58:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.1.204 with HTTP; Mon, 13 Nov 2017 11:58:04 -0800 (PST) In-Reply-To: References: From: Michael Zimmermann Date: Mon, 13 Nov 2017 20:58:04 +0100 Message-ID: To: Laszlo Ersek Cc: "David F." , edk2 developers list Subject: Re: stdlib broken strncasecmp.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 19:53:59 -0000 Content-Type: text/plain; charset="UTF-8" > I've been subscribed to edk2-devel (wherever it lived whenever) since > approx. April 2012. So, I checked all my yearly archives, and the only > year where the search expression "df7729 patch" returns at least one hit > is 2013. Please don't judge the project's development process from a > four year old experience, there have been many changes. For StdLib I actually have the same experience(from 1-2 years ago). Patches either never get responded to or just forgotten after a long discussion. Thanks Michael On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek wrote: > Hi, > > On 11/10/17 20:09, David F. wrote: >> I would submit a patch but over the years of fixes and enhancements, >> they don't go anywhere. Then a couple years later someone does a >> half-baked fix and I have to run merge resolution on svn. > > I've been subscribed to edk2-devel (wherever it lived whenever) since > approx. April 2012. So, I checked all my yearly archives, and the only > year where the search expression "df7729 patch" returns at least one hit > is 2013. Please don't judge the project's development process from a > four year old experience, there have been many changes. > > Please consider submitting a patch with git: > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > (Optional reading: > .) > > Please don't forget to CC the StdLib maintainers on your patch -- they > are listed in "Maintainers.txt". > >> Anyway, the problem with that is the s1 compare to 0 should be before >> the s1++ (otherwise it matches when the s1 string is shorter than the >> s2 string). > > If you don't feel like posting a patch with git, can you perhaps > register in the TianoCore Bugzilla, and file a bug report there? > > https://bugzilla.tianocore.org/ > > Product: EDK2 > Component: Code > Package: StdLib > > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel