public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Zimmermann <sigmaepsilon92@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	Yonghong Zhu <yonghong.zhu@intel.com>,
	edk2-devel-01 <edk2-devel@lists.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: PrePiLib's FwVol.c can't handle padding before volume header
Date: Sun, 10 Dec 2017 23:18:23 +0100	[thread overview]
Message-ID: <CAN9vWD+yfqZxRcsMqSiKMrHXf8BAvYLYcUhbU9S+akBnF_rCOg@mail.gmail.com> (raw)
In-Reply-To: <CAN9vWDJWshkMbfkBSc2pgyqWqWfc8QsfQT7pUM=Zx6VLx_5qZg@mail.gmail.com>

Exactly. If I shift the pointer by 4 bytes from within PrePiLib the device
boots just fine.

I'm not sure if the size is the root cause but right now it only happens
when adding a ~15mb binary efi to the end of fvmain.

On Dec 10, 2017 11:13 PM, "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
wrote:

On 10 December 2017 at 21:58, Michael Zimmermann
<sigmaepsilon92@gmail.com> wrote:
> VolInfo doesn't seem to complain about FVMAIN_COMPACT.Fv:
> https://pastebin.com/ueUnepXF
>
> Does VolInfo support Fs's as well? because it fails on mine(even on a
> working one).
>

You mean to dissect the FFS that contains the FV? Not sure.

 So the _FVH signature is there but shifted by 4 bytes, right? Does
that only happen with large FVs?


  parent reply	other threads:[~2017-12-10 22:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-10 20:58 PrePiLib's FwVol.c can't handle padding before volume header Michael Zimmermann
2017-12-10 21:22 ` Ard Biesheuvel
2017-12-10 21:33   ` Ard Biesheuvel
2017-12-10 21:45     ` Michael Zimmermann
2017-12-10 21:49       ` Ard Biesheuvel
2017-12-10 21:58         ` Michael Zimmermann
2017-12-10 22:13           ` Ard Biesheuvel
     [not found]             ` <CAN9vWDK5MmyvinRXx5XQoNTnGi90rgDCFDqdGBk1t-QZ=NqNQg@mail.gmail.com>
     [not found]               ` <CAN9vWDLKTRjZ88uyiD0x8__Fm9y1Zx1W1z+Si9T9-REQFSeZXQ@mail.gmail.com>
     [not found]                 ` <CAN9vWDKKKaCGL9nRnqVWR8T60ABpCP7tH723EjXaHfc2bWsa1A@mail.gmail.com>
     [not found]                   ` <CAN9vWDJWshkMbfkBSc2pgyqWqWfc8QsfQT7pUM=Zx6VLx_5qZg@mail.gmail.com>
2017-12-10 22:18                     ` Michael Zimmermann [this message]
2017-12-10 23:08                       ` Ard Biesheuvel
2017-12-11  7:30                         ` Michael Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN9vWD+yfqZxRcsMqSiKMrHXf8BAvYLYcUhbU9S+akBnF_rCOg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox