From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c06::22d; helo=mail-oi0-x22d.google.com; envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DBB6E20955F02 for ; Wed, 28 Feb 2018 00:09:46 -0800 (PST) Received: by mail-oi0-x22d.google.com with SMTP id 123so1155469oig.5 for ; Wed, 28 Feb 2018 00:15:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TRvFdgug3iEfjj9G/5Hg9KeCK3EdSzVk+3BAmr/OqQk=; b=EeRYJ5qbb3NmGq+0iRb5Hlk2W0Fbuu5uhW+QLYLeBalBpDwP+k60l1eX0PMVx86CF3 /CX7hnbnzAabxbGGbEIBocS+DTWFAoHCw9Eq3axp2JTyBVblxxJewY4JR1gr71X/ilpY cNzK4I/cGoPzYPrusT/VBbtiHxag8bnK3VCYJGl/cKp3qkxpmBHgmXNX2117pY/Fy6Vw jN7pnxtkMwlXq5I6UMM8Yblpw8YJYE7/KCxeZXz6Cckv08Wc5Ehfomvs9Rxo3noKYyDu kSQn6NAEQP3OkC3wFJ1WZpKzP/TVOVXCrtY9M9vaYgcGrdj66BvowFWyx+57AgftngRc gxPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TRvFdgug3iEfjj9G/5Hg9KeCK3EdSzVk+3BAmr/OqQk=; b=A3J3+ahV5Heauab9Tnu0/GxpdL0jdQ1YWAA7UxE6ywSawwyA8k5HSJZWNzLQQJgWJ/ NUEG9ZqLuvNPV/9pgyLWPESKpbHD/eXmVn9PzwPFyXmOflBf/87tlsbNjjN+78YfdwKD fnyWgdVuMOCZ2HtFn9vIwHjKH3XmZR5ZVOnjmMzVc0gd58wQ6XNbwSNeEArO5Mt7NdL9 H9FZ2cGif5ZUqLsM/4amUgKq+jzl5Rh+hPyN+QqdtgPmzgwbm4hcA3AZgUZshvVuzzOs YlboGriYNdVUwn0DlOU8upi91WTk6BCWt43q9id9UzpNkmfQ4R9Q2Z4+34ZeSkmxWIN7 6E4w== X-Gm-Message-State: APf1xPA7ctMndoRaj/hUseceQG9z5fcBvJdyFB/ydAC56SowM8LNJ/xc 3O8ZsKcMg4AbQclo7fKOG4ErYLFLAn6boIrTdxU= X-Google-Smtp-Source: AG47ELsK6tuK6CXGkm5V2IzkK+2+X3/uByh2uV2czOTW+Ve7RVItOpmEZzSb8+sgwyj4h0wSlJRWx424Ugd9rM1wFao= X-Received: by 10.84.78.131 with SMTP id c3mr6380854oiy.292.1519805753074; Wed, 28 Feb 2018 00:15:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.31.116 with HTTP; Wed, 28 Feb 2018 00:15:52 -0800 (PST) In-Reply-To: References: <26da6afd-102b-0006-c6b7-a10d8e13f96e@Intel.com> From: Michael Zimmermann Date: Wed, 28 Feb 2018 09:15:52 +0100 Message-ID: To: Ard Biesheuvel Cc: Andrew Fish , "Ni, Ruiyu" , edk2-devel-01 , Leif Lindholm X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: 'fastboot boot' TPL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 08:09:47 -0000 Content-Type: text/plain; charset="UTF-8" > I agree. Did you run into any issues due to this? Surprisingly no. I was just trying to understand the fastboot implementation before I use it on my platform and was surprised that this works at all. I can imagine that's because this is supposed to load linux's efistub which probably doesn't do anything but calling SetVirtualMemoryMap and ExitBootServices. I can imagine that more complex loaders like the one used for Windows wouldn't work this way. On Wed, Feb 28, 2018 at 9:10 AM, Ard Biesheuvel wrote: > On 28 February 2018 at 07:56, Michael Zimmermann > wrote: > > I feel like both of you misunderstood my intention. > > As I said in my initial mail, I'm not arguing the spec - I know that > > StartImage must be called from TPL_APPLICATION. > > > > I'm just discussing a bug inside EmbeddedPkg/Application/AndroidFastboot > - > > because they actually do call StartImage from TPL_CALLBACK. > > I think the confusion is a result of the fact that you never mentioned > that particular module/file until now. > > > As I proposed in my initial mail, we should not only fix that, but also > add > > tpl ASSERTs inside several BootServices to prevent this from happening in > > future. > > > > I agree. Did you run into any issues due to this? >