From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-x243.google.com (mail-ua0-x243.google.com [IPv6:2607:f8b0:400c:c08::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7622521A04811 for ; Thu, 13 Apr 2017 23:19:07 -0700 (PDT) Received: by mail-ua0-x243.google.com with SMTP id q26so5964972uaa.3 for ; Thu, 13 Apr 2017 23:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A3dC9NKdzOb0qXlv79p0ymAsA2f9cA5EEOYIoo6RTY8=; b=Ces4T24Gq+HV7zI/7zQhz6y2LQFAw0sgn98HL/QVvGZfj9dRDz8wLeW1osNLDn+bwr wIl05xwQnDiZ7k0faNJrby6r7B+glYggSaSGKzgQDo8oD0Nb2RAaDPoYkvoSq1VY1z64 uhRk9mO6/nsDzwtfAP8oqQ2nx9dfr9VgmkGtfh7NqwiI9CVBJ8KK9EFmHMMQgsB9jlYi FmknhAMie9JSEiuG1xgfd3sW1LxVxy9tO3uL/5HqDnzX5zrUC9bDM6d4EIoGgA3qK2PY j7+jFaVgLCbmUE8vlaYWZuQfOkuAbpFCWhL8ey92xcUIU/rClFeEFmhkw2p4EEgdAoXl muVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A3dC9NKdzOb0qXlv79p0ymAsA2f9cA5EEOYIoo6RTY8=; b=ss8Bt0PlFpjSfMZ/GIfqhNqB5/Z63UyKIN4mYtzHQ8zZn222UzBF1ApDbOQiIPApSG 3K42iN0aOwgXCJwg91Ex1dkyPoM5SNSaMDTubb3KCRRVwus4iI7o/tC2OBbd80SLsDbb 7vdiulcACD20SnfHFXjKwTrhfABgl2mzD9ZORhqViRpklvphQY7/ZAsjc3dLNm1OICz/ hOZ4ewYPfHmJ+hqAk7E5GG/+gZ5yDgbWgDEi9UZlfEYbShEZ0UxjdmQ7G4rurzHzyhL9 XYUlLgcIOoNESROmDMNFo0LKXdIl//nz9nX/kd4XGC5FcljRoSAw+5EJ7HtsHA9j55Vk /t3w== X-Gm-Message-State: AN3rC/6RAs702yr0TzgRtvgKbybcM0A5fLtQde/+FOy6yOuwAd5cmhe0 B5OnwixizTHHR2HJPZIupAyf/ehqiA== X-Received: by 10.176.70.26 with SMTP id m26mr2728650uaa.167.1492150746597; Thu, 13 Apr 2017 23:19:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.171.80 with HTTP; Thu, 13 Apr 2017 23:19:06 -0700 (PDT) In-Reply-To: References: <20170404144553.17976-1-ard.biesheuvel@linaro.org> From: Michael Zimmermann Date: Fri, 14 Apr 2017 08:19:06 +0200 Message-ID: To: Ard Biesheuvel Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , Jens Wiklander Subject: Re: [PATCH] ArmVirtPkg/ArmVirtQemuKernel: increase slack space for DTB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 06:19:07 -0000 Content-Type: text/plain; charset=UTF-8 Ok I've found it in "RelocatableVirtHelper.S". Thanks Michael On Fri, Apr 14, 2017 at 8:04 AM, Michael Zimmermann wrote: > "contains some scratch memory at the start of the image to use as a > stack very early on" > When does this happen? I didn't see any edk2-code which sets SP to the > slack space. > > Thanks > Michael > > On Tue, Apr 4, 2017 at 5:02 PM, Ard Biesheuvel > wrote: >> On 4 April 2017 at 15:59, Laszlo Ersek wrote: >>> On 04/04/17 16:45, Ard Biesheuvel wrote: >>>> The relocatable build of ArmVirtQemuKernel is designed to be executed >>>> from RAM, and contains some scratch memory at the start of the image >>>> to use as a stack very early on, and to preserve the DTB image received >>>> from QEMU while it discovers and initializes memory. >>>> >>>> It turns out that 8 KB is a bit on the small side here, especially when >>>> executing with secure world emulation enabled, in which case there are >>>> additional nodes present. >>>> >>>> So increase the slack space to 32 KB. >>>> >>>> While at it, remove a stale Xen reference that was copy/pasted when this >>>> file was created. >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> Signed-off-by: Ard Biesheuvel >>>> --- >>>> ArmVirtPkg/ArmVirtQemuKernel.fdf | 12 ++++++------ >>>> 1 file changed, 6 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.fdf b/ArmVirtPkg/ArmVirtQemuKernel.fdf >>>> index 7bc62f6b0b48..55541a1075d8 100644 >>>> --- a/ArmVirtPkg/ArmVirtQemuKernel.fdf >>>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.fdf >>>> @@ -52,15 +52,15 @@ [FD.QEMU_EFI] >>>> ################################################################################ >>>> >>>> # >>>> -# Implement the Linux kernel header layout so that the Xen loader will identify >>>> +# Implement the Linux kernel header layout so that the loader will identify >>>> # it as something bootable, and execute it with a FDT pointer in x0 or r2. >>>> -# This area will be reused to store a copy of the FDT so round it up to 8 KB. >>>> +# This area will be reused to store a copy of the FDT so round it up to 32 KB. >>>> # >>>> -0x00000000|0x00002000 >>>> +0x00000000|0x00008000 >>>> DATA = { >>>> !if $(ARCH) == AARCH64 >>>> 0x01, 0x00, 0x00, 0x10, # code0: adr x1, . >>>> - 0xff, 0x07, 0x00, 0x14, # code1: b 0x2000 >>>> + 0xff, 0x1f, 0x00, 0x14, # code1: b 0x8000 >>>> 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, # text_offset: 512 KB >>>> 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, # image_size: 2 MB >>>> 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, # flags >>>> @@ -79,7 +79,7 @@ [FD.QEMU_EFI] >>>> 0x00, 0x00, 0xa0, 0xe1, # nop >>>> 0x00, 0x00, 0xa0, 0xe1, # nop >>>> >>>> - 0xf6, 0x07, 0x00, 0xea, # b 0x2000 >>>> + 0xf6, 0x1f, 0x00, 0xea, # b 0x8000 >>>> 0x18, 0x28, 0x6f, 0x01, # magic >>>> 0x00, 0x00, 0x00, 0x00, # start >>>> 0x00, 0x00, 0x20, 0x00, # image size: 2 MB >>>> @@ -87,7 +87,7 @@ [FD.QEMU_EFI] >>>> !endif >>>> } >>>> >>>> -0x00002000|0x001fe000 >>>> +0x00008000|0x001f8000 >>>> gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize >>>> FV = FVMAIN_COMPACT >>>> >>>> >>> >>> Acked-by: Laszlo Ersek >> >> Thanks. Pushed as 4d2ea2616e94 >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel