public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Michael Zimmermann <sigmaepsilon92@gmail.com>
To: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
	Laszlo Ersek <lersek@redhat.com>,
	 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Yonghong Zhu <yonghong.zhu@intel.com>,
	Liming Gao <liming.gao@intel.com>
Subject: visibility pf PcdSet
Date: Mon, 20 Mar 2017 17:06:48 +0100	[thread overview]
Message-ID: <CAN9vWDJhYWarrabhGbEcY3L_R0hc_SAR4GWUrwBt=kUWgiQaZA@mail.gmail.com> (raw)

Do I understand correctly, that a PcdSet on a 'PcdsPatchableInModule'
is only visible to the current module?(SEC, driver, application, ...)
Because I've tested this and a PcdSet on
gArmTokenSpaceGuid.PcdSystemMemoryBase inisde PrePi is not visible
inside a DXE_DRIVER - which means that for everyone else the value is
still 0x0.

If this is the case and I don't have some platform bug, then there is
probably a bug in ArmVirtPkg's HighMemDxe where this Pcd is used in a
DXE_DRIVER:
https://github.com/tianocore/edk2/blob/76874be3d411bf8daac051718e20932e0bf97d70/ArmVirtPkg/HighMemDxe/HighMemDxe.c#L70
It doesn't cause anything bad but it would show 'Failed to add System
RAM @ START - END (Access Denied)' after calling AddMemorySpace for
memory which has already been registered.

Thanks
Michael


             reply	other threads:[~2017-03-20 16:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-20 16:06 Michael Zimmermann [this message]
2017-03-20 16:17 ` visibility pf PcdSet Laszlo Ersek
2017-03-20 18:19 ` Ard Biesheuvel
2017-03-20 18:37   ` Michael Zimmermann
2017-03-21  2:23   ` Gao, Liming
2017-03-21  7:09     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN9vWDJhYWarrabhGbEcY3L_R0hc_SAR4GWUrwBt=kUWgiQaZA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox