From: Michael Zimmermann <sigmaepsilon92@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
eugene@hp.com
Subject: Re: [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags
Date: Thu, 4 Aug 2016 18:01:05 +0200 [thread overview]
Message-ID: <CAN9vWDJoe8kGqRn3j00N=KP0UaL7SgzTvHG+WjZi+8CO9uYPig@mail.gmail.com> (raw)
In-Reply-To: <1470321767-26921-4-git-send-email-ard.biesheuvel@linaro.org>
not directly related but could we add nostdinc too? At least for my
platform that works perfectly and it prevents you from accidentally
including any libc/libgcc/whatever headers from your toolchain.(nostdlib is
already enabled)
Thanks
Michael
On Thu, Aug 4, 2016 at 4:42 PM, Ard Biesheuvel <ard.biesheuvel@linaro.org>
wrote:
> Avoid build errors when including OpensslLib, which may throw
> undefined reference errors for builtin functions if -fno-builtin
> is not specified (and it is already set for IA32, X64 and AARCH64)
> So set it for ARM as well.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> BaseTools/Conf/tools_def.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.
> template
> index 88af82a683d9..4f1dd4be378e 100644
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -4334,7 +4334,7 @@ DEFINE GCC_ALL_CC_FLAGS = -g -Os
> -fshort-wchar -fno-strict-aliasing -
> DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32
> -malign-double -freorder-blocks -freorder-blocks-and-partition -O2
> -mno-stack-arg-probe
> DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone
> -Wno-address -mno-stack-arg-probe
> DEFINE GCC_IPF_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS)
> -minline-int-divide-min-latency
> -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS)
> -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char
> -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address
> -mthumb -mfloat-abi=soft
> +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS)
> -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char
> -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin
> -Wno-address -mthumb -mfloat-abi=soft
> DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS)
> -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char
> -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin
> -Wno-address -fno-asynchronous-unwind-tables
> DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align
> DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
next prev parent reply other threads:[~2016-08-04 16:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:42 [PATCH 0/3] Build fixes for ARM/OpenSSL Ard Biesheuvel
2016-08-04 14:42 ` [PATCH 1/3] ArmPkg/ArmSoftFloatLib: disable LTO build for GCC Ard Biesheuvel
2016-08-06 14:18 ` Michael Zimmermann
2016-08-06 14:42 ` Ard Biesheuvel
2016-08-06 14:53 ` Michael Zimmermann
2016-08-07 9:28 ` Michael Zimmermann
2016-08-07 10:29 ` Ard Biesheuvel
2016-08-04 14:42 ` [PATCH 2/3] ArmPkg/CompilerIntrinsicsLib: make the default memset() weak Ard Biesheuvel
2016-08-04 14:42 ` [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags Ard Biesheuvel
2016-08-04 16:01 ` Michael Zimmermann [this message]
2016-08-05 14:34 ` Ard Biesheuvel
2016-08-05 14:26 ` Gao, Liming
2016-08-05 14:33 ` Ard Biesheuvel
2016-08-05 12:53 ` [PATCH 0/3] Build fixes for ARM/OpenSSL Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN9vWDJoe8kGqRn3j00N=KP0UaL7SgzTvHG+WjZi+8CO9uYPig@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox