From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 935051A1DFE for ; Thu, 4 Aug 2016 09:01:07 -0700 (PDT) Received: by mail-wm0-x242.google.com with SMTP id i5so45890988wmg.2 for ; Thu, 04 Aug 2016 09:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5aDx41SAG8EbG30UJEc1Js0L7fXO/bte1ZkfSEGH0yI=; b=09OHdaGwOKV9CRvxhyhkw2DnOtiUuIm57olHIlbNyKA02PIe4vNTAuaS3HrsrZpFYu q+HQa8FmGZIIPm6uU82qIi4+S6dgWQEXWgWAyeWu+8D2obkWYTJxd7sDYkKaSC1lk/HF /XebVpGEDPL7P0c+mz4aeLyfWaUIvbashlp7CC4d8LWfQumP24kovnCszMBX6UUAwdoS zFfRI/vqm6kuHEF8sss/GJdRdnGwV1kKm4PxdwVLMUGGkUklkJ739zD0PS8oNdjcPBO9 NDV9dbhlGYfR/4V0o72zn5LyzWs0mj69esgWqfkp+oLABMjMKBE+iflio0j23bv5chzd p0JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5aDx41SAG8EbG30UJEc1Js0L7fXO/bte1ZkfSEGH0yI=; b=PKKJTrrrKx/sBDQ9mCyLsXBAzbbGSHdDvM5D9N/QqKgdcIBPlU07d+HE5L2EWeFR0X WpFVWcg1L9GVB229sYNAQd4xf1CXjTg8YfMi/UeUoFWS7BF9JnoqzDt8Bet9Zsr6CGma dqyXbPtPTV716CxC+Hw3g+E4xtUAY8wQ8gG8UpKWqsyBanHTP7YIvKE5Rw+aggxuL2jY iKZcpuIIXxZoPXT6+a5+LJxeMJnBA+wTHyweqlNyQPbTg3SMpOOKC7l8+AgsLYcseYE7 gLzkaBgmpPYLEORLtNyOctmjJkPwah7pJ+vBh22yBG3VRyPNcq8i4iZyOfObwxqN2Fw7 qGgQ== X-Gm-Message-State: AEkooutL6FLBaYsXPDUVchYwM2E+x/jNAIHZavp/OQW6brrVdR5lBrlDTqqp7HvYArf5o07twgRc8IZB9wintg== X-Received: by 10.28.30.1 with SMTP id e1mr31987290wme.77.1470326466164; Thu, 04 Aug 2016 09:01:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.238.198 with HTTP; Thu, 4 Aug 2016 09:01:05 -0700 (PDT) In-Reply-To: <1470321767-26921-4-git-send-email-ard.biesheuvel@linaro.org> References: <1470321767-26921-1-git-send-email-ard.biesheuvel@linaro.org> <1470321767-26921-4-git-send-email-ard.biesheuvel@linaro.org> From: Michael Zimmermann Date: Thu, 4 Aug 2016 18:01:05 +0200 Message-ID: To: Ard Biesheuvel Cc: Yonghong Zhu , "Gao, Liming" , "edk2-devel@lists.01.org" , Leif Lindholm , eugene@hp.com X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Aug 2016 16:01:08 -0000 Content-Type: text/plain; charset=UTF-8 not directly related but could we add nostdinc too? At least for my platform that works perfectly and it prevents you from accidentally including any libc/libgcc/whatever headers from your toolchain.(nostdlib is already enabled) Thanks Michael On Thu, Aug 4, 2016 at 4:42 PM, Ard Biesheuvel wrote: > Avoid build errors when including OpensslLib, which may throw > undefined reference errors for builtin functions if -fno-builtin > is not specified (and it is already set for IA32, X64 and AARCH64) > So set it for ARM as well. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > BaseTools/Conf/tools_def.template | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def. > template > index 88af82a683d9..4f1dd4be378e 100644 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -4334,7 +4334,7 @@ DEFINE GCC_ALL_CC_FLAGS = -g -Os > -fshort-wchar -fno-strict-aliasing - > DEFINE GCC_IA32_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -m32 > -malign-double -freorder-blocks -freorder-blocks-and-partition -O2 > -mno-stack-arg-probe > DEFINE GCC_X64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) -mno-red-zone > -Wno-address -mno-stack-arg-probe > DEFINE GCC_IPF_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) > -minline-int-divide-min-latency > -DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) > -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char > -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address > -mthumb -mfloat-abi=soft > +DEFINE GCC_ARM_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) > -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char > -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin > -Wno-address -mthumb -mfloat-abi=soft > DEFINE GCC_AARCH64_CC_FLAGS = DEF(GCC_ALL_CC_FLAGS) > -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char > -ffunction-sections -fdata-sections -fomit-frame-pointer -fno-builtin > -Wno-address -fno-asynchronous-unwind-tables > DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align > DEFINE GCC_DLINK_FLAGS_COMMON = -nostdlib --pie > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >