From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3E1961A1E3D for ; Wed, 31 Aug 2016 02:52:16 -0700 (PDT) Received: by mail-wm0-x233.google.com with SMTP id d196so28263220wmd.0 for ; Wed, 31 Aug 2016 02:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DKMiQHc9W8dpKT8g+vRAtrXoxfTn7yC7bTkntjdLsC8=; b=uojN922hAoPySipYcnk4qXfWWUvjYq5tEMaTwJTYXmvci7/ZfgZnCrWpfPlCb3h6ch PHaPPX5BOmzxZZK25xQT/oCx1D/iFbvuhoSh7S/FMvWzhsWKQGfwpyWRMUYU3RiVzzxt xi7zAR4fA+N2cLlOyU363Owo94XLUL5oJIs/OsrEskB6GMB2WNuQ+RZ2qIk8LoVlA28D eTalumYbL/OHBMOAfnM2OtTj44fcDo65HvvakL5SnCFjVA/hsDLKp7j6GeLKPobCKxdn 7hPsTJdhnwrfmPZiFls0vEljYtRcWfYZeCkgYAy28vlRNwwsERWwecmt8+w7oYbfmRUI YaiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DKMiQHc9W8dpKT8g+vRAtrXoxfTn7yC7bTkntjdLsC8=; b=CN70ftEYsdrqCn5/o4IQiizDYEBBwIbPA79tosCqpi9BZ38P3nHS4mWPnD/KzRwZKg Y0oxhBPyPc9YeFJYhStZgHNIXKNWJ5EgTW7XRFRhbB4jE+UporYkweg02De5r6U201Of 4vve9WMzKfvxnqRUYEzzHPo2QVGa20m97/eH5YbR2ilVyapHnjviFAC4ngYP2VorXj5D D97B+bbhnwUOHGrpBAkTbjT6MltwIqiPfks8M0mc+lLnM0ttKFJYQ9lsVWKvkz/VS1rN 0GqTOW+ww9FwvymyoA/OylPCq+Shp2b+3QIulqVP/vHPoHofhVk8tmKee8qvGGrmramQ Lxiw== X-Gm-Message-State: AE9vXwM+0RkjhIKpdazq5PWvZ6JUuzSqb5cgaI2yuXBbjh7RsCQ8vzM1UeOAvn9DqTymVVrjCOTMA2u9+vmF6Q== X-Received: by 10.195.12.77 with SMTP id eo13mr8133657wjd.142.1472637134849; Wed, 31 Aug 2016 02:52:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.238.198 with HTTP; Wed, 31 Aug 2016 02:52:14 -0700 (PDT) In-Reply-To: References: <1470842282-8415-1-git-send-email-ard.biesheuvel@linaro.org> <1470842282-8415-23-git-send-email-ard.biesheuvel@linaro.org> <20160811083817.GQ31760@bivouac.eciton.net> From: Michael Zimmermann Date: Wed, 31 Aug 2016 11:52:14 +0200 Message-ID: To: Evan Lloyd Cc: Leif Lindholm , "edk2-devel@lists.01.org" , "Cohen, Eugene" , Laszlo Ersek , "ard.biesheuvel@linaro.org" X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 09:52:16 -0000 Content-Type: text/plain; charset=UTF-8 >Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and "Tested-by" > mean tested? Yes you're right, sorry. I guess I just had too much hope in reviewers actually testing the changes :D On Wed, Aug 31, 2016 at 11:47 AM, Evan Lloyd wrote: > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Michael Zimmermann > >Sent: 31 August 2016 05:33 > >To: Leif Lindholm > >Cc: edk2-devel@lists.01.org; Cohen, Eugene; Laszlo Ersek; > >ard.biesheuvel@linaro.org > >Subject: Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to > >ASM_FUNC() asm macro > > > >reviewed should mean tested ;) > > > Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and > "Tested-by" mean tested? > > Evan > ... > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > >