From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c0f::241; helo=mail-ot0-x241.google.com; envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-ot0-x241.google.com (mail-ot0-x241.google.com [IPv6:2607:f8b0:4003:c0f::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DED2622225BED for ; Fri, 22 Dec 2017 10:21:46 -0800 (PST) Received: by mail-ot0-x241.google.com with SMTP id n18so16517097otd.1 for ; Fri, 22 Dec 2017 10:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1Ga5+uN55JaXsjCx4+hcPCADepWIK1hth5zwMCROrWw=; b=BQIkbm/3sSHoV7jDlUq6wYg4SjzZvzYo9xH3BXbZyS5PH3NVu/mB3UanYqBjXeAX59 iMSLf0oiX3YR8WxUASvcyom3wRgaXbIQG0QjjeI0PCg7sfGD/JJ2jl6KCvLeqtAO9rmQ OckEjEaKbS2ZDmLqC1b4xTXx6hhQRLViPzWVyguAx2K6S6dBX1umsUTRAxygXBFJb4fi NeWFAdwzBKMPqV0A7+0JFQu8B3k8p/l3oAVhhHPKnYhpAtM9LU8C/sfGktjCCDI0HfIP 2z3f19nth2PnlJNfVkS53nfKhzo7ODwKC8yb+QhRlM8jC7k5dT7gOmmwVkg43zoEdu+D aQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1Ga5+uN55JaXsjCx4+hcPCADepWIK1hth5zwMCROrWw=; b=tkTaLVGToktjHIxp3GhoTiQDDFh4d9BD2fx4KxYpwGwpd33IFQhImZHc7MAbcrAZni G2/+17J48XC9vFnCfUY5Y02tDFYrGZXuSCnHxc+d4pTqoiz1lz2BjrTzJyk21lImVRzM zdX8GLVsYGWV5bCWkxDtGXnkVwPDW5H9fNCD94ritX7G2Telwb45/4fgA84SK2oUFuUm iM4KHC6hugPGpzxOszPQ+vkR5b12IztJ9PbrwT+aIunyy0o1SwRqFkAgZbxvT+D57JeU oUk0oYUpt5NxdniH1FmMxz4URYnuAuLwOW+U95Nl5ItUNIZIrVcv/Rid2NtvKpI9ZAsp OX1Q== X-Gm-Message-State: AKGB3mKv9jb9VTSaNjkvQW4mTESqdFeLRqlVoDRTxxvsNnCuwwmQYUc/ U8FRvDkAsuQtNo+6r6O90jaeU16BDIAmKK3U7Ks= X-Google-Smtp-Source: ACJfBou2ByZeKGwougJCdn9bs8S9PR9eKHnoiRArGcgHeFYVR92NjbCOK9BycR5RFlJG4dd6/FX3PGRia1y8N5tbes4= X-Received: by 10.157.63.11 with SMTP id m11mr11446218otc.179.1513967196213; Fri, 22 Dec 2017 10:26:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.68.230 with HTTP; Fri, 22 Dec 2017 10:26:35 -0800 (PST) In-Reply-To: References: <20171222072336.23504-1-sigmaepsilon92@gmail.com> From: Michael Zimmermann Date: Fri, 22 Dec 2017 19:26:35 +0100 Message-ID: To: "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , "Gao, Liming" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [PATCH 0/3] fix GCC optimizations and warnings for SetJump/LongJump X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 18:21:47 -0000 Content-Type: text/plain; charset="UTF-8" Is adding attributes to both header and source files an UEFI coding convention? Because for the compiler it's only necessary to do that in the header files afaik. Thanks Michael On Fri, Dec 22, 2017 at 6:55 PM, Kinney, Michael D < michael.d.kinney@intel.com> wrote: > I see the .h file updates here. > > I think the C files in MdePkg/Library/BaseLib also need > to be updated for this patch series to be complete. > > Thanks, > > Mike > > > -----Original Message----- > > From: M1cha [mailto:sigmaepsilon92@gmail.com] > > Sent: Thursday, December 21, 2017 11:24 PM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel ; Kinney, > > Michael D ; Gao, Liming > > > > Subject: [edk2] [PATCH 0/3] fix GCC optimizations and > > warnings for SetJump/LongJump > > > > I've already discussed this in past but never actually > > sent proper > > patches for some reason. > > > > This patch series is about fixing problems with these > > functions when > > using GCC. > > > > M1cha (3): > > MdePkg: add RETURNS_TWICE attribute > > MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to > > SetJump > > MdePkg: add NORETURN attribute to LongJump and > > InternalLongJump > > > > MdePkg/Include/Base.h | 10 > > ++++++++++ > > MdePkg/Include/Library/BaseLib.h | 2 ++ > > MdePkg/Library/BaseLib/BaseLibInternals.h | 1 + > > 3 files changed, 13 insertions(+) > > > > -- > > 2.15.1 > >