From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c06::241; helo=mail-oi0-x241.google.com; envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org Received: from mail-oi0-x241.google.com (mail-oi0-x241.google.com [IPv6:2607:f8b0:4003:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6593622225BED for ; Fri, 22 Dec 2017 10:22:26 -0800 (PST) Received: by mail-oi0-x241.google.com with SMTP id j14so8263431oih.3 for ; Fri, 22 Dec 2017 10:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8sdprNvFRumJJ+dTVmkN7EiK8ODMX+T3GnnO5tSRSVA=; b=C5NdaVbgQycrCd7IzFzmXLb9rhj+uZ/Myr3DGUQDePD3LybBhY4ZTKAz6qpHAJLEVk SlVnQGD5dW3q4SMkuaOIPOhi0wq6jTjFXDvhfDPGedvliNsw0HiDI3LdajCeNuIcTreh sfmbtNB/jnSwI3VdwHSw6EAuXYg0I6QAP9TiUg+NK/2YLghyMtsuAHrqNRc72khYlwiB pOdtggHu5nkqCkJV98C0wo/21NIIZSRMbORcAznyN8ElIo6XdBagSEjVfRwKjORkWdNy 8tVWbYNalKs4pgvS8ciroZ/3Jz9fFPoIklszHUfJObu+qmM6a99b2OV0N1J4E5kIcVRR ysIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8sdprNvFRumJJ+dTVmkN7EiK8ODMX+T3GnnO5tSRSVA=; b=MuTBdiXRdlgx0Gb6eP2EjShVSvZwwTUQJfs3ACp0j/Z1DJNqcnw03m5ELg7GLGzWMW Ndly4f4cLXV703TmX75s6QNzWH6VyYlTCCSVXxGeidREto0YjH1XRIBLFG9oAmaYswl/ tqOA1SbP3bbPx5GQLdHzJoX4jlQ4xlMXo/N5aOduPJXnzpTTWiueXF6K/PKj4XGTbM3K D5QEZast4oulT9l8H42CPB20obsbv1OJaI/0JGWNEAkB7lysyTjl1Hp99XBYaSMj9dIC 1Wd/VZxsLriLlng6IiEEI7Hn5g7vPxEpzPb3X5q3VlxYgtwhtpt7bMG5VWh97ggqOvQF 4fRg== X-Gm-Message-State: AKGB3mJ97fiDFfsB75mYKoqQVf2WB8ygbcB6v4iH8H2nKU2Ht6yyMfjQ D5u2Yxy50OfNBvKG4HPj6MIvw+0pjr4cx8zaweI= X-Google-Smtp-Source: ACJfBouPq7qS0ukiyrqqGb6YXORpyjZibgP9fZT2wReHB8vtstCCK7I5KRNR1aZ/n3GOaTUxaA1U/BU0YS03fOpubLo= X-Received: by 10.202.108.66 with SMTP id h63mr9794252oic.305.1513967235957; Fri, 22 Dec 2017 10:27:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.68.230 with HTTP; Fri, 22 Dec 2017 10:27:15 -0800 (PST) In-Reply-To: References: <20171222072336.23504-1-sigmaepsilon92@gmail.com> <20171222072336.23504-2-sigmaepsilon92@gmail.com> From: Michael Zimmermann Date: Fri, 22 Dec 2017 19:27:15 +0100 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Michael D Kinney , Liming Gao X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [PATCH 1/3] MdePkg: add RETURNS_TWICE attribute X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 18:22:26 -0000 Content-Type: text/plain; charset="UTF-8" The reason for that is that I was lazy when doing copy&paste ;) I'll send a v2. On Fri, Dec 22, 2017 at 4:24 PM, Ard Biesheuvel wrote: > On 22 December 2017 at 07:23, M1cha wrote: > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Michael Zimmermann > > --- > > MdePkg/Include/Base.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > > index 22ab5d3715fb..c863de407418 100644 > > --- a/MdePkg/Include/Base.h > > +++ b/MdePkg/Include/Base.h > > @@ -218,6 +218,16 @@ VERIFY_SIZE_OF (__VERIFY_UINT32_ENUM_SIZE, 4); > > #endif > > #endif > > > > +#ifndef RETURNS_TWICE > > + #if defined (__GNUC__) || defined (__clang__) > > + #define RETURNS_TWICE __attribute__((returns_twice)) > > + #elif defined(_MSC_EXTENSIONS) && !defined(MDE_CPU_EBC) > > + #define RETURNS_TWICE > > + #else > > + #define RETURNS_TWICE > > What is the point of having two versions that are #defined to nothing? > > > + #endif > > +#endif > > + > > // > > // For symbol name in assembly code, an extra "_" is sometimes necessary > > // > > -- > > 2.15.1 > > >