unknown section type handling in ElfConvert

unknown section type handling in ElfConvert

[Michael Zimmermann]

ElfConvert iterates over the section headers and handles the following
section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0

the default case looks like this:
//
//  Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section
into Coff file", mInImageName, (unsigned)Shdr->sh_type);

The comment kinda conflicts with the debug message. Is not copying
unknown sections a bug?
I guess this could lead to problems if a module would ever rely on
non-standard sections being available.

Thanks
Michael

Re: unknown section type handling in ElfConvert

[Zhu, Yonghong]

Hi Michael,

We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section.

Best Regards,
Zhu Yonghong


-----Original Message-----
From: Michael Zimmermann [mailto:sigmaepsilon92@gmail.com] 
Sent: Friday, June 08, 2018 11:46 PM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2] unknown section type handling in ElfConvert

ElfConvert iterates over the section headers and handles the following section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0

the default case looks like this:
//
//  Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section into Coff file", mInImageName, (unsigned)Shdr->sh_type);

The comment kinda conflicts with the debug message. Is not copying unknown sections a bug?
I guess this could lead to problems if a module would ever rely on non-standard sections being available.

Thanks
Michael