From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sigmaepsilon92@gmail.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4001:c06::235; helo=mail-io0-x235.google.com;
 envelope-from=sigmaepsilon92@gmail.com; receiver=edk2-devel@lists.01.org 
Received: from mail-io0-x235.google.com (mail-io0-x235.google.com
 [IPv6:2607:f8b0:4001:c06::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 09759210E2DAE
 for <edk2-devel@lists.01.org>; Fri,  8 Jun 2018 08:45:54 -0700 (PDT)
Received: by mail-io0-x235.google.com with SMTP id e15-v6so16432651iog.1
 for <edk2-devel@lists.01.org>; Fri, 08 Jun 2018 08:45:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:from:date:message-id:subject:to:cc;
 bh=nblmu+uLZ5DD6GvZmcmigwNMtBCqxWDSrRN+G0BH80Q=;
 b=Ywe+1Bnkc/+fA7sVhdBSY0lFTjqtA5+VP5io9e789w4McnMg3z3kbGSa8lI69ydzgX
 SzKNa1CTKSX/yPdp3Jia//Jbeq8y3dfJs7vadsxG9gtAnSVr2nNrP+/ItuwIul0GkYkO
 KsfWQ5/M3Wlu7a8zbmkEKyv2etQ3gGUhrgImI1VRh6qxcrDqkpQbkj0x5Z59v2KKW3XE
 ZPyaI+2X0M3a5LHUFO+KqDJIYZWxEvLpjNNGi6GzUqVwEF2OcEm+p8wpjhKUF0+aRaj3
 a1XEALpptvjw+xwZDDDx5xcn8yeDQ48kWs88MYgDTraAtFZIzPAXAnms3JKgUw6XBKNJ
 kvfg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=nblmu+uLZ5DD6GvZmcmigwNMtBCqxWDSrRN+G0BH80Q=;
 b=Mq4/hlhMVWsjbdNeVSbudMJ2opc69ieKfUBjcivEl0bD545EaMeMF+uOv7Z/UtrEoZ
 qgB2RuwTAe9h5BtTOANZQ2hXM2bqbaozS91IQBdIte9Eko3CA0xRvyFFiFO6VA5lrFww
 NgGJWq7sbuPv1ubPLepsJbYpzuvtkArGhuapufwv7Hs2VlvdwdzBTjJQWHd+jQR3oDOV
 Qzaqenvbv9s3rBv8eotnQVTNkBW4LzWT0bX5eIdx01l89qa8MgIiUdCHvzhtPOcqGREH
 ZSWLI9UqOobwaz3xzqi1YpvilIOnbsI2kDoOv5V2IGPt7j1LsUdCKCfXD9Wi9ZItdmau
 wHfg==
X-Gm-Message-State: APt69E2+ZCLt+51MX3nK4JhLMxEF641Pqjr3U/wW/uQXPZRvGwBhKVpa
 5G2RYVPeFO2DFS64rHBFDNq2g+SuEUzt0QytWACKUHw6
X-Google-Smtp-Source: ADUXVKJcuV+zfSstn1TKBCd7/ZnniLwLVMUoSLhoK7AsysunmvVreTYVVBcmDfAPEtKAN5JcDL1JcVyvvU+jh5XFGvw=
X-Received: by 2002:a6b:1902:: with SMTP id 2-v6mr5623804ioz.304.1528472754060; 
 Fri, 08 Jun 2018 08:45:54 -0700 (PDT)
MIME-Version: 1.0
From: Michael Zimmermann <sigmaepsilon92@gmail.com>
Date: Fri, 8 Jun 2018 17:45:42 +0200
Message-ID: <CAN9vWDL+ZQfn1a1Cisx0u9-R2qUqnQa2TbbEZw+jCa2Y1eYF-Q@mail.gmail.com>
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Yonghong Zhu <yonghong.zhu@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: unknown section type handling in ElfConvert
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jun 2018 15:45:55 -0000
Content-Type: text/plain; charset="UTF-8"

ElfConvert iterates over the section headers and handles the following
section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0

the default case looks like this:
//
//  Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section
into Coff file", mInImageName, (unsigned)Shdr->sh_type);

The comment kinda conflicts with the debug message. Is not copying
unknown sections a bug?
I guess this could lead to problems if a module would ever rely on
non-standard sections being available.

Thanks
Michael