* unknown section type handling in ElfConvert
@ 2018-06-08 15:45 Michael Zimmermann
2018-06-22 6:05 ` Zhu, Yonghong
0 siblings, 1 reply; 2+ messages in thread
From: Michael Zimmermann @ 2018-06-08 15:45 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Yonghong Zhu, Liming Gao
ElfConvert iterates over the section headers and handles the following
section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0
the default case looks like this:
//
// Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section
into Coff file", mInImageName, (unsigned)Shdr->sh_type);
The comment kinda conflicts with the debug message. Is not copying
unknown sections a bug?
I guess this could lead to problems if a module would ever rely on
non-standard sections being available.
Thanks
Michael
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: unknown section type handling in ElfConvert
2018-06-08 15:45 unknown section type handling in ElfConvert Michael Zimmermann
@ 2018-06-22 6:05 ` Zhu, Yonghong
0 siblings, 0 replies; 2+ messages in thread
From: Zhu, Yonghong @ 2018-06-22 6:05 UTC (permalink / raw)
To: Michael Zimmermann, edk2-devel-01; +Cc: Gao, Liming, Zhu, Yonghong
Hi Michael,
We can update the VerboseMsg to same with the comment. We don't want to copy the unknown section.
Best Regards,
Zhu Yonghong
-----Original Message-----
From: Michael Zimmermann [mailto:sigmaepsilon92@gmail.com]
Sent: Friday, June 08, 2018 11:46 PM
To: edk2-devel-01 <edk2-devel@lists.01.org>
Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2] unknown section type handling in ElfConvert
ElfConvert iterates over the section headers and handles the following section types:
SHT_PROGBITS: Copy
SHT_NOBITS: memset to 0
the default case looks like this:
//
// Ignore for unkown section type.
//
VerboseMsg ("%s unknown section type %x. We directly copy this section into Coff file", mInImageName, (unsigned)Shdr->sh_type);
The comment kinda conflicts with the debug message. Is not copying unknown sections a bug?
I guess this could lead to problems if a module would ever rely on non-standard sections being available.
Thanks
Michael
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-22 6:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-08 15:45 unknown section type handling in ElfConvert Michael Zimmermann
2018-06-22 6:05 ` Zhu, Yonghong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox