From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-x235.google.com (mail-lf0-x235.google.com [IPv6:2a00:1450:4010:c07::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AFEFD1A1E20 for ; Mon, 17 Oct 2016 00:24:57 -0700 (PDT) Received: by mail-lf0-x235.google.com with SMTP id b81so270967841lfe.1 for ; Mon, 17 Oct 2016 00:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NxlyI/os16dmA1TKzR1zNR0TaH3pPRPvZV8C8LOwcyw=; b=zggUJUgaAMo6BL5hN0PHfFJdoKqsT6EmpP5mRmUZMVktMVI3a21nR8oMyK28CtOZCl mNtZJXVkrqjUm7NPGU9Roe52QHD28y238mzj5qNF+mHs0OEMS7wklqNGA5oGGUqZowSw NJydAP7vHyk88hwFFpABd16k809ePN8Pzz1CDkQWs0Ih5KLhSsvA96IfMGl7hxMaOluU yraSk3GkE8r1ZyQ2fMXftUcViaw0959YYxoUFwANTabfOw1ACIUFAcvKS6bkHWOAd+sq rW0WT03A71QI45ZZ23ciwrApE3tQUDK3e5/L43buhej+6Ngp3y6WcilpQOTd5Vsw7jjK WYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NxlyI/os16dmA1TKzR1zNR0TaH3pPRPvZV8C8LOwcyw=; b=GUCXuhDFN/k7nLmXG91OY6abk4xvBspBwZHUSJTPiKCTWLelusq5Y2zQCCPxX2sOmL OEyUSx0bc0Yljyx+bdWfWlimaMeNUsa6virZT9N7ZDkcAFAIJIybGvqoaNw96t2bJlaQ If0knemTK0vqrQAppvmSLPhi//8kmUvIoQ2oUd4wIAVfxMaFiGJJ0P6MAnIS2PvfsdRF GZcsd/ssK4E2Wg9+9vX8SjZDB4ROr4OOEerdUznaGsrSfXodnMKSZHK/zA7eL6BGd9k3 G8pTQEchyBHU3KeNtM8eNo1WOqgoAu0gdhDiSdUq2FY21NT+S5N8TkpKeOR8VOKnz6zn tqcg== X-Gm-Message-State: AA6/9RmAk655ISdRON8YklWzS5aVWr3LmE8ATWJg1/F/SGyEjtwFidm2/1G9VHgUwGNRZCxp1TUo/dqxRonhUA== X-Received: by 10.28.5.207 with SMTP id 198mr7971652wmf.22.1476689095477; Mon, 17 Oct 2016 00:24:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.65.135 with HTTP; Mon, 17 Oct 2016 00:24:54 -0700 (PDT) In-Reply-To: References: <1476595420-12566-1-git-send-email-vladimir.olovyannikov@broadcom.com> <40b80588-1bb4-e5f2-439c-97a405c873d3@redhat.com> From: Michael Zimmermann Date: Mon, 17 Oct 2016 09:24:54 +0200 Message-ID: To: Vladimir Olovyannikov Cc: Laszlo Ersek , Jaben Carsey , "Ni, Ruiyu" , "edk2-devel@lists.01.org" X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] GPT Shell Application/Library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2016 07:24:58 -0000 Content-Type: text/plain; charset=UTF-8 Hi, wouldn't it be better to make a generic gpt parsing library which is independent of the shell so both the shell and PartitionDxe can use it? It may also be useful for other applications which need additional information like the gpt partition names. Thanks Michael On Mon, Oct 17, 2016 at 8:49 AM, Vladimir Olovyannikov < vladimir.olovyannikov@broadcom.com> wrote: > Thank you Laszlo, > > Sorry, I missed the fields; it is my first contribution, I will add the > required lines, review the source according to your comments and will > resubmit the patch. > So do you think the command should be _gpt instead of gpt? I was following > TFTP and SF commands as a template. > > Thank you, > Vladimir > > On Oct 16, 2016 1:05 PM, "Laszlo Ersek" wrote: > > > > On 10/16/16 07:23, Vladimir Olovyannikov wrote: > > > This allows managing (create, delete, modify, fat format) of GPT > > > partitions from within UEFI Shell. > > > Syntax: > > > gpt [device_mapped_name] [parameters...] > > > See usage examples in the .uni file > > > --- > > > .../Library/UefiShellGptCommandLib/FatFormat.c | 611 +++++++ > > > .../Library/UefiShellGptCommandLib/FatFormat.h | 111 ++ > > > .../Library/UefiShellGptCommandLib/GptWorker.c | 1902 > ++++++++++++++++++++ > > > .../Library/UefiShellGptCommandLib/GptWorker.h | 186 ++ > > > .../UefiShellGptCommandLib.c | 1135 ++++++++++++ > > > .../UefiShellGptCommandLib.inf | 79 + > > > .../UefiShellGptCommandLib.uni | 117 ++ > > > ShellPkg/ShellPkg.dec | 1 + > > > ShellPkg/ShellPkg.dsc | 4 + > > > 9 files changed, 4146 insertions(+) > > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/ > FatFormat.c > > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/ > FatFormat.h > > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/ > GptWorker.c > > > create mode 100644 ShellPkg/Library/UefiShellGptCommandLib/ > GptWorker.h > > > create mode 100644 > ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.c > > > create mode 100644 > ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.inf > > > create mode 100644 > ShellPkg/Library/UefiShellGptCommandLib/UefiShellGptCommandLib.uni > > > > This looks like a supremely welcome, long-awaited addition (latest > > request: > > ), > > but it really needs your Signed-off-by, and the Contributed-under line > > above it: > > > > ShellPkg/Contributions.txt > > > > I would also suggest (simply based on what I've seen elsewhere in edk2) > > to keep the copyright notices tightly collected in the file headings. > > > > Someone will have to go over all the licenses too -- does the "Marvell > > BSD License Option" for example correspond to the 3-clause BSDL? > > > > On the technical side, I believe that as long as a shell command (or a > > command option) is not standardized (in the shell spec), it usually > > starts with an underscore (_), so as to prevent future name collisions. > > (I could be wrong about this -- I now recall the TFTP command, which is > > also not in the 2.2 spec.) > > > > Just my two cents. > > > > Thanks > > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >