From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web12.2174.1626889368182509710 for ; Wed, 21 Jul 2021 10:42:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20161025 header.b=Ql0HgblO; spf=pass (domain: google.com, ip: 209.85.208.180, mailfrom: chengchieh@google.com) Received: by mail-lj1-f180.google.com with SMTP id x24so314676ljm.4 for ; Wed, 21 Jul 2021 10:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LwgY4PZBdWhHKRJBDp8ZrMruCSEE9EXuzLBYfK8iEbc=; b=Ql0HgblOdyDY5DhTF81ZjPZgkzKGvbcG0Gc3p4mfZ2HhBLcJ3GCTEL1gJehdXywhaf vVpktFix+TSd9Wv7S5+W4DFu5pvKMifIdL9Tscik3hPr4mQ8askSrLz8wABxWeKjMn97 P6kAFRfvVRfyTeasyvgRxkXFCU8D9sUCyTPyQBCTHK/zXK7zRQmadJ0Ui/eDWGUEFDUz 9/CYpOzKYy3k91B0kuAt8Wywffy/5CQBlvejkw+zjXRGy4gBqRXGXyuR1CNn8cw1WAiD XNBgtwmyjwnc8HcNWtto+h+5yw3RZg/jD4alZHo0LKEfBGzQtOMz/F+O7YLDk0ryHdXn ulFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LwgY4PZBdWhHKRJBDp8ZrMruCSEE9EXuzLBYfK8iEbc=; b=XaJlCQQ75R05EX9rVjB2513mlas9EDCumD5e0yGRgXKmfFjE2OMFaAv6Qen/ur5Ps1 TPNN0FbBP+eHkiq/uYwrlhh8GxAjTeB/TdocwK1mPpj+OgCCHuYY3zr2dZ564ZR0/uvJ UB7rLuLM2WVjC4EnrctnHWmBV8jN71dJfb3af1Ae162IsSGsy2dEF6RCxR7MqeajAeRf sfHTQpGLHhtD/xgZowk+dyTFMk8QGAOmWrNh7uqtLOXqSkd9Zp8ak9sZkgVYfnzuQqSQ EPfug3IqtG0joerqIO4GkclUSrhlfTcboX9HvnJcLBoWXyfi8Q6VTSEJY6feYaRjYKkU jvCA== X-Gm-Message-State: AOAM531uWs7UM3ovnbUHOqs0sxrTlQGZNgei6Yjt9yT+GhKSWLvbewfU YnGUIbo3z+OAK4QfZbzCyBj19UiknllrzXIFU4MDEA== X-Google-Smtp-Source: ABdhPJzefk5ZY/1TlUDVJmh6+cdiYqroLG0ZDhRmJfuGS/YRAxwRBuISaXfKsZWlYUhg5+6c/qZ5N9yXKhDzSVzpOpk= X-Received: by 2002:a2e:b556:: with SMTP id a22mr32183005ljn.142.1626889366268; Wed, 21 Jul 2021 10:42:46 -0700 (PDT) MIME-Version: 1.0 References: <20210721132328.1415485-1-chengchieh@google.com> <20210721132328.1415485-6-chengchieh@google.com> In-Reply-To: From: Cheng-Chieh Huang Date: Thu, 22 Jul 2021 01:42:34 +0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation To: "Kinney, Michael D" Cc: devel@edk2.groups.io Content-Type: multipart/alternative; boundary="000000000000c4b5b405c7a5b26a" --000000000000c4b5b405c7a5b26a Content-Type: text/plain; charset="UTF-8" Yes, we can. I will drop this patch for this uefipayload batch and send another one for support DISABLE_GCC_MMX_SSE in tools_de.txt. -- Cheng-Chieh On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D wrote: > Are those flags needed for all packages that build with GCC? > > Should this be moved into tools_def.txt? > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Cheng-Chieh Huang via groups.io > > Sent: Wednesday, July 21, 2021 6:23 AM > > To: devel@edk2.groups.io > > Cc: Cheng-Chieh Huang > > Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE > to avoid generating floating points operation > > > > This will allow we compile payload using gcc8 > > > > Signed-off-by: Cheng-Chieh Huang > > --- > > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > > index 8aa5f18cd35c..fa41c5a24af5 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > > @@ -30,6 +30,8 @@ [Defines] > > DEFINE PS2_KEYBOARD_ENABLE = FALSE > > DEFINE UNIVERSAL_PAYLOAD = FALSE > > > > + DEFINE DISABLE_MMX_SSE = FALSE > > + > > # > > # SBL: UEFI payload for Slim Bootloader > > # COREBOOT: UEFI payload for coreboot > > @@ -96,6 +98,9 @@ [BuildOptions] > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > !if $(BOOTLOADER) == "LINUXBOOT" > > *_*_*_CC_FLAGS = -D LINUXBOOT_PAYLOAD > > +!endif > > +!if $(DISABLE_MMX_SSE) > > + *_*_*_CC_FLAGS = -mno-mmx -mno-sse > > !endif > > GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > > -- > > 2.32.0.402.g57bb445576-goog > > > > > > > > > > > > --000000000000c4b5b405c7a5b26a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, we can. I will drop this patch for this=C2=A0 u= efipayload batch and send another one for support DISABLE_GCC_MMX_SSE in to= ols_de.txt.

--
Cheng-Chieh=C2=A0

On Thu, Jul 22, 2021, 12:35 AM Ki= nney, Michael D <michael.d= .kinney@intel.com> wrote:
Ar= e those flags needed for all packages that build with GCC?

Should this be moved into tools_def.txt?

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io>= ; On Behalf Of Cheng-Chieh Huang via groups.io
> Sent: Wednesday, July 21, 2021 6:23 AM
> To: devel@edk2.groups.io
> Cc: Cheng-Chieh Huang <chengchieh@google.com>
> Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_= SSE to avoid generating floating points operation
>
> This will allow we compile payload using gcc8
>
> Signed-off-by: Cheng-Chieh Huang <chengchieh@google.com>=
> ---
>=C2=A0 UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++
>=C2=A0 1 file changed, 5 insertions(+)
>
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiP= ayloadPkg.dsc
> index 8aa5f18cd35c..fa41c5a24af5 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -30,6 +30,8 @@ [Defines]
>=C2=A0 =C2=A0 DEFINE PS2_KEYBOARD_ENABLE=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =3D FALSE
>=C2=A0 =C2=A0 DEFINE UNIVERSAL_PAYLOAD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =3D FALSE
>
> +=C2=A0 DEFINE DISABLE_MMX_SSE=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =3D FALSE
> +
>=C2=A0 =C2=A0 #
>=C2=A0 =C2=A0 # SBL:=C2=A0 =C2=A0 =C2=A0 UEFI payload for Slim Bootloa= der
>=C2=A0 =C2=A0 # COREBOOT: UEFI payload for coreboot
> @@ -96,6 +98,9 @@ [BuildOptions]
>=C2=A0 =C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = = =C2=A0 =C2=A0 =C2=A0=3D -D DISABLE_NEW_DEPRECATED_INTERFACES
>=C2=A0 !if $(BOOTLOADER) =3D=3D "LINUXBOOT"
>=C2=A0 =C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = = =C2=A0 =C2=A0 =C2=A0=3D -D LINUXBOOT_PAYLOAD
> +!endif
> +!if $(DISABLE_MMX_SSE)
> +=C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0=3D -mno-mmx -mno-sse
>=C2=A0 !endif
>=C2=A0 =C2=A0 GCC:*_UNIXGCC_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0=3D -= DMDEPKG_NDEBUG
>=C2=A0 =C2=A0 GCC:RELEASE_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0=3D -= DMDEPKG_NDEBUG
> --
> 2.32.0.402.g57bb445576-goog
>
>
>
>
>

--000000000000c4b5b405c7a5b26a--