From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mx.groups.io with SMTP id smtpd.web08.2817.1626921314895687923 for ; Wed, 21 Jul 2021 19:35:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@google.com header.s=20161025 header.b=VZkiQ8i4; spf=pass (domain: google.com, ip: 209.85.167.47, mailfrom: chengchieh@google.com) Received: by mail-lf1-f47.google.com with SMTP id f30so6188268lfv.10 for ; Wed, 21 Jul 2021 19:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pMrGZb7vtLNKUnBewlNFgNbUAA8MmMFeb+jJAKd/k/g=; b=VZkiQ8i4Uf+EkjYu25T66j/FJRJHD5tOKdCJZu2wIlE6abp8Q0veQRYnHPTAwFV+Fr jbRickc6bodgJALxPpwFuR2b0HngKOts4dTWJjtxCqNddSHp2tUnTi9vxAZJoJHsEFHm 0Y4b+wioNUfd+l2dZbIWT4w3XqaXB03oahfpnktiXFC1aTdfJQmBHXrzBnJTPSfh+5FZ 0Ro6hZf0rk9lJedSBD9W3qyoWWe9dsXToSQRE9dbsEP6w1PIV9W3WpalKCdewEgzkW9C ply5caydV8El4tNNuFvUQf8UqGHjkNSq+kpfhIAuTzWBhsB+1ScDxIus3FQDjpGXEzFy IBvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pMrGZb7vtLNKUnBewlNFgNbUAA8MmMFeb+jJAKd/k/g=; b=Kjlw8vY5DvqNDop0hSooWiD6prwIv0jdcrCrmzJIDOsXU4C0V7QGQP/GFRKdSepN3h jpuVONYraXgCd/UaUUMbAUO2nsu6V8rD8FmK8f7YE62VfyLQG5QgxX2Rq13j2/DqDoxc 0P/jtf+N4RvzPbNltLIKz6ezma2E9YHTfqQXB7r8bSq3ZM1VnpzlZruha9+zUv8+61IK NYkGWIq58m/aXlMBwKr57BQt8Rtiwpp2c80Qe9mBsim2BTFWOaPo5dOyjjfBYMChWrnX SMnwSTfU8ENYtA9ESCBprhEJ0abtjNoevhSwskgcrnG9eb6VWmZ+A9EUJKRjiSs6Yh35 yhGA== X-Gm-Message-State: AOAM533C0KngbtwC5BbmjnVlNomYGT6d0/zTDdTd/q8dnujYV5RMDTUQ MQ3FbpXC4rDS3F+hKhmOqgHXGXo2oYM3wy5sdw5WCg== X-Google-Smtp-Source: ABdhPJyRdJl9rf6doALQcZ2XZ8p+xFqQQmOr6TSAmqWtdKl1oAHadwkeufS8QoamQfMU/arkM6lAQXBBxwx7tZCjjqI= X-Received: by 2002:a05:6512:ac7:: with SMTP id n7mr13831499lfu.564.1626921312775; Wed, 21 Jul 2021 19:35:12 -0700 (PDT) MIME-Version: 1.0 References: <20210721132328.1415485-1-chengchieh@google.com> <20210721132328.1415485-6-chengchieh@google.com> <000301d77e98$e1c0d9c0$a5428d40$@byosoft.com.cn> In-Reply-To: <000301d77e98$e1c0d9c0$a5428d40$@byosoft.com.cn> From: Cheng-Chieh Huang Date: Thu, 22 Jul 2021 10:35:01 +0800 Message-ID: Subject: Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating floating points operation To: gaoliming Cc: devel@edk2.groups.io, "Kinney, Michael D" Content-Type: multipart/alternative; boundary="000000000000ed9a5205c7ad22b0" --000000000000ed9a5205c7ad22b0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I mean, I will submit a patch to support DISABLE_GCC_MMX_SSE in tools_def. What do you think? -- Cheng-Chieh On Thu, Jul 22, 2021 at 9:28 AM gaoliming wrote= : > Tools_def.txt doesn=E2=80=99t support build flag DISABLE_GCC_MMX_SSE. If= this > flag is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse > option will be the default GCC options. That means all platforms will ap= ply > them. > > > > Thanks > > Liming > > *=E5=8F=91=E4=BB=B6=E4=BA=BA:* devel@edk2.groups.io *=E4=BB=A3=E8=A1=A8 *Cheng-Chieh Huang > via groups.io > *=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4:* 2021=E5=B9=B47=E6=9C=8822=E6=97= =A5 1:43 > *=E6=94=B6=E4=BB=B6=E4=BA=BA:* Kinney, Michael D > *=E6=8A=84=E9=80=81:* devel@edk2.groups.io > *=E4=B8=BB=E9=A2=98:* Re: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Ad= d DISABLE_MMX_SSE > to avoid generating floating points operation > > > > Yes, we can. I will drop this patch for this uefipayload batch and send > another one for support DISABLE_GCC_MMX_SSE in tools_de.txt. > > > > -- > > Cheng-Chieh > > On Thu, Jul 22, 2021, 12:35 AM Kinney, Michael D < > michael.d.kinney@intel.com> wrote: > > Are those flags needed for all packages that build with GCC? > > Should this be moved into tools_def.txt? > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Cheng-Chieh Huang via groups.io > > Sent: Wednesday, July 21, 2021 6:23 AM > > To: devel@edk2.groups.io > > Cc: Cheng-Chieh Huang > > Subject: [edk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_S= SE > to avoid generating floating points operation > > > > This will allow we compile payload using gcc8 > > > > Signed-off-by: Cheng-Chieh Huang > > --- > > UefiPayloadPkg/UefiPayloadPkg.dsc | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > > index 8aa5f18cd35c..fa41c5a24af5 100644 > > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > > @@ -30,6 +30,8 @@ [Defines] > > DEFINE PS2_KEYBOARD_ENABLE =3D FALSE > > DEFINE UNIVERSAL_PAYLOAD =3D FALSE > > > > + DEFINE DISABLE_MMX_SSE =3D FALSE > > + > > # > > # SBL: UEFI payload for Slim Bootloader > > # COREBOOT: UEFI payload for coreboot > > @@ -96,6 +98,9 @@ [BuildOptions] > > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERF= ACES > > !if $(BOOTLOADER) =3D=3D "LINUXBOOT" > > *_*_*_CC_FLAGS =3D -D LINUXBOOT_PAYLOAD > > +!endif > > +!if $(DISABLE_MMX_SSE) > > + *_*_*_CC_FLAGS =3D -mno-mmx -mno-sse > > !endif > > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > > GCC:RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > > -- > > 2.32.0.402.g57bb445576-goog > > > > > > > > > > > >=20 > --000000000000ed9a5205c7ad22b0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I mean, I will submit a patch to support DISABLE_GCC_MMX_S= SE in tools_def. What do you think?

--
Cheng-C= hieh

On Thu, Jul 22, 2021 at 9:28 AM gaoliming <gaoliming@byosoft.com.cn> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">

Tools_def.txt doesn=E2=80=99t supp= ort build flag DISABLE_GCC_MMX_SSE. If this fla= g is moved into BaseTools\Conf\tools_def.template, -mno-mmx -mno-sse option= will be the default GCC options. That means all platforms will apply them.=

=C2=A0

Thank= s

Limin= g

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2= .groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 Cheng-Chieh Hua= ng via groups.io
=E5=8F= =91=E9=80=81=E6=97=B6=E9=97=B4: 2= 021=E5= = =B9=B47=E6=9C=8822= = =E6=97=A5 1:43
=E6=94=B6=E4=BB=B6=E4=BA= =BA: Kinney, Michael = D <micha= el.d.kinney@intel.com>
=E6=8A=84=E9=80=81: devel@edk2.groups.io
=E4=B8=BB=E9= =A2=98: Re: [edk2-dev= el] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid generating = floating points operation

=C2=A0

<= div>

Yes, we can. I will drop th= is patch for this=C2=A0 uefipayload batch and send another one for support = DISABLE_GCC_MMX_SSE in tools_de.txt.

=C2=A0

--=

Cheng-Chieh=C2=A0

On Thu, Jul 22, 2021, 12:35 AM Kinney,= Michael D <michael.d.kinney@intel.com> wrote:

Are those flags needed for all packages that build wi= th GCC?

Should this be moved into tools_def.txt?

Mike

= > -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Be= half Of Cheng-Chieh Huang via groups.io
> Sent: Wednesday, July 21, 2021 6:23 AM
> To: = devel@edk2.groups= .io
> Cc: Cheng-Chieh Huang <chengchieh@google.com>
> Subject: [e= dk2-devel] [PATCH v1 5/6] UefiPayloadPkg: Add DISABLE_MMX_SSE to avoid gene= rating floating points operation
>
> This will allow we compil= e payload using gcc8
>
> Signed-off-by: Cheng-Chieh Huang <= chengchieh@googl= e.com>
> ---
>=C2=A0 UefiPayloadPkg/UefiPayloadPkg.dsc |= 5 +++++
>=C2=A0 1 file changed, 5 insertions(+)
>
> dif= f --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg= .dsc
> index 8aa5f18cd35c..fa41c5a24af5 100644
> --- a/UefiPayl= oadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc> @@ -30,6 +30,8 @@ [Defines]
>=C2=A0 =C2=A0 DEFINE PS2_KEYBOARD= _ENABLE=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D FALSE
>=C2=A0 =C2=A0 DE= FINE UNIVERSAL_PAYLOAD=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D FALSE>
> +=C2=A0 DEFINE DISABLE_MMX_SSE=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =3D FALSE
> +
>=C2=A0 =C2=A0 #
>=C2= = =A0 =C2=A0 # SBL:=C2=A0 =C2=A0 =C2=A0 UEFI payload for Slim Bootloader
= >=C2=A0 =C2=A0 # COREBOOT: UEFI payload for coreboot
> @@ -96,6 +9= 8,9 @@ [BuildOptions]
>=C2=A0 =C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D -D DISABLE_NEW_DEPRECATED= _INTERFACES
>=C2=A0 !if $(BOOTLOADER) =3D=3D "LINUXBOOT">=C2=A0 =C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = = =C2=A0 =C2=A0 =C2=A0=3D -D LINUXBOOT_PAYLOAD
> +!endif
> +!if = $(DISABLE_MMX_SSE)
> +=C2=A0 *_*_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=3D -mno-mmx -mno-sse
>=C2=A0 = !endif
>=C2=A0 =C2=A0 GCC:*_UNIXGCC_*_CC_FLAGS=C2=A0 =C2=A0 =C2=A0 = =C2=A0=3D -DMDEPKG_NDEBUG
>=C2=A0 =C2=A0 GCC:RELEASE_*_*_CC_FLAGS=C2= = =A0 =C2=A0 =C2=A0 =C2=A0=3D -DMDEPKG_NDEBUG
> --
> 2.32.0.402.= g57bb445576-goog
>
>
>
>
> =

<= u>

--000000000000ed9a5205c7ad22b0--