From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195])
 by mx.groups.io with SMTP id smtpd.web12.381.1588115060236770938
 for <devel@edk2.groups.io>;
 Tue, 28 Apr 2020 16:04:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@gmail.com header.s=20161025 header.b=LIxY+K6M;
 spf=pass (domain: gmail.com, ip: 209.85.219.195, mailfrom: andrey.warkentin@gmail.com)
Received: by mail-yb1-f195.google.com with SMTP id o198so233481ybg.10
        for <devel@edk2.groups.io>; Tue, 28 Apr 2020 16:04:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to;
        bh=YjuqRW1ZS1cBF0U5/M0rVNEiRap2cNWPGNUvW/TjZnc=;
        b=LIxY+K6McCs9HYGn0Ko8yZ5PEdllC8TnrGm22qK4F+mkKdoPmL/ETKMGJB21aUXD+p
         W6YBBgVUCKK5CW895Hykx/SrJJuO54SeSf/AcCiFFVdgiKgOjI2byJdqcLABVzE6v9Kt
         eMa93bU2ZjVmWUWtu+h4CaPO+66KtXRe7bwf1ka36CAqPFqqBOo40O3iil45KrOwtFhK
         7YriFEWLKak1DLMq0YZf6yZxX+Nqml7sGY8XPlRiXh5mgzPXv+a7tQJXbzho3OCGUjA3
         JjO8IHIibyAfUN4yFC+vKLONIV3+gAgFKuXXOeyL0BSCsuahTxbNF2si/JGg/yQVWMnX
         /xcw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to;
        bh=YjuqRW1ZS1cBF0U5/M0rVNEiRap2cNWPGNUvW/TjZnc=;
        b=f+Dj93SZG6usz/batmcEEdeT/C8oSxfwq615bLvCGOo13q7HSgi57hVZFZk7BqNhuG
         U1RnsYu3Xtu2qDVJwlaKE8mkRq9t5z/tGYvCb1DOF1AbYDxmfTnIncPOVWbPANBD2hlw
         ZDvvq4NdHLVbKVhRGGjUjuA3iWn+mHH4x/ZhVmam458XBhWNWkbHsFtTa60uMJSg0F13
         HY7Iu3MtaTGqsrr9XwkCjd5ajjVnaaH00Dayq8GH2IFHMMGuF2b+90VXPLPtIVrCCW6a
         Dr1He1qqBsu5TG3vrwU7HOXRmuRAYqJAnuLhTzE0HNoLGZb8rlC8WXcNFU/IrlD1pk3I
         VJBQ==
X-Gm-Message-State: AGi0PuZxsd/wRHNYmKePFoW2CuOk8jDwCQnS8u7t1Hd1tPLj3WuwqhoS
	OFEfPSdY2KHRxl4Ztg7H3dv1jO0N+GY5hTqCK/XAOZ1J
X-Google-Smtp-Source: APiQypK2VHfYIkdEU1VcT0s53O9HrRHiXCEuj1uI1jbRhengajeSUBK8TRJpsYQFt5y0G5ZoToScfdkKjuK7PucRh94=
X-Received: by 2002:a25:86c6:: with SMTP id y6mr46688411ybm.311.1588115059321;
 Tue, 28 Apr 2020 16:04:19 -0700 (PDT)
MIME-Version: 1.0
References: <20200428012115.24341-1-driver1998@foxmail.com>
In-Reply-To: <20200428012115.24341-1-driver1998@foxmail.com>
From: "Andrei Warkentin" <andrey.warkentin@gmail.com>
Date: Tue, 28 Apr 2020 18:04:08 -0500
Message-ID: <CANz0V+4Qdiiw+yKzbVvB0TJzmL6i_z+EXyhp0Cn-WJG_FAxYxw@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
To: devel@edk2.groups.io, driver1998@foxmail.com
Content-Type: multipart/alternative; boundary="000000000000f92e3c05a461d9f0"

--000000000000f92e3c05a461d9f0
Content-Type: text/plain; charset="UTF-8"

Reviewed-by: Andrei Warkentin <andrey.warkentin@gmail.com>

On Tue, Apr 28, 2020 at 1:34 AM GH Cao <driver1998@foxmail.com> wrote:

> The original comment incorrectly named the PWM controller as Power
> Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
>  Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
>  #ifndef __BCM2836_PWM_H__
>  #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
>  #define BCM2836_PWM_DMA_OFFSET                              0x00007B00
>  #define BCM2836_PWM_DMA_BASE_ADDRESS
> (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
> --
> 2.17.1
>
>
> 
>
>

-- 
A

--000000000000f92e3c05a461d9f0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Reviewed-by: Andrei Warkentin &lt;<a href=3D"mailto:andrey=
.warkentin@gmail.com">andrey.warkentin@gmail.com</a>&gt;</div><br><div clas=
s=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 28, 202=
0 at 1:34 AM GH Cao &lt;<a href=3D"mailto:driver1998@foxmail.com">driver199=
8@foxmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddi=
ng-left:1ex">The original comment incorrectly named the PWM controller as P=
ower Management<br>
Contoller, this commit fixes it.<br>
<br>
Signed-off-by: GH Cao &lt;<a href=3D"mailto:driver1998@foxmail.com" target=
=
=3D"_blank">driver1998@foxmail.com</a>&gt;<br>
---<br>
=C2=A0Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +=
-<br>
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.=
h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h<br>
index e2581b8..2d7da75 100644<br>
--- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h<br>
+++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h<br>
@@ -11,7 +11,7 @@<br>
=C2=A0#ifndef __BCM2836_PWM_H__<br>
=C2=A0#define __BCM2836_PWM_H__<br>
<br>
-/* Power Management constants */<br>
+/* PWM controller constants */<br>
<br>
=C2=A0#define BCM2836_PWM_DMA_OFFSET=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x00007=
B00<br>
=C2=A0#define BCM2836_PWM_DMA_BASE_ADDRESS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (BCM2836_SOC_REGISTER=
S + BCM2836_PWM_DMA_OFFSET)<br>
-- <br>
2.17.1<br>
<br>
<br>
<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr=
" class=3D"gmail_signature">A</div>

--000000000000f92e3c05a461d9f0--