From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) by mx.groups.io with SMTP id smtpd.web11.1631.1588191294729189088 for ; Wed, 29 Apr 2020 13:14:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b7hmByqW; spf=pass (domain: gmail.com, ip: 209.85.219.193, mailfrom: andrey.warkentin@gmail.com) Received: by mail-yb1-f193.google.com with SMTP id l5so1953876ybf.5 for ; Wed, 29 Apr 2020 13:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=A1LA/Y/fUSWKNcwGsHU2ZofRGHhuDO0y1WLSyI2CYy4=; b=b7hmByqWGt7bFnx3/h94h9v8ncefJXCR5DLmxIByP3W1ecqMCZDy2S5tuK+Kiz/jNG 5Q+ygv20hKwrMQaL1m1QLpoTv2K9jxk5y5nwqoKz/207JpI//AfkdpHPIy4WLS1ptEhx OGSlOC2zlUQN1Rjr4VKzjG2q0BSpoOANCAMPuEJ4FjZbEcWAKnZZnHPTpP3EIAJliKap cspqoWFCVjBrVtIauFpWn0u8UiGecxPVqSkKJQ5LNRlvE94l0pIXRCm6hfMMEO5gNI7u GsYqtIrhqd1K/XWNu9d7ckWvNpX6OnB7KP4gy1QWi7MDWkrWeSQfzSswVhVnU5VBqOjD EMSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=A1LA/Y/fUSWKNcwGsHU2ZofRGHhuDO0y1WLSyI2CYy4=; b=oxprz+kWirdr+KDTLFJCGo0si4iGwR+Q2J4znQbt84AbwMF5xh3NaEgxjrrDXUpYP2 zPwahBBUHPVyxzpKzLQayP7y23nZL092Y4P6KQKyphxSvJGkvyoA/G3v6Ig+sJGAigzC HkHnxHT6abs3c2Wjf49X+L2NtN4blozazZkofzzOjKHmT7zp1EVPWZvl6Cx3NdeP5Xk7 kg4PgdDb09d/WAKuC7cEoRCoJ4UmNf3d+p3bfX1CaCDDv3RRgwiT8ekhkKjta9bvBkv7 itHMm9EJTOEUkFyHzPv7LsgpkHZ+tFnnQv/Xn+Ku8cmVaKumnLEeq79SSWBmjvot51BV azrQ== X-Gm-Message-State: AGi0PubTg7Pjnn4+RjKlqfVD3vs0oODn+zaavw9o0x/Kj2k/Q8ibhBfv cVOQ3aGQbVg5+0JGykSkSkAomhHvvS14/kNyQNakjqn23Bc= X-Google-Smtp-Source: APiQypLJB2n82MeQlys9r9M29Kp0aaKcMOKy0PXjbQbUDKvCvfTWtbuFYemeekU8VQLnS99IRTK7846ehEnbSdlG82c= X-Received: by 2002:a25:5181:: with SMTP id f123mr55668447ybb.285.1588191293640; Wed, 29 Apr 2020 13:14:53 -0700 (PDT) MIME-Version: 1.0 References: <20200429163616.5951-1-leif@nuviainc.com> In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com> From: "Andrei Warkentin" Date: Wed, 29 Apr 2020 15:14:42 -0500 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/3] BaseTools,EmbeddedPkg,Maintainers.txt: Obsolete some drivers To: devel@edk2.groups.io, leif@nuviainc.com Content-Type: multipart/alternative; boundary="000000000000e4967405a4739951" --000000000000e4967405a4739951 Content-Type: text/plain; charset="UTF-8" Btw, the Raspberry Pi support has its own variant of MmcDxe and SD host drivers... the history behind that is that's the way it was in the original MSFT port circa 2016. When I had rebased that code to 2018 edk2 (still before Pete's work to upstream it here), the edk2 variant had significantly diverged from the MSFT changes, so the MSFT one was taken as is (and further evolved to fix issues around high-speed support). It's still a goal to move away from all of that towards something generic. The Pi has two (sometimes 3) controllers - some are kinda-SDHCI (maybe possible with the Mde stack, if quirked via _SD_MMC_OVERRIDE_PROTOCOL), while the other is completely non-standard. Mde doesn't have a non-SDHCI stack. That remains a gap... A On Wed, Apr 29, 2020 at 11:36 AM Leif Lindholm wrote: > We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which > while it predates the MdeModulePkg SD/(E)MMCsupport is in effect > unmaintained and also duplicates core industry standard definitions. > > Since we now have GetMaintainers.py to parse Maintainers.txt for us, > extend its functionality to warn about less supported code. > > Then as an indication of its unsuitability for reference (or use), set > its Status flag in Maintainers.txt to Obsolete. > > Once this is done, follow up and do the same with the hardware drivers > (not the software ones) still left in EmbeddedPkg/Drivers. They were > added back when not using the UEFI driver model was still cool, or > simply before edk2-platforms existed. > They should move to edk2-platforms, but most of them require some > level of rewriting before that. > > 1/3 adds a warning printout to GetMaintainer.py > > 2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/ > > 3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers > Cc: Andrew Fish > > Cc: Ard Biesheuvel > Cc: Bob Feng > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Michael D Kinney > > Leif Lindholm (3): > BaseTools: add handling for 'S:' flag to GetMaintainer.py > Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete > Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete > > BaseTools/Scripts/GetMaintainer.py | 4 ++++ > Maintainers.txt | 17 +++++++++++++++++ > 2 files changed, 21 insertions(+) > > -- > 2.20.1 > > > > > -- A --000000000000e4967405a4739951 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Btw, the Raspberry Pi support has its own variant of MmcDx= e and SD host drivers... the history behind that is that's the way it w= as in the original MSFT port circa 2016. When I had rebased that code to 20= 18 edk2 (still before Pete's work to upstream=C2=A0it here), the edk2 v= ariant=C2=A0had significantly diverged from the MSFT changes, so the MSFT o= ne was taken as is (and further evolved to fix issues around high-speed sup= port).

It's still a goal to move away from all of th= at towards something generic. The Pi has two (sometimes 3) controllers - so= me are kinda-SDHCI (maybe possible with the Mde stack, if quirked via _SD_M= MC_OVERRIDE_PROTOCOL), while the other is completely non-standard.

Mde doesn't have a non-SDHCI stack. That remains a gap= ...

A

On Wed, Apr 29, 2020 at 11:36 AM Leif L= indholm <leif@nuviainc.com> = wrote:
We keep s= eeing new users (and copies) of EmbeddedPkg:s MmcDxe, which
while it predates the MdeModulePkg SD/(E)MMCsupport is in effect
unmaintained and also duplicates core industry standard definitions.

Since we now have GetMaintainers.py to parse Maintainers.txt for us,
extend its functionality to warn about less supported code.

Then as an indication of its unsuitability for reference (or use), set
its Status flag in Maintainers.txt to Obsolete.

Once this is done, follow up and do the same with the hardware drivers
(not the software ones) still left in EmbeddedPkg/Drivers. They were
added back when not using the UEFI driver model was still cool, or
simply before edk2-platforms existed.
They should move to edk2-platforms, but most of them require some
level of rewriting before that.

1/3 adds a warning printout to GetMaintainer.py

2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/

3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers
Cc: Andrew Fish <a= fish@apple.com>

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>

Leif Lindholm (3):
=C2=A0 BaseTools: add handling for 'S:' flag to GetMaintainer.py =C2=A0 Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete
=C2=A0 Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete

=C2=A0BaseTools/Scripts/GetMaintainer.py |=C2=A0 4 ++++
=C2=A0Maintainers.txt=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 17 +++++++++++++++++
=C2=A02 files changed, 21 insertions(+)

--
2.20.1






--
A
--000000000000e4967405a4739951--