From: Alex James <theracermaster@gmail.com>
To: edk2-devel@lists.01.org
Subject: Re: [PATCH] BaseTools/tools_def XCODE5: Add -Wno-varargs
Date: Thu, 28 Dec 2017 22:39:33 +0000 [thread overview]
Message-ID: <CAOFocVBei+8zfvwfo7K4+a9Renpu7ECAU+ndUo2Nvbo=KGq_rg@mail.gmail.com> (raw)
In-Reply-To: <0e5378adc2462e9b072cb0117ea01a0fa5536cb1.1514483743.git.theracermaster@gmail.com>
Disregard this patch if Zenith432's patch to fix this bug is accepted.
On Thu, Dec 28, 2017 at 12:04 PM Alex James <theracermaster@gmail.com>
wrote:
> Commit 47bfbd7f8069e523798ef973c8eb0abd5c6b0746 ("BaseTools/Conf:
> Support LLVM39 and LLVM40 in CLANG38 toolchain") added -Wno-varargs to
> suppress va_start errors when building MdePkg/UefiLib. Do the same for
> the XCODE5 toolchain to fix building with Xcode 9 as per
> https://bugzilla.tianocore.org/show_bug.cgi?id=741.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alex James <theracermaster@gmail.com>
> ---
> BaseTools/Conf/tools_def.template | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 98ab6dd45e..12278302b3 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -7550,9 +7550,9 @@ RELEASE_XCODE5_IA32_ASM_FLAGS = -arch i386
> *_XCODE5_IA32_NASM_FLAGS = -f macho32
>
>
> - DEBUG_XCODE5_IA32_CC_FLAGS = -arch i386 -c -g -Os -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
> -RELEASE_XCODE5_IA32_CC_FLAGS = -arch i386 -c -Os -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
> - NOOPT_XCODE5_IA32_CC_FLAGS = -arch i386 -c -g -O0 -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
> + DEBUG_XCODE5_IA32_CC_FLAGS = -arch i386 -c -g -Os -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
> +RELEASE_XCODE5_IA32_CC_FLAGS = -arch i386 -c -Os -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
> + NOOPT_XCODE5_IA32_CC_FLAGS = -arch i386 -c -g -O0 -Wall -Werror
> -include AutoGen.h -funsigned-char -fno-stack-protector -fno-builtin
> -fshort-wchar -fasm-blocks -mdynamic-no-pic -mno-implicit-float
> -mms-bitfields -msoft-float -Wno-unused-parameter -Wno-missing-braces
> -Wno-missing-field-initializers -Wno-tautological-compare -Wno-sign-compare
> -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang
> $(PLATFORM_FLAGS)
>
> ##################
> # X64 definitions
> @@ -7569,9 +7569,9 @@ RELEASE_XCODE5_X64_ASM_FLAGS = -arch x86_64
> *_XCODE5_*_PP_FLAGS = -E -x assembler-with-cpp -include
> $(DEST_DIR_DEBUG)/AutoGen.h
> *_XCODE5_*_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE -include
> $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h
>
> - DEBUG_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -g -Os
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
> - NOOPT_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -g -O0
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
> -RELEASE_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -Os
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
> + DEBUG_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -g -Os
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
> + NOOPT_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -g -O0
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
> +RELEASE_XCODE5_X64_CC_FLAGS = -target x86_64-pc-win32-macho -c -Os
> -Wall -Werror -Wextra -include AutoGen.h -funsigned-char
> -fno-ms-extensions -fno-stack-protector -fno-builtin -fshort-wchar
> -mno-implicit-float -mms-bitfields -Wno-unused-parameter
> -Wno-missing-braces -Wno-missing-field-initializers
> -Wno-tautological-compare -Wno-sign-compare -Wno-varargs
> -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang -D
> NO_MSABI_VA_FUNCS $(PLATFORM_FLAGS)
>
>
> ####################################################################################
> #
> --
> 2.15.1
>
>
prev parent reply other threads:[~2017-12-28 22:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 18:04 [PATCH] BaseTools/tools_def XCODE5: Add -Wno-varargs Alex James
2017-12-28 22:39 ` Alex James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOFocVBei+8zfvwfo7K4+a9Renpu7ECAU+ndUo2Nvbo=KGq_rg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox