public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Benjamin Doron" <benjamin.doron00@gmail.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G
Date: Thu, 26 Aug 2021 00:08:35 -0400	[thread overview]
Message-ID: <CAONYkK_zqTLG287CwDt-3kH1BpgZdf8sj1LOphq3OP=j0ad=eA@mail.gmail.com> (raw)
In-Reply-To: <MWHPR1101MB2160A93548A17F8C159C7830CDC79@MWHPR1101MB2160.namprd11.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 23516 bytes --]

Hi Nate,
Thanks for addressing the comment for me with
https://edk2.groups.io/g/devel/message/79830.

Regarding copyrighting: I am not a lawyer and was unaware that a copyright
was necessary. But if it's necessary for legal reasons, very well.

However, I suppose I will need to put my legal name on the copyrights,
which is "Baruch Binyamin Doron." I'll send a patch as a fix-up for this?

Best regards,
Benjamin


On Wed, Aug 25, 2021 at 11:58 PM Desimone, Nathaniel L <
nathaniel.l.desimone@intel.com> wrote:

> Hi Benjamin,
>
> I have sent a separate patch to correct the comment that Michael pointed
> out: https://edk2.groups.io/g/devel/message/79830
>
> For legal reasons I actually have to put "Copyright (c) 2021, Benjamin
> Doran" on the files that are brand new and are not a derivative of an
> existing file.
>
> The reason for this is because in order to apply the BSD+Patent license,
> the code in question must be copyrighted. Without a copyright, the code
> would be considered part of the public domain, making it legally impossible
> to license it. In order for something to be copyrighted, it must be "owned"
> by a legal entity. Since the TianoCore project does not have a non-profit
> foundation representing it, from a legal perspective TianoCore does not
> actually exist as a legal entity. We workaround this by having the
> contributors to TianoCore copyright the code that they work on. This is
> only a problem for the files which Intel cannot claim a copyright on since
> we did no work there.
>
> Accordingly, I have placed "Copyright (c) 2021, Benjamin Doran" into the
> header of the following files:
>
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpiTables.inf
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt.asl
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.asl
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboard.asl
>  * Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.asl
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/BoardEcLib.h
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.c
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.inf
>  *
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c
>
> I hope that is OK.
>
> Thanks,
> Nate
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Benjamin
> Doron
> Sent: Wednesday, August 18, 2021 11:49 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg:
> Add AspireVn7Dash572G
>
> This patchset adds support for a Acer Aspire VN7-572G (SKL-U laptop) board
> to KabylakeOpenBoardPkg, based on Kabylake RVP 3. As stated in a later
> commit message, there is a second, similar board: VN7-792G.
> - VN7-572G = "Rayleigh". Working, supported. Uses PCH-LP.
> - VN7-792G = "Newgate". Assumed broken, not supported. Uses PCH-H.
>   Also known as the "Black Edition" of the Aspire V Nitro.
>
> Because VN7-792G uses a different PCH, routing and GPIO configuration are
> assumed to be different. Users are strongly warned against attempting to
> flash images to VN7-792G at this time. Support may be added later by
> reverse engineering, but logs from a running system will help.
>
> Additional build depedencies:
> -
> https://github.com/benjamindoron/edk2-non-osi/commit/7bf736989159b74012d9bf3a13a9f941036be97a
> -
> https://github.com/benjamindoron/edk2/commit/db888a928c1c6fc94f6a7670f3402718c10c01d2
>
> V2 changes:
> - Whitespace changes and changes for coding guidelines compliance
> - KabylakeOpenBoardPkg changes merged into "duplicate KabylakeRvp3"
>   commit
> - EC (ACPI): LGMR hooked-up (disabled), other changes.
> - FSP-S configuration: Drop thermal changes not set by board, do not
>   override UART2 mode (PCI by policy)
>   - Set DspEndpointDmic so FSP produces correct configuration in HOB for
>     PchInitDxe. (However, 1ch array DMIC may not be supported by the
>     Linux driver. Also, presently NHLT is not installed in any case:
>     DspEnable=0 in HOB.)
> - Avoid indirect function calls for GPIO configuration and deduplicate
>   HSIO tables
> - Make board detection work and parse PCB version information
> - Begin working on hardening platform and improving PCD
>   - DXE stack guard, NX for stack, NULL pointer detection (DXE NX is
>     broken)
>   - Measure FSP to TPM (presently skipping FSP-S, there may be a bug
>     where the first TPM command from this time will timeout waiting for
>     goIdle)
>   - UGA draw protocol and HII OS runtime disabled, fast PS/2 detection
>
> V3 changes:
> - Remove Intel Corporation copyright from header of new files (ACPI
>   tables, BoardEcLib, board-specific policy)
> - More whitespace changes and add more descriptive comments for EC and
>   ACPI: particularly regarding reverse engineering work
> - Address feedback on V2
> - Use return values more and add more debug prints
> - Finalise EC initialisation/notification function (now after FSP-S),
>   which drops commented coreboot library functions from the beginning of
>   porting
> - Can perform EC time update (now in DXE). All commented coreboot
>   function calls are now removed
>
> Benjamin Doron (7):
>   KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands
>   KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3
>     directory
>   KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files
>   Platform/Intel: Early hook-up Acer Aspire VN7-572G
>   KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support
>   Maintainers.txt: Add myself as reviewer for AspireVn7Dash572G board
>   Platform/Intel/Readme.md: Add AspireVn7Dash572G to supported boards
>
>  Maintainers.txt
>                                                               |   4 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpiTables.inf
>                                                        |  16 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt.asl
>                                                              |  33 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl
>                                                               |  16 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.asl
>                                                              | 408
> +++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl
>                                                               | 439
> ++++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboard.asl
>                                                              |  79 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.asl
>                                                              | 117 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c
>               | 104 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c
>          | 285 ++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
>        |  82 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c
>         | 213 ++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
>            | 139 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h
>            |  26 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
>      | 243 +++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
>             |  77 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h
>             |  29 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
>       |  66 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
> | 144 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =>
> AspireVn7Dash572G}/Include/EcCommands.h
>        |   7 +-
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/FlashMapInclude.fdf
>                                                 |  50 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/BoardEcLib.h
>                                                    | 104 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeAspireVn7Dash572GAcpiTableLib.c
>                         |  74 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.c
>                                     |  28 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf
>                                   |  47 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c
>                        |  68 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c
>                                    |  55 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf
>                                  |  45 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c
>                                  | 165 +++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf
>                                               |  26 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c
>                                                 | 215 ++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GGpioTable.c
>                               | 396 +++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHdaVerbTables.c
>                           | 202 ++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHsioPtssTables.c
>                          |  26 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.c
>                                          | 120 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.inf
>                                        |  28 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GDetect.c
>                               |  90 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h
>                              |  33 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPostMemLib.c
>                       | 157 +++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c
>                        | 292 ++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostMemLib.c
>                                   |  40 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostMemLib.inf
>                                 |  52 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPreMemLib.c
>                                    |  99 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPreMemLib.inf
>                                  | 125 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.dsc
>                                                              | 681
> ++++++++++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fdf
>                                                              | 733
> ++++++++++++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgBuildOption.dsc
>                                                     | 149 ++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd.dsc
>                                                             | 546
> +++++++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c
>                     | 185 +++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h
>                     |  37 +
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h
>                      |  63 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c
>                    |  63 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c
>            |  74 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
>          |  52 ++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c
>                 | 328 +++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c
>            | 642 +++++++++++++++++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
>          | 107 +++
>  Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cfg
>                                                              |  34 +
>  Platform/Intel/KabylakeOpenBoardPkg/Include/Library/EcLib.h
>                                                               |  32 +
>  Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h
>                                                               |   2 +
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/EcCommands.h
>                                                               |   2 +
>  Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.c
>                                                               |   4 +-
>  Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/BaseEcLib.inf
>                                                               |   1 +
>  Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c
>                                                              |  76 ++
>  Platform/Intel/KabylakeOpenBoardPkg/OpenBoardPkg.dec
>                                                              |   1 +
>  Platform/Intel/Readme.md
>                                                              |   8 +
>  Platform/Intel/build.cfg
>                                                              |   1 +
>  67 files changed, 8883 insertions(+), 2 deletions(-)  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardAcpiTables.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/BoardSsdt.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ac.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/battery.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/ec.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/mainboard.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Acpi/thermal.asl
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PcieDeviceTable.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiBoardPolicyUpdate.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiFspPolicyUpdateLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdatePreMem.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdate.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSaPolicyUpdatePreMem.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf
>  copy Platform/Intel/KabylakeOpenBoardPkg/{KabylakeRvp3 =>
> AspireVn7Dash572G}/Include/EcCommands.h (74%)  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/FlashMapInclude.fdf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Library/BoardEcLib.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeAspireVn7Dash572GAcpiTableLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmAspireVn7Dash572GAcpiEnableLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardAcpiLib/SmmSiliconAcpiEnableLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/BoardEcLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardEcLib/EcCommands.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GGpioTable.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHdaVerbTables.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/AspireVn7Dash572GHsioPtssTables.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/DxeBoardInitLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GDetect.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitLib.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPostMemLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiAspireVn7Dash572GInitPreMemLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostMemLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPostMemLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPreMemLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Library/BoardInitLib/PeiBoardInitPreMemLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.dsc
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fdf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgBuildOption.dsc
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgPcd.dsc
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeGopPolicyInit.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyInit.h
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSaPolicyUpdate.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/DxeSiliconPolicyUpdateLib/DxeSiliconPolicyUpdateLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiBoardPolicyUpdate.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSiliconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/build_config.cfg
>  create mode 100644
> Platform/Intel/KabylakeOpenBoardPkg/Library/BaseEcLib/EcCommands.c
>
> --
> 2.31.1
>
>
>
> 
>
>
>

[-- Attachment #2: Type: text/html, Size: 27075 bytes --]

  reply	other threads:[~2021-08-26  4:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 18:48 [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Benjamin Doron
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 1/7] KabylakeOpenBoardPkg/BaseEcLib: Add some common EC commands Benjamin Doron
2021-08-20  0:15   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:49   ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 2/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Duplicate KabylakeRvp3 directory Benjamin Doron
2021-08-20  0:16   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:50   ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 3/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Rename KabylakeRvp3 files Benjamin Doron
2021-08-20  0:16   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:49   ` Nate DeSimone
2021-08-18 18:48 ` [edk2-platforms][PATCH v3 4/7] Platform/Intel: Early hook-up Acer Aspire VN7-572G Benjamin Doron
2021-08-20  0:16   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:49   ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 5/7] KabylakeOpenBoardPkg/AspireVn7Dash572G: Add initial support Benjamin Doron
2021-08-20  0:17   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:50   ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 6/7] Maintainers.txt: Add myself as reviewer for AspireVn7Dash572G board Benjamin Doron
2021-08-20  0:18   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:49   ` Nate DeSimone
2021-08-18 18:49 ` [edk2-platforms][PATCH v3 7/7] Platform/Intel/Readme.md: Add AspireVn7Dash572G to supported boards Benjamin Doron
2021-08-20  0:19   ` [edk2-devel] " Michael Kubacki
2021-08-26  3:49   ` Nate DeSimone
2021-08-26  3:53 ` [edk2-devel] [edk2-platforms][PATCH v3 0/7] KabylakeOpenBoardPkg: Add AspireVn7Dash572G Nate DeSimone
2021-08-26  3:58 ` Nate DeSimone
2021-08-26  4:08   ` Benjamin Doron [this message]
2021-08-26 21:19     ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAONYkK_zqTLG287CwDt-3kH1BpgZdf8sj1LOphq3OP=j0ad=eA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox