From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 118E0740038 for ; Thu, 11 Apr 2024 06:24:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1W2xCloUNKZ20DLfkeF2MBfK/EYoOug+hJySfLxJKCk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712816650; v=1; b=CtRgEFRmfw6oWncQsSIO0dGOjRr8J0Q0wfhIF6fMASEXtVUflOuz9LETr5ZXEcMHCrzzFVZa qKe72kWmdI32ZV8+wLnMjq4oNC4UlTDSfwWNlvKmb4OGl0gbwskZuVQkHXTMiFjjbJKCm+G6BMD LfWbdXrJ/ikePpsVHo/UjpOKUXfGozxlVG7IkphpkjAptOGcRHnhiSQHaMleaM5PjjqRwdJfe7t x3av+Xl1TSVfg4nlXx8bG5IXwDKWp6M8rObqTgz0cDy1H7a7KiCkwaCl5D2/6KWMosUiGnI//pB BuQhkuuwtb+dcx53a9ddhzyKZEYx69igwDgKX+3SJqaOA== X-Received: by 127.0.0.2 with SMTP id z3xcYY7687511xr7WRpNr50e; Wed, 10 Apr 2024 23:24:10 -0700 X-Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web11.11000.1712816649665946584 for ; Wed, 10 Apr 2024 23:24:09 -0700 X-Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-41641a889ccso42375e9.1 for ; Wed, 10 Apr 2024 23:24:09 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWKDdPzAp8IvpdmxV1Fr2oIsGAnY8R5KnnBgC2C4dAuQu5HMocoDN2okk3ADmWsjpGQOFcD7UN4JgeueA8RFCUI4ahtyw== X-Gm-Message-State: 8OAdsg3P3Zqh2ToQxOjgmvC9x7686176AA= X-Google-Smtp-Source: AGHT+IHCa3yroBbp77I5AreetFjWSnIDlcpeX5KaLYfaCvdDqDplaRYSCbAannmbRtqlZ7UBOjjBmDKnVUUFpJBUe7Y= X-Received: by 2002:a05:600c:3488:b0:417:ca55:798 with SMTP id a8-20020a05600c348800b00417ca550798mr125117wmq.2.1712816647721; Wed, 10 Apr 2024 23:24:07 -0700 (PDT) MIME-Version: 1.0 References: <94521f20aa2872c1b8f018b7db31eca4a2b8222d.1711039409.git.qinkun@google.com> In-Reply-To: From: "qinkun Bao via groups.io" Date: Wed, 10 Apr 2024 20:23:56 -1000 Message-ID: Subject: Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR. To: "Yao, Jiewen" Cc: Dionna Amalie Glaze , Mikko Ylinen , Ard Biesheuvel , Gerd Hoffmann , James Bottomley , Tom Lendacky , Michael Roth , "devel@edk2.groups.io" , "linux-coco@lists.linux.dev" , "Aktas, Erdem" , Peter Gonda , "Johnson, Simon P" , "Xiang, Qinglan" , Kuppuswamy Sathyanarayanan , ruoyu.ying@intel.com, "Lu, Ken" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 10 Apr 2024 23:24:10 -0700 Resent-From: qinkun@google.com Reply-To: devel@edk2.groups.io,qinkun@google.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=CtRgEFRm; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jiewen, Thank you! On Wed, Apr 10, 2024 at 3:20=E2=80=AFPM Yao, Jiewen = wrote: > > Hi Dionna/Qinkun > I am not sure if systemd is the last software in guest we need to patch t= o support coexistence to extend the measurement. The direct boot patch needs to be patched as well. Here is the link. efi/libstub: Add Confidential Computing (CC) measurement support - Kuppuswamy Sathyanarayanan (kernel.org) https://lore.kernel.org/lkml/20240215030002.281456-2-sathyanarayanan.kuppus= wamy@linux.intel.com/ Ard is the maintainer for EFI Stub. > Are you aware of any other Linux guest software needs to be updated? Such= as Linux IMA (Integrity Measurement Architecture)? You are right that Linux IMA needs to support coexistence. However, the TDX RTMR IMA support has not been merged into the kernel source code yet. I have never seen the TDX IMA patch in the LKML as well. I find that Intel's TDX MVP kernel has the TDX RTMR IMA support patch. Here is the link https://github.com/intel/tdx-tools/tree/tdx-1.5/build/common For what I see, the TDX RTMR IMA patches ([PATCH 672/731] ima: support for boot aggregate and runtime measurements in TDX RTMR) from TDX MVP kernel support the coexistence. The patch author is Ruoyu Ying . > > To move this forward. > > In Intel, we had discussed and we did see the potential security risk. As= I mentioned in the first email, "In case that any the guest component only= knows one of vTPM or RTMR, and only extends one of vTPM or RTMR, but the o= ther one only verifies the other, then the chain of trust is broken." > > At same time, we also respect that it might be a valid use case for Googl= e. > I would like to ask the opinion in the EDKII community, especially the OV= MF and CC maintainer and reviewer. > > > Hi Ard Biesheuvel > Do you think Kernel is OK with this coexistence proposal? > Are you willing to give "reviewed-by"? > > Hi Gerd Hoffman > Do you think RedHat is OK with this coexistence proposal? > Are you willing to give "reviewed-by"? > > Hi James Bottomley > Do you think IBM is OK with this coexistence proposal? > Are you willing to give "reviewed-by"? > > Hi Tom Lendacky/Michael Roth > Do you think AMD is OK with this coexistence proposal? > Are you willing to give "reviewed-by"? > > > Thank you > Yao, Jiewen > > > > -----Original Message----- > > From: Dionna Amalie Glaze > > Sent: Monday, March 25, 2024 11:29 PM > > To: Mikko Ylinen > > Cc: Gerd Hoffmann ; Yao, Jiewen ; > > qinkun Bao ; devel@edk2.groups.io; linux- > > coco@lists.linux.dev; Aktas, Erdem ; Ard Biesheu= vel > > ; Peter Gonda ; James Bottomley > > ; Tom Lendacky ; Michael > > Roth > > Subject: Re: [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coex= istance > > of vTPM and RTMR. > > > > On Mon, Mar 25, 2024 at 6:07=E2=80=AFAM Mikko Ylinen > > wrote: > > > > > > > > > > > > > Looking at systemd-boot I see it will likewise not measure to bot= h RTMR > > > > > and vTPM, but with reversed priority (use vTPM not RTMR in case b= oth are > > > > > present). > > > > > > > > > > > > > Interesting. Thanks for this report. We'll push for the changed > > > > semantics here if the spec is indeed changed, and request partner > > > > distros in the CCC to include the updated systemd-boot. > > > > > > FWIW, my RTMRs patch to systemd was merged quite recently so it's not > > > included in any systemd release yet. (It was mainly implemented for t= he > > > UKI case that allows TDVF to boot a UKI image directly and then have = the > > > image sections measured separately.) > > > > > > > Thank you, I've proposed a change in > > https://github.com/systemd/systemd/pull/31939 > > > > > > -- > > -Dionna Glaze, PhD (she/her) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117615): https://edk2.groups.io/g/devel/message/117615 Mute This Topic: https://groups.io/mt/105070442/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-