From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-x242.google.com (mail-vk0-x242.google.com [IPv6:2607:f8b0:400c:c05::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CB88821A16EC0 for ; Thu, 18 May 2017 19:37:04 -0700 (PDT) Received: by mail-vk0-x242.google.com with SMTP id p85so684726vkd.3 for ; Thu, 18 May 2017 19:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1N4fbGAc7OC7bgqghbyfZgwtgNpERcWdfaVRdvElF/Y=; b=HW9ZIRLPpXhF49a5Tgpe13wBczJ7AcPt4a5h942PJovNr3ViEBJrbPTKRrw3cn4pxB TjP1aRikPuB+qdPCxp4OpBDbWR4hgLRU2blTp6nVSnwC0BKLIF2eZ6+lIkJzyUgcJqok 9i8vjcuoZTHcbH5+hUdW9P0AXH7NHkrZzoEteIOmjzacGyIjtXy7m8GKTTm/dTwpmbjs P4KNSTAhPJoBYLfLWvQu0DURfMJnNQER4lrApG+lUS0B918kflsyyhOoI/8QrCS19kXK iW7JuPNrTOoyPbu3f2mwEAG4wwe6fKDe3/k43QORYpR0kQOamkXCUdVoDXxZn5l2T/cw W9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1N4fbGAc7OC7bgqghbyfZgwtgNpERcWdfaVRdvElF/Y=; b=muQMIoZ68tuplMVP0SkUyj7M88py2r217aurgyKgAaBJn5aBZD3o40tpvEYX0SZeYb lnm4YrrVdWDYPozk5NOHqjZ4cYJmaQOppL5Pt1qwiwI6jAcDkAm4B6UXxeDNLRlbTWQq JStuXaHBJmUVfUpvEzHSxkqM6Br+5IzNaktaPlgkRhuI+VHV6slxZ2bmKOXJXuTyAGWU COCWCBkJ6kDDOxUkkhPhVPHqRB8idJ7i7PxUc7iB0s56KdTmO+vVsC5ehTimAA8eSAGX 8zMLKtYz8EM2SD7bycFOt62lWHAACzmD1PvlO1X91oVatPNHmWqhYjqlBKI9ZikJm+rS Qc7Q== X-Gm-Message-State: AODbwcB3vnkT8IVsbf+cRyjdS5eqGpumowZX9o6uLOQTJGu4mAFffE47 HsV1mGKPiOoiedX8UEyUm9d9l/mIKQ== X-Received: by 10.31.41.210 with SMTP id p201mr639170vkp.94.1495161422590; Thu, 18 May 2017 19:37:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.35.78 with HTTP; Thu, 18 May 2017 19:37:02 -0700 (PDT) In-Reply-To: References: <1494903391-716-1-git-send-email-s.temerkhanov@gmail.com> From: Sergei Temerkhanov Date: Fri, 19 May 2017 05:37:02 +0300 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH] Arm: GICv3: Don't access GIC_ICDIPR for interrupts 0..31 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 02:37:05 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 18, 2017 at 7:08 PM, Ard Biesheuvel wrote: > On 16 May 2017 at 03:56, Sergey Temerkhanov wro= te: >> These registers are reserved for PPIs and unimplemented on >> some architectures >> > > > What do you mean by 'architectures'? GIC core implementations. > Could you elaborate on which SoC > needs this? At least Cavium ThunderX/OcteonTX need it. The GICv3 spec says this on the subject: 8.9.12 GICD_IPRIORITYR, Interrupt Priority Registers, n =3D 0 - 254 "These registers are always used when affinity routing is not enabled. When affinity routing is enabled for the Security state of an interrupt: =E2=80=A2 GICR_IPRIORITYR is used instead of GICD_IPRIORITYR whe= re n =3D 0 to 7 (that is, for SGIs and PPIs). =E2=80=A2 GICD_IPRIORITYR is RAZ= /WI where n =3D 0 to 7." > >> Signed-off-by: Sergey Temerkhanov >> --- >> ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c b/ArmPkg/Drivers/= ArmGic/GicV3/ArmGicV3Dxe.c >> index 8af97a9..dc6b896 100644 >> --- a/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c >> +++ b/ArmPkg/Drivers/ArmGic/GicV3/ArmGicV3Dxe.c >> @@ -257,7 +257,7 @@ GicV3DxeInitialize ( >> MmioOr32 (mGicDistributorBase + ARM_GIC_ICDDCR, ARM_GIC_ICDDCR_ARE)= ; >> } >> >> - for (Index =3D 0; Index < mGicNumInterrupts; Index++) { >> + for (Index =3D 32; Index < mGicNumInterrupts; Index++) { >> GicV3DisableInterruptSource (&gHardwareInterruptV3Protocol, Index); >> >> // Set Priority >> -- >> 2.7.4 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel