whats the use of bitfield:8 for UINT8 variable type? +typedef struct { *+ UINT8 CompletionCode:8;* +} IPMI_SET_BOOT_OPTIONS_RESPONSE; Thanks AbduL On Mon, Jun 21, 2021 at 7:19 AM gaoliming wrote: > Thanks for you update. > > Reviewed-by: Liming Gao > > Thanks > Liming > > -----邮件原件----- > > 发件人: manickavasakam karpagavinayagam > > 发送时间: 2021年6月18日 23:38 > > 收件人: devel@edk2.groups.io > > 抄送: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; > > Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; > > zacharyb@ami.com; manickavasakamk@ami.com; > > gaoliming@byosoft.com.cn > > 主题: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions > > to resolve build errors > > > > Build error reported for missing structures > > IPMI_SET_BOOT_OPTIONS_RESPONSE, > > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > > D_UPDATE_MODE > > when using > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > > > > MdePkg : Rename IPMI Macro and Structure Defintions > > > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > IPMI_BMC_IN_FORCED_UPDATE_MODE > > > > Notes: > > V1 : > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > IPMI_BMC_IN_FORCED_UPDATE_MODE > > > > V2: > > > > Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > > > > V3: > > > > Add Signed-off-by information > > > > Signed-off-by: Manickavasakam Karpagavinayagam > > > > --- > > .../IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > > .../IndustryStandard/IpmiNetFnFirmware.h | 18 > > ++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > index 79db55523d..d7cdd3a865 100644 > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > @@ -186,6 +186,10 @@ typedef struct { > > UINT8 ParameterData[0]; > > > > } IPMI_SET_BOOT_OPTIONS_REQUEST; > > > > > > > > +typedef struct { > > > > + UINT8 CompletionCode:8; > > > > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; > > > > + > > > > // > > > > // Definitions for Get System Boot options command > > > > // > > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > index 2d892dbd5a..c4cbe2349b 100644 > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > @@ -17,4 +17,22 @@ > > // All Firmware commands and their structure definitions to follow here > > > > // > > > > > > > > +// > > ---------------------------------------------------------------------------- > ------------ > > > > +// Definitions for Get BMC Execution Context > > > > +// > > ---------------------------------------------------------------------------- > ------------ > > > > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 > > > > + > > > > +// > > > > +// Constants and Structure definitions for "Get Device ID" command to > > follow here > > > > +// > > > > +typedef struct { > > > > + UINT8 CurrentExecutionContext; > > > > + UINT8 PartitionPointer; > > > > +} IPMI_MSG_GET_BMC_EXEC_RSP; > > > > + > > > > +// > > > > +// Current Execution Context responses > > > > +// > > > > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > > + > > > > #endif > > > > -- > > 2.25.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by > their > > designee. If the reader of this message is not the intended recipient, > you > are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of the > > transmission. > > > > > > > > -- Thanks and Regards Abdul Lateef Attar Bangalore