From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mx.groups.io with SMTP id smtpd.web08.6245.1624448575662041204 for ; Wed, 23 Jun 2021 04:42:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tZk0Pvcc; spf=pass (domain: gmail.com, ip: 209.85.217.51, mailfrom: lateefcs@gmail.com) Received: by mail-vs1-f51.google.com with SMTP id j15so1269172vsf.2 for ; Wed, 23 Jun 2021 04:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dVLlGc3HCGlwJqkT9FXvXGSWQ9cM4X5FySYdABzloS0=; b=tZk0PvccXPVxR8Q2M7jszbCp0601QYEWPUkwYyWWOhxXhMdb8zsmYC/kMv6jC9OLxn olLLZogyVzWThzR+DwQrI3yl7ci88kJGjIVNaXhqQ2cPpdmueIgm9M/b/+7oef2Ttgv+ d/9/9CpOqqOXPLshVf6Wz6vSJsloEMOgPpmgq7d7esTfy7FFbCCpNxkJBe8JbKu67xj7 HGyqYXssxGW44zWkBRLvbT2Cb0lcvR1wrAhSkHEhzae3s8q+0q2KvJ/UJUxZi0j/VBRk YUMYgSwS4d/QZUan0qNlc4iu8UWEuXSLEsmFna7b/E63ePy8unYSgiZ53QrU2XvVoz4U z0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dVLlGc3HCGlwJqkT9FXvXGSWQ9cM4X5FySYdABzloS0=; b=V0dDuj49WPJ809tP1ps0hUGF0eHs95lS9G/ALkfybei0IaF9d3cMkZDDrVGnSqn/5x n+Kv1A8d+SjYMO97JvStFS5n9AEo22a3tQZYjsdNB+D1QIlMNEQf6jAWTRzhYiMg2l1k pZmnfcTZKGhap5B5JO6J2mkbCSzy0lrnffc8bOVI1UceBEAQG5+jyNRNsRE1NTDsOYPl gVwNZxSGlWt9opZhwbloXCMLCJfQXbd/ZX2YVbhuAOBO1galWTqzpUHRRneLwL8Gbz83 splceatvzyr/5hzdYNjiAF1MwQg8DsP0m7H1qpV/UObpxWw+DDfHSl4oCcUH49PZT9iF 8DhQ== X-Gm-Message-State: AOAM533KvGrrs4qSfwi+Q0XNz88oFgpQmz6s/DGUudI5awuwFu9rhB3Z T07k2CgsyQXJNNkR3MnXWvUiVZV1AnsOyd5oMWHhwsnB0Ps= X-Google-Smtp-Source: ABdhPJzGK/jXi5kwEXyK++zZjBNqtEO6MDsIBDGqYtC+M8Kf+74C7xDmeylCvjVfb4oxCvhHT3VoDfdNHu+qrf0lgrM= X-Received: by 2002:a67:2f41:: with SMTP id v62mr12006087vsv.10.1624448574604; Wed, 23 Jun 2021 04:42:54 -0700 (PDT) MIME-Version: 1.0 References: <20210618153734.11983-1-manickavasakamk@ami.com> <008101d7663f$a0a85c40$e1f914c0$@byosoft.com.cn> In-Reply-To: <008101d7663f$a0a85c40$e1f914c0$@byosoft.com.cn> From: lateefcs@gmail.com Date: Wed, 23 Jun 2021 17:12:43 +0530 Message-ID: Subject: =?UTF-8?B?UmU6IFtlZGsyLWRldmVsXSDlm57lpI06IFtlZGsyXVtQQVRDSCBWM10gTWRlUGtnIDogQWRkIElQTUkgTWFjcm8gYW5kIFN0cnVjdHVyZSBEZWZpbnRpb25zIHRvIHJlc29sdmUgYnVpbGQgZXJyb3Jz?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn Cc: manickavasakam karpagavinayagam , isaac.w.oram@intel.com, nathaniel.l.desimone@intel.com, Felixp@ami.com, Harikrishnad@ami.com, manishj@ami.com, zacharyb@ami.com Content-Type: multipart/alternative; boundary="0000000000003eca5405c56d6880" --0000000000003eca5405c56d6880 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable whats the use of bitfield:8 for UINT8 variable type? +typedef struct { *+ UINT8 CompletionCode:8;* +} IPMI_SET_BOOT_OPTIONS_RESPONSE; Thanks AbduL On Mon, Jun 21, 2021 at 7:19 AM gaoliming wrote= : > Thanks for you update. > > Reviewed-by: Liming Gao > > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97= =A5 23:38 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com; nathaniel.l.desimone@intel= .com; > > Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; > > zacharyb@ami.com; manickavasakamk@ami.com; > > gaoliming@byosoft.com.cn > > =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Struc= ture Defintions > > to resolve build errors > > > > Build error reported for missing structures > > IPMI_SET_BOOT_OPTIONS_RESPONSE, > > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > > D_UPDATE_MODE > > when using > > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > > > > MdePkg : Rename IPMI Macro and Structure Defintions > > > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > IPMI_BMC_IN_FORCED_UPDATE_MODE > > > > Notes: > > V1 : > > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > > IPMI_BMC_IN_FORCED_UPDATE_MODE > > > > V2: > > > > Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > > > > V3: > > > > Add Signed-off-by information > > > > Signed-off-by: Manickavasakam Karpagavinayagam > > > > --- > > .../IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > > .../IndustryStandard/IpmiNetFnFirmware.h | 18 > > ++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > index 79db55523d..d7cdd3a865 100644 > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > > @@ -186,6 +186,10 @@ typedef struct { > > UINT8 ParameterData[0]; > > > > } IPMI_SET_BOOT_OPTIONS_REQUEST; > > > > > > > > +typedef struct { > > > > + UINT8 CompletionCode:8; > > > > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; > > > > + > > > > // > > > > // Definitions for Get System Boot options command > > > > // > > > > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > index 2d892dbd5a..c4cbe2349b 100644 > > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > > @@ -17,4 +17,22 @@ > > // All Firmware commands and their structure definitions to follow he= re > > > > // > > > > > > > > +// > > ------------------------------------------------------------------------= ---- > ------------ > > > > +// Definitions for Get BMC Execution Context > > > > +// > > ------------------------------------------------------------------------= ---- > ------------ > > > > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 > > > > + > > > > +// > > > > +// Constants and Structure definitions for "Get Device ID" command t= o > > follow here > > > > +// > > > > +typedef struct { > > > > + UINT8 CurrentExecutionContext; > > > > + UINT8 PartitionPointer; > > > > +} IPMI_MSG_GET_BMC_EXEC_RSP; > > > > + > > > > +// > > > > +// Current Execution Context responses > > > > +// > > > > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 > > > > + > > > > #endif > > > > -- > > 2.25.0.windows.1 > > > > > > Please consider the environment before printing this email. > > > > The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is inten= ded > > to be read only by the individual or entity to whom it is addressed or= by > their > > designee. If the reader of this message is not the intended recipient, > you > are > > on notice that any distribution of this message, in any form, is stric= tly > > prohibited. Please promptly notify the sender by reply e-mail or by > > telephone at 770-246-8600, and then delete or destroy all copies of th= e > > transmission. > > > > >=20 > > > --=20 Thanks and Regards Abdul Lateef Attar Bangalore --0000000000003eca5405c56d6880 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
whats the use of bitfield:8 for UINT8 variable type?
<= span style=3D"color:rgb(51,51,51);font-family:"Helvetica Neue",He= lvetica,Arial,sans-serif;font-size:14px;white-space:pre-wrap">+typedef stru= ct {
+ UINT8 CompletionCode:8;
+} IPMI_SET_BOOT_OPTIONS_RESPO= NSE;

Thanks
AbduL

On Mon, Jun 21, 202= 1 at 7:19 AM gaoliming <gaol= iming@byosoft.com.cn> wrote:
Thanks for you update.

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam <manickavasakamk@am= i.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97= = =A5 23:38
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E6=8A=84=E9=80=81: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com;
> Felixp@ami.com; Harikrishnad@a= mi.com; manishj@am= i.com;
> zacharyb@ami.co= m; manicka= vasakamk@ami.com;
> gaolimi= ng@byosoft.com.cn
> =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Stru= cture Defintions
> to resolve build errors
>
> Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
> macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
>
> MdePkg : Rename IPMI Macro and Structure Defintions
>
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
>
> Notes:
> V1 :
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
>
> V2:
>
> Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patc= h
>
> V3:
>
> Add Signed-off-by information
>
> Signed-off-by: Manickavasakam Karpagavinayagam
> <mani= ckavasakamk@ami.com>
> ---
>=C2=A0 .../IndustryStandard/IpmiNetFnChassis.h=C2=A0 =C2=A0 =C2=A0 =C2= = =A0 |=C2=A0 4 ++++
>=C2=A0 .../IndustryStandard/IpmiNetFnFirmware.h=C2=A0 =C2=A0 =C2=A0 = =C2=A0| 18
> ++++++++++++++++++
>=C2=A0 2 files changed, 22 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
>=C2=A0 =C2=A0 UINT8=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Para= meterData[0];
>
>=C2=A0 } IPMI_SET_BOOT_OPTIONS_REQUEST;
>
>
>
> +typedef struct {
>
> +=C2=A0 UINT8=C2=A0 =C2=A0CompletionCode:8;
>
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
>
> +
>
>=C2=A0 //
>
>=C2=A0 //=C2=A0 Definitions for Get System Boot options command
>
>=C2=A0 //
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..c4cbe2349b 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,22 @@
>=C2=A0 // All Firmware commands and their structure definitions to fol= low here
>
>=C2=A0 //
>
>
>
> +//
--------------------------------------------------------------------------= --
------------
>
> +//=C2=A0 =C2=A0 Definitions for Get BMC Execution Context
>
> +//
--------------------------------------------------------------------------= --
------------
>
> +#define IPMI_GET_BMC_EXECUTION_CONTEXT=C2=A0 0x23
>
> +
>
> +//
>
> +//=C2=A0 Constants and Structure definitions for "Get Device ID= " command to
> follow here
>
> +//
>
> +typedef struct {
>
> +=C2=A0 UINT8=C2=A0 =C2=A0CurrentExecutionContext;
>
> +=C2=A0 UINT8=C2=A0 =C2=A0PartitionPointer;
>
> +} IPMI_MSG_GET_BMC_EXEC_RSP;
>
> +
>
> +//
>
> +// Current Execution Context responses
>
> +//
>
> +#define IPMI_BMC_IN_FORCED_UPDATE_MODE=C2=A0 0x11
>
> +
>
>=C2=A0 #endif
>
> --
> 2.25.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).=C2=A0 This communication is= intended
> to be read only by the individual or entity to whom it is addressed o= r by
their
> designee. If the reader of this message is not the intended recipient= , you
are
> on notice that any distribution of this message, in any form, is stri= ctly
> prohibited.=C2=A0 Please promptly notify the sender by reply e-mail o= r by
> telephone at 770-246-8600, and then delete or destroy all copies of t= he
> transmission.









--
Thanks and Regards
Abdul Lateef Attar
Ban= galore
--0000000000003eca5405c56d6880--