public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Henri Yandell <flamefew@gmail.com>
To: lersek@redhat.com
Cc: michael.d.kinney@intel.com, edk2-devel@lists.01.org,
	 jordan.l.justen@intel.com, afish@apple.com,
	stephano.cetola@intel.com,  leif.lindholm@linaro.org
Subject: Re: Missing ‘or’ in CLA
Date: Sat, 1 Sep 2018 15:29:39 -0700	[thread overview]
Message-ID: <CAPVuaYtdSOb7DMfh5Zz=GfDnSifq=sh4ZURmS1akTg2GkqJSXg@mail.gmail.com> (raw)
In-Reply-To: <bb0e2b8d-c597-fd99-eabd-d264943397f9@redhat.com>

As patch text (sorry, was on a phone for the first email and forgot I could
generate the patch from GitHub via url):

>From 86403de1826e3bcf860497c69141b40082ec56a5 Mon Sep 17 00:00:00 2001
From: Henri Yandell <hyandell@users.noreply.github.com>
Date: Wed, 29 Aug 2018 22:31:39 -0700
Subject: [PATCH] Adding missing 'or'

When the CLA was created from the Apache ICLA, the option for a CCLA
was removed. When this was done the 'or' was lost in the text. This
puts it back in so that you represent that you have received
permission __or__ your employer has waived such rights.
---
 Contributions.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Contributions.txt b/Contributions.txt
index f34626912a4..7859435c175 100644
--- a/Contributions.txt
+++ b/Contributions.txt
@@ -201,7 +201,7 @@ title, and interest in and to Your Contributions.
   license. If your employer(s) has rights to intellectual property
   that You create that includes Your Contributions, You represent
   that You have received permission to make Contributions on behalf
-  of that employer, that Your employer has waived such rights for
+  of that employer or that Your employer has waived such rights for
   Your Contributions.
 * You represent that each of Your Contributions is Your original
   creation (see Section 4 for submissions on behalf of others).


On Fri, Aug 31, 2018 at 12:30 PM Laszlo Ersek <lersek@redhat.com> wrote:

> Mike,
>
> On 08/31/18 01:58, Henri Yandell wrote:
> > The CLA is missing an ‘or’ in section 3.
> >
> > See https://github.com/tianocore/edk2/pull/133/files for an example of
> the
> > specific text.
>
> could you please turn this report into a real patch (if the suggested
> change is valid)? Technically it's easy enough so I could do it as well,
> just so we have something to review on the list, but:
> - I have no idea if the suggested change is valid,
> - I wasn't around when "Contributions.txt" was originally invented.
>
> Thanks
> Laszlo
>


  reply	other threads:[~2018-09-01 22:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 23:58 Missing ‘or’ in CLA Henri Yandell
2018-08-31 19:30 ` Laszlo Ersek
2018-09-01 22:29   ` Henri Yandell [this message]
2018-09-03 11:08   ` Leif Lindholm
2018-09-03 21:44     ` Henri Yandell
2018-09-14 22:34       ` Henri Yandell
2018-09-15  0:38         ` Kinney, Michael D
2018-09-15  3:25           ` Henri Yandell
2018-09-17  3:57             ` Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPVuaYtdSOb7DMfh5Zz=GfDnSifq=sh4ZURmS1akTg2GkqJSXg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox