From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::231; helo=mail-wm0-x231.google.com; envelope-from=kalyankumar.nagabhirava@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 831BF22152383 for ; Mon, 4 Dec 2017 07:42:33 -0800 (PST) Received: by mail-wm0-x231.google.com with SMTP id b76so15188764wmg.1 for ; Mon, 04 Dec 2017 07:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=NO/+H+L9WRaP0rB/tlVyONpValOsXJxGNww/EGA6vvM=; b=UEAIHOHncS/+zGr5LXPA1MpAb0ZyDRCHocLltXfUp7C/cQdDQpdjdtC+VWqLjqZIQE R0IkDhG7TjEIQTz3xO8CnXt7T75MWI1bqGoD7XZyQISI0dFCEzmX6LTl2lldiIJp4xIt myZpj0IKMIzhuF3di8GVT7slHiZSmb858eGf0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=NO/+H+L9WRaP0rB/tlVyONpValOsXJxGNww/EGA6vvM=; b=pMqlf/PUXH1MN8PsAAOUabjxlNqkyGdxDx6+akkZ5FEcJ/Yi4nkX3l6g0/jyLKbejJ LSWaydhrkKOcFMFNy2S45IHQolYQ+4fjGMs9PxTgHKEC7enQdTBFOvwYNoadFCYaO0eu LBdyL+L1NUGujhv/en3k+bkdyLKJYjE8pkNKXMcIVOALnNKj5L5a0l10//e+sOzsvGEF m2WfP4c1KPwZwoM0XPKJbmec3JHwBXrBhteZr3w0VzwOpvr9YKyseODcrCIF9KhWlCq2 1hOjyhLyj4C33+1hbKhxd1JStBNf+Yjz/KRZDLu566MRgeVWv1OeQ+lSfoF4XjgJwSIi peKA== X-Gm-Message-State: AJaThX4n391lVKSSySycqGYZT3ciDnHB1mZDMURBcxbs1OTSqLkf60cZ ZrbRwNlbTETEpZh3i9dablO5Feaai2f/NORPdXzK/w== X-Google-Smtp-Source: AGs4zMZPSAGXqI4i5GlOwfAf+tnftkhzbohuMCPc4urxCEZtcfKcqw1TnD586c/Ut9HfaS/+HRpOFhkuJufoPizCtKo= X-Received: by 10.80.160.198 with SMTP id 64mr31921765edo.242.1512402421777; Mon, 04 Dec 2017 07:47:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.184.113 with HTTP; Mon, 4 Dec 2017 07:47:01 -0800 (PST) In-Reply-To: <20171204153358.7jzrb4qokr6p7t7h@bivouac.eciton.net> References: <20171128072758.13509-1-kalyankumar.nagabhirava@linaro.org> <20171204153358.7jzrb4qokr6p7t7h@bivouac.eciton.net> From: Kalyan Nagabhirava Date: Mon, 4 Dec 2017 21:17:01 +0530 Message-ID: To: Leif Lindholm Cc: edk2-devel@lists.01.org, Ard Biesheuvel , Mark Gregotski X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Re: [PATCH] [edk2 EmbeddedPkg]:Adding secure boot and HTTP image download (Disaster recovery image) Applications for Linux based platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 15:42:33 -0000 Content-Type: text/plain; charset="UTF-8" sure Leif , we will address your review comments and send updated patches. Regards, kalyan. On 4 December 2017 at 21:03, Leif Lindholm wrote: > Hi Kalyan, > > Am I right in assuming that since this is the output of your team, you > have some time to look into reworking based on feedback (unlike the > HiKey support)? > > A few high-level comments: > 1) Please generate your patches with --stat=1000 --stat-graph-width=20 > as per https://github.com/tianocore/tianocore.github.io/wiki/ > Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers > 2) I see at least 3 separate patches below: > - Application/Dri > - Application/DriSecureBoot > - RdkBootManagerLib > 3) List.h looks mostly to be reimplementing functionality that already > exists in BaseLib.h. > > If you could address these three things and send out as a v2, then we > would be in a much better position to review the contribution > properly. > > Best Regards, > > Leif > > On Tue, Nov 28, 2017 at 12:57:58PM +0530, kalyan-nagabhirava wrote: > > Linaro and RDK are working on standardizing the boot process for RDK > STB boxes using Uefi. > > Added applications are reference implementation of RDK STB boot process > on Arm platforms > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: kalyan-nagabhirava > > --- > > EmbeddedPkg/Application/Dri/Dri.c | 26 + > > EmbeddedPkg/Application/Dri/Dri.inf | 56 ++ > > .../Application/DriSecureBoot/DriSecureBoot.c | 32 ++ > > .../Application/DriSecureBoot/DriSecureBoot.inf | 57 ++ > > EmbeddedPkg/Application/SecureBoot/SecureBoot.c | 30 ++ > > EmbeddedPkg/Application/SecureBoot/SecureBoot.inf | 57 ++ > > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c | 97 ++++ > > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h | 14 + > > EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf | 45 ++ > > EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c | 536 > +++++++++++++++++++ > > EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c | 315 +++++++++++ > > .../Library/RdkBootManagerLib/Include/DiskIo.h | 20 + > > .../Library/RdkBootManagerLib/Include/HttpBoot.h | 7 + > > .../Library/RdkBootManagerLib/Include/List.h | 136 +++++ > > .../RdkBootManagerLib/Include/RdkBootManagerLib.h | 31 ++ > > .../Library/RdkBootManagerLib/Include/RdkFile.h | 20 + > > .../Library/RdkBootManagerLib/Include/SecureBoot.h | 40 ++ > > .../RdkBootManagerLib/RdkBootManagerLib.dec | 52 ++ > > .../RdkBootManagerLib/RdkBootManagerLib.inf | 81 +++ > > EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c | 259 +++++++++ > > EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c | 577 > +++++++++++++++++++++ > > 21 files changed, 2488 insertions(+) > > create mode 100644 EmbeddedPkg/Application/Dri/Dri.c > > create mode 100644 EmbeddedPkg/Application/Dri/Dri.inf > > create mode 100644 EmbeddedPkg/Application/ > DriSecureBoot/DriSecureBoot.c > > create mode 100644 EmbeddedPkg/Application/DriSecureBoot/DriSecureBoot. > inf > > create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.c > > create mode 100644 EmbeddedPkg/Application/SecureBoot/SecureBoot.inf > > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.c > > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.h > > create mode 100644 EmbeddedPkg/Drivers/RdkDxe/RdkDxe.inf > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/DiskIo.c > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/HttpBoot.c > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/ > DiskIo.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/ > HttpBoot.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/List.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/ > RdkBootManagerLib.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/ > RdkFile.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/Include/ > SecureBoot.h > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/ > RdkBootManagerLib.dec > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/ > RdkBootManagerLib.inf > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/RdkFile.c > > create mode 100644 EmbeddedPkg/Library/RdkBootManagerLib/SecureBoot.c > -- regards, kalyan.