Re: [PATCH 1/3] ArmPkg/MdePkg : Unify INF files format

["Baptiste Gerondeau" <baptiste.gerondeau@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 2575 bytes --]

Sorry, for replying on this thread, this is the correct one (messed up the
author's email, sorry again !)

Ard Biescheuvel asks : "Why ?"

The practical reason would be because it breaks an "grep -nr "|
${toolchain}" "
(although with some regex magic I guess it can be circumvented, but one
would need to know in advance that there are places where there aren't
spaces)
The second reason would be because it breaks the standard format used in
all other inf files.
But if you find this is useless, I'll drop this one !


On Wed, 18 Sep 2019 at 18:05, Baptiste Gerondeau <
baptiste.gerondeau@linaro.org> wrote:

> From: Baptiste GERONDEAU <baptiste.gerondeau@linaro.org>
>
> Add a space between the '|' and the name of the toolchain to use,
> as is the case in all other INF files.
> Note that I did not touch the RVCT lines, since a following commit in
> the set will address those.
>
> Signed-off-by: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
> ---
>  ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf                 |  2 +-
>  MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 10 +++++-----
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> index f4fecbb4098a..33dddf1e2b97 100644
> --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> @@ -22,7 +22,7 @@ [Sources.AARCH64]
>
>  [Sources.ARM]
>    Arm/ArmMmuLibCore.c
> -  Arm/ArmMmuLibV7Support.S   |GCC
> +  Arm/ArmMmuLibV7Support.S   | GCC
>    Arm/ArmMmuLibV7Support.asm |RVCT
>
>  [Packages]
> diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> index e4e3d532e7b8..d38e1397eee1 100644
> --- a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> +++ b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
> @@ -79,11 +79,11 @@ [Defines.ARM, Defines.AARCH64]
>    LIBRARY_CLASS = BaseMemoryLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER
> UEFI_DRIVER UEFI_APPLICATION
>
>  [Sources.ARM]
> -  Arm/ScanMem.S       |GCC
> -  Arm/SetMem.S        |GCC
> -  Arm/CopyMem.S       |GCC
> -  Arm/CompareMem.S    |GCC
> -  Arm/CompareGuid.S   |GCC
> +  Arm/ScanMem.S       | GCC
> +  Arm/SetMem.S        | GCC
> +  Arm/CopyMem.S       | GCC
> +  Arm/CompareMem.S    | GCC
> +  Arm/CompareGuid.S   | GCC
>
>    Arm/ScanMem.asm     |RVCT
>    Arm/SetMem.asm      |RVCT
> --
> 2.23.0
>
>

-- 
Baptiste Gerondeau
Engineer - HPC SIG - LDCG - Linaro
#irc : BaptisteGer

[-- Attachment #2: Type: text/html, Size: 3469 bytes --]