From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=HR7KOCHu; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: baptiste.gerondeau@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Thu, 19 Sep 2019 03:43:03 -0700 Received: by mail-wm1-f68.google.com with SMTP id a6so3837655wma.5 for ; Thu, 19 Sep 2019 03:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lMp9Hqz3k16fIXFV6n8Ecein7OJWbuQBnJ4DFZMAHAY=; b=HR7KOCHutTsUci9TQMt8sdKXCXeVxb1z92dM99gJ4Zbq4mIs4ZXq0oK9uGv1h5wtIe qlatbUexcwsjrDezgaNz5PvimX01ppFwLEFCtgUY2e0MeTxyqlHCi/MRf/ROmh74Ftnb k2fQZzPjRp30o64vyOxo18xZDby3Eww+88uq45MGOvbDblch0CJHpXLIjQ2IeKuYNWlO Z+rAOPte36C2BzD909kZnU3QqSA40wrNiegrVo5mKA15SZzDi81CQ466n8vH70wXmj+B DhVdvNQIK6wyHaIaum5gB7ctGZlDjFQ9cDUwSY7C9g07Pnxqr2vMm4dkXIYj8OrUWboW vDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lMp9Hqz3k16fIXFV6n8Ecein7OJWbuQBnJ4DFZMAHAY=; b=KaKco8OVFB8BK8Z/5xm1R8DmGq20u/oKWGum16PeV5saNTRECXYEaDz07/rZW7da1g vB8C9V/vUB/bzHT7OmDr9CHVKZdxYcqpaDSQN7AYQeOVuBSvMBSf9wLynx6z5nuSYfrC P07pORLub5sdY1Upp4GNK5z2Ybg9byAYuc7IaASaWX6ZplEjMxMhLoVjTh2TqWUBAX2v In1oPeAe2s3A5d2UNk984AnloTjKy13QQzaqiSpVnMYJNnBudxnsdiEu5Yo3IYK30Fr3 4iwvNF6szFTbZvNcvOhX6y3WmRzX9W92baZXLDtECkocAZte43RQ3gMEBz0PTSvHFhqc 8/HA== X-Gm-Message-State: APjAAAUMW0o8oZcAc/ra72u4CqiG6eHEFtzRKGr0egeK5GsHGP2BJrJk VIkm7pdxWGORQQAZ+2tqArG05JckQ1UrbA7yeIMFu/u2j+4= X-Google-Smtp-Source: APXvYqymrxbb1l+j/gXvISyfZyIErsJxBhd8Q/I0lsD8s4C3cUuPG586DvEtIuDcoTy49z1wuMmg+/tIrDsSi+ip1EY= X-Received: by 2002:a1c:7902:: with SMTP id l2mr2234849wme.55.1568889780944; Thu, 19 Sep 2019 03:43:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Baptiste Gerondeau" Date: Thu, 19 Sep 2019 12:42:50 +0200 Message-ID: Subject: Re: [PATCH 1/3] ArmPkg/MdePkg : Unify INF files format To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" , "Zhang, Shenglei" Content-Type: multipart/alternative; boundary="00000000000015e6340592e59e7e" --00000000000015e6340592e59e7e Content-Type: text/plain; charset="UTF-8" Sorry, for replying on this thread, this is the correct one (messed up the author's email, sorry again !) Ard Biescheuvel asks : "Why ?" The practical reason would be because it breaks an "grep -nr "| ${toolchain}" " (although with some regex magic I guess it can be circumvented, but one would need to know in advance that there are places where there aren't spaces) The second reason would be because it breaks the standard format used in all other inf files. But if you find this is useless, I'll drop this one ! On Wed, 18 Sep 2019 at 18:05, Baptiste Gerondeau < baptiste.gerondeau@linaro.org> wrote: > From: Baptiste GERONDEAU > > Add a space between the '|' and the name of the toolchain to use, > as is the case in all other INF files. > Note that I did not touch the RVCT lines, since a following commit in > the set will address those. > > Signed-off-by: Baptiste Gerondeau > --- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 2 +- > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 10 +++++----- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > index f4fecbb4098a..33dddf1e2b97 100644 > --- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > +++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > @@ -22,7 +22,7 @@ [Sources.AARCH64] > > [Sources.ARM] > Arm/ArmMmuLibCore.c > - Arm/ArmMmuLibV7Support.S |GCC > + Arm/ArmMmuLibV7Support.S | GCC > Arm/ArmMmuLibV7Support.asm |RVCT > > [Packages] > diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > index e4e3d532e7b8..d38e1397eee1 100644 > --- a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > +++ b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf > @@ -79,11 +79,11 @@ [Defines.ARM, Defines.AARCH64] > LIBRARY_CLASS = BaseMemoryLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER > UEFI_DRIVER UEFI_APPLICATION > > [Sources.ARM] > - Arm/ScanMem.S |GCC > - Arm/SetMem.S |GCC > - Arm/CopyMem.S |GCC > - Arm/CompareMem.S |GCC > - Arm/CompareGuid.S |GCC > + Arm/ScanMem.S | GCC > + Arm/SetMem.S | GCC > + Arm/CopyMem.S | GCC > + Arm/CompareMem.S | GCC > + Arm/CompareGuid.S | GCC > > Arm/ScanMem.asm |RVCT > Arm/SetMem.asm |RVCT > -- > 2.23.0 > > -- Baptiste Gerondeau Engineer - HPC SIG - LDCG - Linaro #irc : BaptisteGer --00000000000015e6340592e59e7e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, for replying on this thread, this is the correct on= e (messed up the author's email, sorry again !)

Ard Biescheuvel = asks : "Why ?"

The practical reason would be because it br= eaks an "grep -nr "| ${toolchain}" "
(although with = some regex magic I guess it can be circumvented, but one would need to know= in advance that there are places where there aren't spaces)
The sec= ond reason would be because it breaks the standard format used in all other= inf files.
But if you find this is useless, I'll drop this one !

On Wed, 18 Sep 2019 at 18:05, Baptiste Gerondeau <baptiste.gerondeau@linaro.org> wrote= :
From: Baptiste= GERONDEAU <baptiste.gerondeau@linaro.org>

Add a space between the '|' and the name of the toolchain to use, as is the case in all other INF files.
Note that I did not touch the RVCT lines, since a following commit in
the set will address those.

Signed-off-by: Baptiste Gerondeau <baptiste.gerondeau@linaro.org>
---
=C2=A0ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 2 +-
=C2=A0MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 10 +++++= -----
=C2=A02 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/Ar= mMmuLib/ArmMmuBaseLib.inf
index f4fecbb4098a..33dddf1e2b97 100644
--- a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
+++ b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
@@ -22,7 +22,7 @@ [Sources.AARCH64]

=C2=A0[Sources.ARM]
=C2=A0 =C2=A0Arm/ArmMmuLibCore.c
-=C2=A0 Arm/ArmMmuLibV7Support.S=C2=A0 =C2=A0|GCC
+=C2=A0 Arm/ArmMmuLibV7Support.S=C2=A0 =C2=A0| GCC
=C2=A0 =C2=A0Arm/ArmMmuLibV7Support.asm |RVCT

=C2=A0[Packages]
diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf b/M= dePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
index e4e3d532e7b8..d38e1397eee1 100644
--- a/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
+++ b/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf
@@ -79,11 +79,11 @@ [Defines.ARM, Defines.AARCH64]
=C2=A0 =C2=A0LIBRARY_CLASS =3D BaseMemoryLib|DXE_CORE DXE_DRIVER DXE_RUNTIM= E_DRIVER UEFI_DRIVER UEFI_APPLICATION

=C2=A0[Sources.ARM]
-=C2=A0 Arm/ScanMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0|GCC
-=C2=A0 Arm/SetMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0 |GCC
-=C2=A0 Arm/CopyMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0|GCC
-=C2=A0 Arm/CompareMem.S=C2=A0 =C2=A0 |GCC
-=C2=A0 Arm/CompareGuid.S=C2=A0 =C2=A0|GCC
+=C2=A0 Arm/ScanMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0| GCC
+=C2=A0 Arm/SetMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0 | GCC
+=C2=A0 Arm/CopyMem.S=C2=A0 =C2=A0 =C2=A0 =C2=A0| GCC
+=C2=A0 Arm/CompareMem.S=C2=A0 =C2=A0 | GCC
+=C2=A0 Arm/CompareGuid.S=C2=A0 =C2=A0| GCC

=C2=A0 =C2=A0Arm/ScanMem.asm=C2=A0 =C2=A0 =C2=A0|RVCT
=C2=A0 =C2=A0Arm/SetMem.asm=C2=A0 =C2=A0 =C2=A0 |RVCT
--
2.23.0



--
Baptiste Gerondeau
Engineer - HPC SIG - LDCG - Linaro
#irc : Bap= tisteGer
--00000000000015e6340592e59e7e--