From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22a; helo=mail-it0-x22a.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C91E22183C63 for ; Fri, 1 Dec 2017 05:52:25 -0800 (PST) Received: by mail-it0-x22a.google.com with SMTP id b5so2513599itc.3 for ; Fri, 01 Dec 2017 05:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=qR9DPK570OB4+horbtNlEQXLN5PdwuKwq7M8HShEq8A=; b=V1uZIKw7OIGpzrAp9uI8E2V4higfrhRnIMyyf2VQPyHpBP5SZjBINBxqVd3Xf4LTXQ FM9KUo6KD27Xjm2EKBnAAvSVTGITk+gj58WCFdnGZoo3VYoe8FJrFKKM/kIS52Q1PSzU njQNE1hv+OZQvGW0gJYab+9NcGqjTloAgjWybkzgVQzHxsGMnhnBxQwtgS8hY6FVw3D6 RtIl56RL7+F6RlQeLep+AY5tzrzgBdK+qutmvqIS4otO0G1AtwczXkv/7R6vH3xTQ9CR iCRBD+2lVWFvnwAl7DXXI/oWyZIZBa8WvBqwzp5AqqSwrHOetoLWg/J0FqIu3JLc1crW a6pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qR9DPK570OB4+horbtNlEQXLN5PdwuKwq7M8HShEq8A=; b=k/fSBEe4YBpsJjjvK5CNW5AifY4wDcBSP71CgJh61W5ok5t+3P4SPLvFCZnpUq+l3H 9tnF7ck33FyWG8lpTqJ+ROZMCAOF/GGnYcpFCdPJ8O/8ybfflRd41lWfYY3pK1WKaQM9 QZ916AeS3TwJMIcpc6tg+2813LiHhk3TZr4Ckz5GKX4wAiCN/0hAE9VQFrDWEa3dnaAA pP+5pH2zNZ6Vto40IXiNMeROlrKVO7wSp9JBTvNhB7rc1BXw8mY8Tg45EsDBw5xClGKP /ePVAV7O8VBqmhYrBA+jBIrpLIsEIFNUoy57muJ6rNxEQPF+8Xmd1xp8TpoMNFiOaLCq McbQ== X-Gm-Message-State: AKGB3mKn7c2Gh4v3pnHObbbsa1uCYwr6WEgH8xRo8GkDcpW+jS/vsSHl xQnUrel+mJuXS43v15pntFqupo7w8vpvoKyPLeMDLg== X-Google-Smtp-Source: AGs4zMbtgaNGukTC7e1Mo2Z3LOJiFG/tjV+8jafd6MjRNz8HeaJKHScgyIbMrFvbqBsVvmk64oQt6xwekZjneJaVS1A= X-Received: by 10.36.131.200 with SMTP id d191mr1907254ite.97.1512136611113; Fri, 01 Dec 2017 05:56:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Fri, 1 Dec 2017 05:56:50 -0800 (PST) In-Reply-To: <20171201130401.p4kirliksdkr6nra@bivouac.eciton.net> References: <1512095334-20345-1-git-send-email-mw@semihalf.com> <1512095334-20345-2-git-send-email-mw@semihalf.com> <20171201130401.p4kirliksdkr6nra@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 1 Dec 2017 14:56:50 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 1/4] Marvell/Armada: Switch to dynamic tftp command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 13:52:25 -0000 Content-Type: text/plain; charset="UTF-8" Hi Leif, 2017-12-01 14:04 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 03:28:51AM +0100, Marcin Wojtas wrote: >> After removal of the tftp library in EDK2, the tftp was >> disabled on Armada platform. Re-enable this functionality >> as a dynamic command. > > I did request this to be re-added as a build-time selectable option > like it is done on the Hisilicon platforms. > > Including non-standard shell commands by default does not make sense > to me. > Sure, I read your comment after sending the patch... Will correct it of course in v2. Best regards, Marcin >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Armada/Armada.dsc.inc | 1 + >> Platform/Marvell/Armada/Armada70x0.fdf | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc >> index 2a8a226..1b68ef3 100644 >> --- a/Platform/Marvell/Armada/Armada.dsc.inc >> +++ b/Platform/Marvell/Armada/Armada.dsc.inc >> @@ -524,6 +524,7 @@ >> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000 >> } >> + ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf >> >> [BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION] >> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 >> diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf >> index ca92c60..65c6474 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.fdf >> +++ b/Platform/Marvell/Armada/Armada70x0.fdf >> @@ -176,6 +176,7 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> >> # UEFI application (Shell Embedded Boot Loader) >> INF ShellPkg/Application/Shell/Shell.inf >> + INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf >> >> # Bds >> INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf >> -- >> 2.7.4 >>