From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mx.groups.io with SMTP id smtpd.web12.25716.1626687265928426527 for ; Mon, 19 Jul 2021 02:34:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=yUDdMWxv; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.171, mailfrom: mw@semihalf.com) Received: by mail-qt1-f171.google.com with SMTP id v14so12526534qtc.8 for ; Mon, 19 Jul 2021 02:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cRWG2PWgf6TbolOr03qJGbxk79c4F3/bKKF0gTRY5W4=; b=yUDdMWxvhdg5QCOUe+nPni6StYdWlSxl3yf9TF6OS0V0GLsZvbYoFYo3jYFtuJM77g SZitPP4yC59ZcnwsIMqO+g2qWi3PXfOt4q5TK88E/i5DH+7J4IcsM9KbZzibHTu8O6Jm v7uhfDga1yF3qcu2T9ltnPiE+1f3PY3JtVfxBf0Xo6px9mTlQN0AkjVralhCtBpsAUhU eSIGrzhG47cj6qBVlEKvvsKKDQbvCbykPqHJb8hq5oowirmMH5jxcBvlGA5uazOZyBoY zupAhlBbsjeOa8yEegwGdF/Tcy1TLn3a1LPRYQjZveqk2ujgiFwilzTvoXJ2M0aAlw2A 36yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cRWG2PWgf6TbolOr03qJGbxk79c4F3/bKKF0gTRY5W4=; b=X1bHHCSUq1m/iWFUxVYwchwj/SYT72/an+6cQiOvNRs2vNFo5S3c4IgMMB1FSvMrPf 1wioh0P7dgxSnkcQgVIgX1fhE+xh7HGM1y8F1cY0g/Uxfzr3Rxx4px3UrnakXAEFX7gr oKRHWXzSWw5PxbnXxmlaYhHrF2m8EbYraRVK7tmQQXxkrGEckqQpm3MjjryVjOtlSQxs xdfJrqE+TlNcQNtuiRg8b4Xs9SN9cQrp8XyiCR1eCNY0b41kydyoD2zis+SzNT1ZTHLW +lZuw9ofjNzx6mdweJuUQZdndVjmjKd29IDWvF2RYV0qmfrejCqpGIATAon+U7eEqNVU KsiQ== X-Gm-Message-State: AOAM532HlcTiSoIuW8VOlYhLv6Fp/JNduvKyTXF84COI1rGcx2TLpzoO EXnfm6GU1oKGF0k86b5k7t5jKkgKKH9hjbWvLFjqRw== X-Google-Smtp-Source: ABdhPJzaz8EyVObx4h7Ne4iV6XFCsWH/EZcLv+gpEs0fHm//VfyIBqZ8S8M4RPr/meldTib9F2Q9DqTaVf52LHLu/Cs= X-Received: by 2002:ac8:1349:: with SMTP id f9mr20431735qtj.16.1626687264886; Mon, 19 Jul 2021 02:34:24 -0700 (PDT) MIME-Version: 1.0 References: <20210613181631.2247221-1-mw@semihalf.com> <20210614215540.u2y4oc2s4cvs6kxw@leviathan> In-Reply-To: From: "Marcin Wojtas" Date: Mon, 19 Jul 2021 11:34:12 +0200 Message-ID: Subject: Re: [edk2-platforms PATCH 0/4] ACPI MDIO support for Marvell SoCs To: Ard Biesheuvel Cc: Jon Nettleton , Leif Lindholm , Ard Biesheuvel , edk2-devel-groups-io , Grzegorz Jaszczyk , Grzegorz Bernacki , upstream@semihalf.com, Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, pon., 19 lip 2021 o 09:28 Ard Biesheuvel napisa=C5=82(a): > > On Fri, 16 Jul 2021 at 19:32, Ard Biesheuvel wrote: > > > > On Mon, 12 Jul 2021 at 13:17, Jon Nettleton wrote: > > > > > > On Mon, Jul 12, 2021 at 12:52 PM Marcin Wojtas wrot= e: > > > > > > > > Hi, > > > > > > > > wt., 29 cze 2021 o 16:17 Marcin Wojtas napisa=C5= =82(a): > > > > > > > > > > Hi Leif, > > > > > > > > > > pon., 14 cze 2021 o 23:55 Leif Lindholm napis= a=C5=82(a): > > > > > > > > > > > > Hi Marcin, > > > > > > > > > > > > On Sun, Jun 13, 2021 at 20:16:27 +0200, Marcin Wojtas wrote: > > > > > > > Hi, > > > > > > > > > > > > > > The MDIO ACPI binding has been established and merged to the > > > > > > > Linux tree, > > > > > > > > > > > > Congratulations! :) > > > > > > > > > > > > Is FreeBSD expected to follow suit? > > > > > > > > > > There's no driver yet, but once it's finally created I will make = sure > > > > > it supports ACPI properly. > > > > > > > > > > > > > > > > > > hence it is now possible to update the ACPI > > > > > > > description of the platforms that base on the Marvell SoCs. > > > > > > > > > > > > > > For convenience, the code is exposed in the public github bra= nch: > > > > > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/comm= its/acpi-mdio-r20210613 > > > > > > > There is also MacchiatoBin firmware binary avaialable for tes= ting: > > > > > > > https://drive.google.com/file/d/1eigP_aeM4wYQpEaLAlQzs3IN_w1-= kQr0 > > > > > > > > > > > > > > I'm looking forward to the comments or remarks. > > > > > > > > > > > > The patches themselves look straightforward enough. > > > > > > I *would* prefer some tested-by, for these sources rather than = the > > > > > > binary, before merging though. > > > > > > > > > > > > > > > > I have some our patches queued, that are blocked by this patchset= . In > > > > > case no time is found for external testers - if this may help to = get > > > > > it pushed through, please see below logs from the next-20210628 t= ag > > > > > and unchanged firmware. All network ports of MacchiatoBin and > > > > > CN913x-DB work properly, with full 1G/10G PHY support via X/MDIO > > > > > interfaces: > > > > > > > > > > MacchiatoBin > > > > > # uname -a > > > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 2= 9 > > > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > > > # dmesg | grep MRVL0101 > > > > > [ 1.829659] mv88x3340 MRVL0101:00-mii:00: Firmware version 0.3= .3.0 > > > > > [ 1.839622] mv88x3340 MRVL0101:00-mii:08: Firmware version 0.3= .3.0 > > > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] d= river > > > > > [mv88x3340] (irq=3DPOLL) > > > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] d= river > > > > > [mv88x3340] (irq=3DPOLL) > > > > > # dmesg | grep MRVL0100 > > > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > # dmesg | grep mvpp2 > > > > > [...] > > > > > [ 2.748351] mvpp2 MRVL0110:00 eth1: PHY [MRVL0101:00-mii:00] d= river > > > > > [mv88x3340] (irq=3DPOLL) > > > > > [ 2.756701] mvpp2 MRVL0110:00 eth1: configuring for phy/10gbas= e-r link mode > > > > > [ 2.767479] mvpp2 MRVL0110:01 eth2: PHY [MRVL0101:00-mii:08] d= river > > > > > [mv88x3340] (irq=3DPOLL) > > > > > [ 2.775834] mvpp2 MRVL0110:01 eth2: configuring for phy/10gbas= e-r link mode > > > > > [ 2.919424] mvpp2 MRVL0110:01 eth3: PHY [MRVL0100:00-mii:00] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > [ 2.928285] mvpp2 MRVL0110:01 eth3: configuring for phy/sgmii = link mode > > > > > [ 2.936351] mvpp2 MRVL0110:01 eth4: configuring for > > > > > inband/2500base-x link mode > > > > > [ 5.987259] mvpp2 MRVL0110:01 eth3: Link is Up - 1Gbps/Full - = flow > > > > > control off > > > > > # > > > > > > > > > > CN913x-DB > > > > > # uname -a > > > > > Linux buildroot 5.13.0-rc7-next-20210628 #6 SMP PREEMPT Tue Jun 2= 9 > > > > > 09:14:07 CEST 2021 aarch64 GNU/Linux > > > > > # dmesg | grep MRVL0100 > > > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > # dmesg | grep mvpp2 > > > > > [...] > > > > > [ 2.544917] mvpp2 MRVL0110:00 eth1: configuring for > > > > > inband/10gbase-r link mode > > > > > [ 2.552480] mvpp2 MRVL0110:00 eth1: Link is Up - 10Gbps/Full -= flow > > > > > control rx > > > > > [ 2.621201] mvpp2 MRVL0110:00 eth2: PHY [MRVL0100:00-mii:00] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > [ 2.630060] mvpp2 MRVL0110:00 eth2: configuring for phy/rgmii-= id link mode > > > > > [ 2.741199] mvpp2 MRVL0110:00 eth3: PHY [MRVL0100:00-mii:01] d= river > > > > > [Marvell 88E1510] (irq=3DPOLL) > > > > > [ 2.750056] mvpp2 MRVL0110:00 eth3: configuring for phy/rgmii-= id link mode > > > > > [ 2.810169] mvpp2 MRVL0110:01 eth4: configuring for > > > > > inband/10gbase-r link mode > > > > > [ 2.817471] mvpp2 MRVL0110:01 eth4: Link is Up - 10Gbps/Full -= flow > > > > > control rx > > > > > [ 5.693231] mvpp2 MRVL0110:00 eth2: Link is Up - 1Gbps/Full - = flow > > > > > control off > > > > > [ 10.840942] mvpp2 MRVL0110:00 eth1: Link is Down > > > > > [ 10.864124] mvpp2 MRVL0110:01 eth4: Link is Down > > > > > # > > > > > > > > > > > > > Both platforms were have been additionally tested by Greg, do you h= ave > > > > any comments/objections to merging this patchset? > > > > > > > > Thanks, > > > > Marcin > > > > > > You can add my Tested-by as well. Finally got time over the weekend > > > to verify on all my Marvell platforms this effects. > > > > > > > Thanks all. I will get to this shortly - apologies for the delay. > > Pushed as bfabeef4c9a6..955187a12a8b > > Thanks all. Thanks a lot! I'd appreciate if you were able to take a look at our new patchset I just submitted on top of the merged changes. Best regards, Marcin